Remove Toolbox bootstrap registry metadata ownership - PR_26160_069-toolbox-remove-bootstrap-registry

Author: ToolboxAid

admin/tool-votes.js

@@ -21,6 +21,15 @@ const RELEASE_CHANNEL_OPTIONS = Object.freeze([
   ["complete", "Complete"],
 ]);
 const RELEASE_CHANNEL_LABELS = new Map(RELEASE_CHANNEL_OPTIONS);
+const GROUP_OPTIONS = Object.freeze([
+  "AI",
+  "Audio",
+  "Build/Create",
+  "Design",
+  "Marketplace",
+  "Platform",
+  "Play",
+]);
 
 const SORT_TYPES = Object.freeze({
   down: "number",
@@ -89,6 +98,76 @@ function orderCell(voteRow) {
   return cell;
 }
 
+function updateMetadata(voteRow, updates, successLabel) {
+  const nextGroup = updates.group ?? voteRow.group;
+  const nextPath = updates.path ?? voteRow.path;
+  const nextState = updates.status ?? rowReleaseChannel(voteRow);
+  try {
+    const snapshot = updateToolboxVoteMetadata(voteRow.toolId, {
+      group: nextGroup,
+      path: nextPath,
+      status: nextState,
+      releaseChannel: nextState,
+    });
+    window.setTimeout(() => {
+      renderSnapshot(snapshot, `${voteRow.toolName} ${successLabel}. Toolbox Build Path uses the same metadata.`);
+      selectRow(voteRow.toolId);
+    }, 0);
+  } catch (error) {
+    const message = error instanceof Error ? error.message : String(error || "Toolbox metadata update unavailable.");
+    setStatus(`${voteRow.toolName} metadata could not be updated. ${message}`);
+    renderRows(snapshotRows);
+  }
+}
+
+function groupCell(voteRow) {
+  const cell = document.createElement("td");
+  const select = document.createElement("select");
+  const currentGroup = String(voteRow.group || "").trim();
+  const options = GROUP_OPTIONS.includes(currentGroup) || !currentGroup
+    ? GROUP_OPTIONS
+    : [...GROUP_OPTIONS, currentGroup];
+  select.dataset.toolboxVotesGroup = voteRow.toolId;
+  select.setAttribute("aria-label", `Group for ${voteRow.toolName}`);
+  options.forEach((group) => {
+    const option = document.createElement("option");
+    option.value = group;
+    option.textContent = group;
+    select.append(option);
+  });
+  select.value = currentGroup || GROUP_OPTIONS[0];
+  select.addEventListener("click", (event) => {
+    event.stopPropagation();
+  });
+  select.addEventListener("change", () => {
+    if (select.value !== currentGroup) {
+      updateMetadata(voteRow, { group: select.value }, `group updated to ${select.value}`);
+    }
+  });
+  cell.append(select);
+  return cell;
+}
+
+function pathCell(voteRow) {
+  const cell = document.createElement("td");
+  const input = document.createElement("input");
+  input.dataset.toolboxVotesPath = voteRow.toolId;
+  input.setAttribute("aria-label", `Path for ${voteRow.toolName}`);
+  input.type = "text";
+  input.value = voteRow.path || "";
+  input.addEventListener("click", (event) => {
+    event.stopPropagation();
+  });
+  input.addEventListener("change", () => {
+    const nextPath = input.value.trim().replace(/^\/+/, "");
+    if (nextPath !== voteRow.path) {
+      updateMetadata(voteRow, { path: nextPath }, "path updated");
+    }
+  });
+  cell.append(input);
+  return cell;
+}
+
 function releaseChannelLabel(value) {
   return RELEASE_CHANNEL_LABELS.get(value) || RELEASE_CHANNEL_LABELS.get("planned");
 }
@@ -126,20 +205,7 @@ function handleStateChange(voteRow, select) {
   if (nextState === rowReleaseChannel(voteRow)) {
     return;
   }
-  try {
-    const snapshot = updateToolboxVoteMetadata(voteRow.toolId, {
-      group: voteRow.group,
-      path: voteRow.path,
-      status: nextState,
-      releaseChannel: nextState,
-    });
-    renderSnapshot(snapshot, `${voteRow.toolName} state updated to ${releaseChannelLabel(nextState)}. Toolbox Build Path uses the same metadata.`);
-    selectRow(voteRow.toolId);
-  } catch (error) {
-    select.value = rowReleaseChannel(voteRow);
-    const message = error instanceof Error ? error.message : String(error || "Toolbox state update unavailable.");
-    setStatus(`${voteRow.toolName} state could not be updated. ${message}`);
-  }
+  updateMetadata(voteRow, { status: nextState }, `state updated to ${releaseChannelLabel(nextState)}`);
 }
 
 function sortValue(voteRow, key) {
@@ -296,8 +362,8 @@ function renderRows(rows) {
     row.append(
       toolNameCell(voteRow),
       orderCell(voteRow),
-      tableCell(voteRow.group),
-      tableCell(voteRow.path),
+      groupCell(voteRow),
+      pathCell(voteRow),
       stateCell(voteRow),
       tableCell(voteRow.up),
       tableCell(voteRow.down),

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -6,15 +6,19 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/shared/toolbox/platformShell.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(74%) admin/tool-votes.js - executed lines 320/320; executed functions 29/39
-(84%) toolbox/tools-page-accordions.js - executed lines 997/997; executed functions 90/107
+(62%) admin/tool-votes.js - executed lines 383/383; executed functions 29/47
+(88%) toolbox/tools-page-accordions.js - executed lines 997/997; executed functions 94/107
 
 Guardrail warnings:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file missing from coverage; advisory only
+(0%) src/shared/toolbox/platformShell.js - WARNING: changed runtime JS file missing from coverage; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -12,43 +12,50 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(80%) Toolbox Index - exercised 3 runtime JS files
+(68%) Toolbox Index - exercised 5 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (74%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
+(0%) src/shared/toolbox/platformShell.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(74%) admin/tool-votes.js - executed lines 320/320; executed functions 29/39
-(84%) toolbox/tools-page-accordions.js - executed lines 997/997; executed functions 90/107
+(62%) admin/tool-votes.js - executed lines 383/383; executed functions 29/47
+(88%) toolbox/tools-page-accordions.js - executed lines 997/997; executed functions 94/107
 
 Files with executed line/function counts where available:
+(33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
 (38%) src/engine/api/session-api-client.js - executed lines 34/34; executed functions 3/8
-(50%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 3/6
-(53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
-(63%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 15/24
+(55%) toolbox/colors/colors.js - executed lines 2289/2289; executed functions 119/216
+(58%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 11/19
+(62%) admin/tool-votes.js - executed lines 383/383; executed functions 29/47
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(74%) admin/tool-votes.js - executed lines 320/320; executed functions 29/39
 (77%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 548/548; executed functions 37/48
-(84%) toolbox/tools-page-accordions.js - executed lines 997/997; executed functions 90/107
+(88%) toolbox/tools-page-accordions.js - executed lines 997/997; executed functions 94/107
+(89%) toolbox/tool-registry-api-client.js - executed lines 148/148; executed functions 24/27
+(100%) toolbox/colors/palette-api-client.js - executed lines 19/19; executed functions 4/4
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) src/dev-runtime/server/mock-api-router.mjs - WARNING: uncovered changed runtime JS file; advisory only
+(0%) src/shared/toolbox/platformShell.js - WARNING: uncovered changed runtime JS file; advisory only
 (0%) toolbox/toolRegistry.js - WARNING: uncovered changed runtime JS file; advisory only
 
 Changed JS files considered:
+(0%) src/dev-runtime/guest-seeds/tool-metadata-inventory.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/guest-seeds/tool-state-samples.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/server/mock-api-router.mjs - changed JS file not collected as browser runtime coverage
-(0%) tests/playwright/tools/AdminPlatformToolsWireframes.spec.mjs - changed JS file not collected as browser runtime coverage
+(0%) src/shared/toolbox/platformShell.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/BuildPathProgressSimplification.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/ToolboxRoutePages.spec.mjs - changed JS file not collected as browser runtime coverage
 (0%) toolbox/toolRegistry.js - changed JS file not collected as browser runtime coverage
-(74%) admin/tool-votes.js - changed JS file with browser V8 coverage
-(84%) toolbox/tools-page-accordions.js - changed JS file with browser V8 coverage
+(62%) admin/tool-votes.js - changed JS file with browser V8 coverage
+(88%) toolbox/tools-page-accordions.js - changed JS file with browser V8 coverage

docs_build/dev/reports/toolbox-remove-bootstrap-registry-report.md

@@ -0,0 +1,63 @@
+# PR_26160_069 Toolbox Remove Bootstrap Registry Report
+
+## Branch Validation
+
+| Check | Expected | Actual | Status |
+| --- | --- | --- | --- |
+| Current git branch | `main` | `main` | PASS |
+
+## Requirement Checklist
+
+| Requirement | Status | Evidence |
+| --- | --- | --- |
+| Remove remaining Toolbox metadata ownership from `toolbox/toolRegistry.js`. | PASS | `toolbox/toolRegistry.js` now exports an empty compatibility shell with no tool records. |
+| Stop using `toolbox/toolRegistry.js` as bootstrap route/image/default seed registry. | PASS | Active browser/static audit found no imports or references outside the shell; server seed ownership moved to `src/dev-runtime/guest-seeds/tool-metadata-inventory.js`. |
+| Move route, badge/image, group, order, path, and status metadata into DB-backed tool metadata. | PASS | `toolbox_tool_metadata` schema and seed rows now include route/path, badge/tool image, group/category/color, order, status, active/admin/visibility, and descriptive fields. |
+| Toolbox reads tool metadata only through API/service contract backed by DB adapter. | PASS | `toolbox/tool-registry-api-client.js` reads `/api/toolbox/registry/snapshot`; `toolbox/tools-page-accordions.js` uses registry/vote API clients. |
+| Admin Tool Votes reads tool metadata only through API/service contract backed by DB adapter. | PASS | `admin/tool-votes.js` uses `readToolboxVoteSnapshot`, `reorderToolboxVoteRows`, and `updateToolboxVoteMetadata`. |
+| Remove compatibility-only browser metadata lookups where safe. | PASS | Direct browser imports of `toolbox/toolRegistry.js` were removed from targeted Toolbox/Admin tests; active browser audit found no import usage. |
+| Keep `toolId` and `releaseChannel` only as compatibility aliases, not primary metadata source. | PASS | Server rows use `toolKey`/`status` as primary values while preserving `toolId`/`releaseChannel` for existing vote row compatibility. |
+| Preserve 43-tool inventory. | PASS | API probe returned `activeTools: 43` and `voteRows: 43`; Playwright verified Toolbox and Admin Tool Votes show matching 43 rows. |
+| Preserve MIDI and Music as separate tools. | PASS | API probe returned `hasMidi: true` and `hasMusic: true`. |
+| Admin edits to order/group/path/status affect Toolbox after reload. | PASS | `ToolboxAdminMetadataSsot.spec.mjs` edits `Creator Learning` metadata and verifies Toolbox Build Path reflects order/group/path/status after reload. |
+| Do not migrate unrelated game/sample data. | PASS | Changes are limited to Toolbox/Admin metadata, dev seed inventory, shared shell diagnostics, and targeted validation. |
+| No inline script/style/event handlers. | PASS | No HTML inline handlers or style/script blocks were added. |
+
+## Remaining-Registry Audit
+
+| Audit | Command / Evidence | Status |
+| --- | --- | --- |
+| Active app code imports `toolbox/toolRegistry.js` | `rg 'from ["''].*toolRegistry\.js\|import\(["''].*toolRegistry\.js' assets admin toolbox src -n --glob '!toolbox/toolRegistry.js'` returned no matches. | PASS |
+| Active app code references `toolbox/toolRegistry.js` | `rg 'toolbox/toolRegistry\.js' assets admin toolbox src -n --glob '!toolbox/toolRegistry.js'` returned no matches after updating shared shell diagnostics. | PASS |
+| Toolbox/Admin page-local hardcoded counts | `rg 'Planned \([0-9]+\)\|Wireframe \([0-9]+\)\|Beta \([0-9]+\)\|Complete \([0-9]+\)\|Tool Count: [0-9]+/[0-9]+' toolbox admin assets src -n` returned no matches. | PASS |
+| Browser requests retired registry module | Playwright `ToolboxAdminMetadataSsot.spec.mjs` verifies Toolbox/Admin pages do not request `/toolbox/toolRegistry.js`. | PASS |
+
+## Validation
+
+| Lane | Command | Result |
+| --- | --- | --- |
+| Changed-file syntax | `node --check` on changed JS/MJS files | PASS |
+| Static diff whitespace | `git diff --check` | PASS |
+| Static registry import audit | `rg` checks listed above | PASS |
+| API contract probe | Server probe of `/api/toolbox/registry/snapshot` and `/api/toolbox/votes/snapshot` | PASS: 43/43, no missing records |
+| Admin Tool Votes / Toolbox SSoT Playwright | `npx playwright test tests/playwright/tools/ToolboxAdminMetadataSsot.spec.mjs --reporter=line` | PASS: 4/4 |
+| Toolbox route/display Playwright | `npx playwright test tests/playwright/tools/ToolboxRoutePages.spec.mjs --reporter=line` | PASS: 8/8 |
+| Build Path Playwright | `npx playwright test tests/playwright/tools/BuildPathProgressSimplification.spec.mjs --reporter=line` | PASS: 4/4 |
+
+## Impacted Lane
+
+Toolbox/Admin Tool Votes validation only.
+
+## Skipped Lanes
+
+| Lane | Reason |
+| --- | --- |
+| Full samples validation | Safe to skip per request; this PR does not touch samples or shared sample loader/framework code. |
+| Unrelated tool runtime lanes | Safe to skip; changes are scoped to Toolbox metadata, Admin Tool Votes, server API metadata, and targeted tests. |
+
+## Manual Test Notes
+
+- Confirmed branch guard before implementation: current branch `main`.
+- Confirmed server API snapshots agree on the 43-tool inventory.
+- Confirmed MIDI and Music remain separate DB-backed tools.
+- Confirmed Admin Tool Votes metadata edits flow back into Toolbox Build Path after reload.