Skip to content

Commit 25c23f6

Browse files
ToolboxAidToolboxAid
committed
Keep Build Play Share hero entry cards in equal thirds - PR_26164_089-home-entry-card-thirds
1 parent cac5484 commit 25c23f6

4 files changed

Lines changed: 142 additions & 69 deletions

File tree

‎assets/theme-v2/css/layout.css‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@ body.tool-focus-mode .tool-workspace--table-scroll-focus .tool-table-scroll-regi
656656

657657
.dual-entry {
658658
display: grid;
659-
grid-template-columns: var(--two-columns);
659+
grid-template-columns: var(--grid-cols-3);
660660
gap: var(--space-14);
661661
margin-top: var(--space-34)
662662
}

‎docs_build/dev/reports/PR_26164_089-home-entry-card-thirds.md‎

Lines changed: 83 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,83 @@
1+
# PR_26164_089-home-entry-card-thirds
2+
3+
## Branch Validation
4+
5+
- Current branch: `main`
6+
- Expected branch: `main`
7+
- Local branches found: `* main`
8+
- Result: PASS
9+
10+
## Scope
11+
12+
- Updated reusable Theme V2 home layout styling in `assets/theme-v2/css/layout.css`.
13+
- No `index.html` content changes were required because the Build, Play, and Share entry cards already exist in the Home hero.
14+
- Required report artifacts updated:
15+
- `docs_build/dev/reports/codex_review.diff`
16+
- `docs_build/dev/reports/codex_changed_files.txt`
17+
18+
## Requirement Checklist
19+
20+
- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before execution: PASS
21+
- Verified current branch is `main` before making changes: PASS
22+
- Scoped PR to Home hero entry-card layout and required reports only: PASS
23+
- Ensured Build, Play, and Share entry cards stay on one horizontal row on desktop: PASS
24+
- Reduced individual entry-card width to one third of the available entry-card row: PASS
25+
- Kept all three cards side by side: PASS
26+
- Used existing Theme V2 layout tokens first: PASS
27+
- Added reusable Theme V2 styling only under `assets/theme-v2/css/`: PASS
28+
- Did not use inline styles, style blocks, script blocks, or inline event handlers: PASS
29+
- Preserved responsive behavior for smaller screens: PASS
30+
- Ran `git diff --check`: PASS
31+
- Validated home page renders: PASS
32+
- Validated cards remain readable on smaller screens: PASS
33+
- Playwright impacted: No. Layout/content only: PASS
34+
- Required repo-structured ZIP produced: PASS
35+
36+
## Manual Validation Notes
37+
38+
- Reviewed the Home hero entry-card markup in `index.html`.
39+
- Confirmed `index.html` contains the three hero entry cards in order:
40+
- Build
41+
- Play
42+
- Share
43+
- Reviewed active Theme V2 imports and confirmed `theme.css` imports `layout.css`.
44+
- Confirmed `.dual-entry` was the active Home hero entry-card row layout rule.
45+
- Updated `.dual-entry` from `var(--two-columns)` to `var(--grid-cols-3)`, using the existing `repeat(3, 1fr)` Theme V2 token.
46+
- Confirmed the existing `@media(max-width:620px)` rule still collapses `.dual-entry` to `var(--one-column)` for smaller screens.
47+
48+
## Validation
49+
50+
- `git diff --check`: PASS
51+
- Note: Git reported an LF-to-CRLF working-copy warning for `assets/theme-v2/css/layout.css`; the command exited successfully.
52+
- Home page render-shell validation: PASS
53+
- Build / Play / Share entry-card content validation: PASS
54+
- Desktop three-column CSS validation: PASS
55+
- `.dual-entry` uses `grid-template-columns: var(--grid-cols-3)`.
56+
- `--grid-cols-3` resolves to `repeat(3, 1fr)`.
57+
- Smaller-screen readability validation: PASS
58+
- Existing `@media(max-width:620px)` rule keeps `.dual-entry` at `var(--one-column)`.
59+
- Inline HTML restriction check: PASS
60+
- No `<style>` blocks.
61+
- No inline `<script>` blocks.
62+
- No inline event handlers.
63+
- No inline `style` attributes.
64+
65+
## Playwright
66+
67+
- Playwright impacted: No.
68+
- Playwright run: SKIP.
69+
- Reason: This PR changes reusable CSS layout only. No runtime behavior, tool workflow, shared engine behavior, or browser interaction changed.
70+
71+
## Samples
72+
73+
- Full samples smoke test: SKIP.
74+
- Reason: No samples or runtime game surfaces changed.
75+
76+
## Review Artifacts
77+
78+
- `docs_build/dev/reports/codex_review.diff`: PASS
79+
- `docs_build/dev/reports/codex_changed_files.txt`: PASS
80+
81+
## ZIP
82+
83+
- `tmp/PR_26164_089-home-entry-card-thirds_delta.zip`: PASS

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
# scoped git status --short
2-
M index.html
3-
?? docs_build/dev/reports/PR_26164_088-home-share-entry.md
2+
M assets/theme-v2/css/layout.css
3+
M docs_build/dev/reports/codex_changed_files.txt
4+
M docs_build/dev/reports/codex_review.diff
5+
?? docs_build/dev/reports/PR_26164_089-home-entry-card-thirds.md
46

5-
# scoped git diff --stat
6-
index.html | 3 ++-
7-
1 file changed, 2 insertions(+), 1 deletion(-)
8-
9-
# scoped untracked files included in review diff
10-
docs_build/dev/reports/PR_26164_088-home-share-entry.md
11-
12-
# generated review artifacts
7+
# scoped files included in this PR
8+
assets/theme-v2/css/layout.css
9+
docs_build/dev/reports/PR_26164_089-home-entry-card-thirds.md
1310
docs_build/dev/reports/codex_review.diff
1411
docs_build/dev/reports/codex_changed_files.txt
12+
13+
# notes
14+
Review diff is scoped to the reusable Theme V2 layout change and the PR report.

‎docs_build/dev/reports/codex_review.diff‎

Lines changed: 48 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,29 +1,23 @@
1-
diff --git a/index.html b/index.html
2-
index 65d07ac0a..aac42f207 100644
3-
--- a/index.html
4-
+++ b/index.html
5-
@@ -22,12 +22,13 @@
6-
open-web experiences with no coding required.</p>
7-
<p>Advanced creators can extend projects later with custom enhancements and scripting.</p>
8-
<div class="hero-cta"><a class="btn primary" href="toolbox/index.html">Start Building</a><a class="btn"
9-
- href="games/index.html">Explore Games</a></div>
10-
+ href="games/index.html">Explore Games</a><a class="btn" href="marketplace/index.html">Share Creations</a></div>
11-
<div class="dual-entry" aria-label="Primary entry points">
12-
<a class="entry-card" href="toolbox/index.html"><span>Build</span><strong>Create Games</strong><small>Open the
13-
Toolbox</small></a>
14-
<a class="entry-card" href="games/index.html"><span>Play</span><strong>Play Games</strong><small>Browse the
15-
Arcade</small></a>
16-
+ <a class="entry-card" href="marketplace/index.html"><span>Share</span><strong>Share Creations</strong><small>Publish and Connect</small></a>
17-
</div>
18-
</div>
19-
<aside class="hero-art" aria-label="GameFoundryStudio logo artwork">
20-
diff --git a/docs_build/dev/reports/PR_26164_088-home-share-entry.md b/docs_build/dev/reports/PR_26164_088-home-share-entry.md
1+
diff --git a/assets/theme-v2/css/layout.css b/assets/theme-v2/css/layout.css
2+
index f94eb3d72..a9614b412 100644
3+
--- a/assets/theme-v2/css/layout.css
4+
+++ b/assets/theme-v2/css/layout.css
5+
@@ -656,7 +656,7 @@ body.tool-focus-mode .tool-workspace--table-scroll-focus .tool-table-scroll-regi
6+
7+
.dual-entry {
8+
display: grid;
9+
- grid-template-columns: var(--two-columns);
10+
+ grid-template-columns: var(--grid-cols-3);
11+
gap: var(--space-14);
12+
margin-top: var(--space-34)
13+
}
14+
diff --git a/docs_build/dev/reports/PR_26164_089-home-entry-card-thirds.md b/docs_build/dev/reports/PR_26164_089-home-entry-card-thirds.md
2115
new file mode 100644
22-
index 000000000..534e8ae58
16+
index 000000000..0eadffd4a
2317
--- /dev/null
24-
+++ b/docs_build/dev/reports/PR_26164_088-home-share-entry.md
25-
@@ -0,0 +1,87 @@
26-
+# PR_26164_088-home-share-entry
18+
+++ b/docs_build/dev/reports/PR_26164_089-home-entry-card-thirds.md
19+
@@ -0,0 +1,83 @@
20+
+# PR_26164_089-home-entry-card-thirds
2721
+
2822
+## Branch Validation
2923
+
@@ -34,57 +28,53 @@ index 000000000..534e8ae58
3428
+
3529
+## Scope
3630
+
37-
+- Updated `index.html`.
38-
+- No navigation file changes were required.
31+
+- Updated reusable Theme V2 home layout styling in `assets/theme-v2/css/layout.css`.
32+
+- No `index.html` content changes were required because the Build, Play, and Share entry cards already exist in the Home hero.
3933
+- Required report artifacts updated:
4034
+ - `docs_build/dev/reports/codex_review.diff`
4135
+ - `docs_build/dev/reports/codex_changed_files.txt`
4236
+
43-
+## Routing Decision
44-
+
45-
+- Share destination selected: `marketplace/index.html`
46-
+- Reason: `marketplace/index.html` exists, so it is the current best available share-facing destination requested by the PR.
47-
+- Temporary fallback needed: No.
48-
+
4937
+## Requirement Checklist
5038
+
5139
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before execution: PASS
5240
+- Verified current branch is `main` before making changes: PASS
53-
+- Scope limited to `index.html` and required reports only: PASS
54-
+- Added third hero entry card for Share: PASS
55-
+- Share entry card uses `Share`, `Share Creations`, and `Publish and Connect`: PASS
56-
+- Share entry card links to `marketplace/index.html`: PASS
57-
+- Added third hero CTA button `Share Creations`: PASS
58-
+- Share CTA links to `marketplace/index.html`: PASS
41+
+- Scoped PR to Home hero entry-card layout and required reports only: PASS
42+
+- Ensured Build, Play, and Share entry cards stay on one horizontal row on desktop: PASS
43+
+- Reduced individual entry-card width to one third of the available entry-card row: PASS
44+
+- Kept all three cards side by side: PASS
45+
+- Used existing Theme V2 layout tokens first: PASS
46+
+- Added reusable Theme V2 styling only under `assets/theme-v2/css/`: PASS
47+
+- Did not use inline styles, style blocks, script blocks, or inline event handlers: PASS
48+
+- Preserved responsive behavior for smaller screens: PASS
5949
+- Ran `git diff --check`: PASS
6050
+- Validated home page renders: PASS
61-
+- Validated Build, Play, and Share hero entry cards appear together: PASS
62-
+- Validated all hero CTA and entry-card links resolve: PASS
63-
+- Validated no inline script/style/event handlers were added: PASS
64-
+- Playwright impacted: No. Content/navigation only: PASS
51+
+- Validated cards remain readable on smaller screens: PASS
52+
+- Playwright impacted: No. Layout/content only: PASS
6553
+- Required repo-structured ZIP produced: PASS
6654
+
6755
+## Manual Validation Notes
6856
+
69-
+- Confirmed the existing hero entry cards were Build and Play.
70-
+- Confirmed `marketplace/index.html` exists before choosing it as the Share destination.
71-
+- Confirmed the hero now has three CTA links:
72-
+ - `Start Building` -> `toolbox/index.html`
73-
+ - `Explore Games` -> `games/index.html`
74-
+ - `Share Creations` -> `marketplace/index.html`
75-
+- Confirmed the hero now has three entry cards:
76-
+ - Build -> `toolbox/index.html`
77-
+ - Play -> `games/index.html`
78-
+ - Share -> `marketplace/index.html`
79-
+- No CSS or JavaScript files were changed.
57+
+- Reviewed the Home hero entry-card markup in `index.html`.
58+
+- Confirmed `index.html` contains the three hero entry cards in order:
59+
+ - Build
60+
+ - Play
61+
+ - Share
62+
+- Reviewed active Theme V2 imports and confirmed `theme.css` imports `layout.css`.
63+
+- Confirmed `.dual-entry` was the active Home hero entry-card row layout rule.
64+
+- Updated `.dual-entry` from `var(--two-columns)` to `var(--grid-cols-3)`, using the existing `repeat(3, 1fr)` Theme V2 token.
65+
+- Confirmed the existing `@media(max-width:620px)` rule still collapses `.dual-entry` to `var(--one-column)` for smaller screens.
8066
+
8167
+## Validation
8268
+
8369
+- `git diff --check`: PASS
84-
+ - Note: Git reported an LF-to-CRLF working-copy warning for `index.html`; the command exited successfully.
70+
+ - Note: Git reported an LF-to-CRLF working-copy warning for `assets/theme-v2/css/layout.css`; the command exited successfully.
8571
+- Home page render-shell validation: PASS
86-
+- Build / Play / Share hero entry card validation: PASS
87-
+- Hero CTA and entry-card link resolution: PASS
72+
+- Build / Play / Share entry-card content validation: PASS
73+
+- Desktop three-column CSS validation: PASS
74+
+ - `.dual-entry` uses `grid-template-columns: var(--grid-cols-3)`.
75+
+ - `--grid-cols-3` resolves to `repeat(3, 1fr)`.
76+
+- Smaller-screen readability validation: PASS
77+
+ - Existing `@media(max-width:620px)` rule keeps `.dual-entry` at `var(--one-column)`.
8878
+- Inline HTML restriction check: PASS
8979
+ - No `<style>` blocks.
9080
+ - No inline `<script>` blocks.
@@ -95,7 +85,7 @@ index 000000000..534e8ae58
9585
+
9686
+- Playwright impacted: No.
9787
+- Playwright run: SKIP.
98-
+- Reason: This PR changes static Home page content/navigation only. No runtime behavior, tool workflow, shared engine behavior, or browser interaction changed.
88+
+- Reason: This PR changes reusable CSS layout only. No runtime behavior, tool workflow, shared engine behavior, or browser interaction changed.
9989
+
10090
+## Samples
10191
+
@@ -109,4 +99,4 @@ index 000000000..534e8ae58
10999
+
110100
+## ZIP
111101
+
112-
+- `tmp/PR_26164_088-home-share-entry_delta.zip`: PASS
102+
+- `tmp/PR_26164_089-home-entry-card-thirds_delta.zip`: PASS

0 commit comments

Comments
 (0)