Add actionable Objects status links for render hitbox and events gaps - PR_26161_007-objects-status-action-links

Author: ToolboxAid

docs_build/dev/codex_commands.md

@@ -1264,3 +1264,33 @@ Required reports:
 - `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
 - `docs_build/dev/reports/codex_changed_files.txt`
 - `docs_build/dev/reports/codex_review.diff`
+
+
+## PR_26161_007-objects-status-action-links
+
+Changes:
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Verified the current branch is `main` before edits.
+- Continued from the current Objects tool Type Catalog state.
+- Replaced aggregate Object Status rows with per-object actionable status rows.
+- Added creator-facing row gap labels: `Missing Render Asset`, `Missing Hitbox`, `Missing Events`, and `Ready`.
+- Added row-level `Edit Sprite`, `Open Hitboxes`, and `Open Events` links where applicable.
+- Preserved table-first input, `Add Object` below the table, disabled Add while adding, Cancel, Edit, Trash, and Reset Table.
+- Preserved real Sprite render asset creation, resolution, preview, and Sprite Editor linking.
+- Did not change engine runtime behavior, sample JSON, auth behavior, production DB behavior, or unrelated tool behavior.
+
+Validation:
+- `node --check toolbox/objects/objects.js`
+- `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- HTML restriction check for `toolbox/objects/index.html`
+- Objects forbidden wording scan for requested terms
+- `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line`
+- `git diff --check`
+- Full samples validation skipped by request and because samples/runtime behavior were not changed.
+
+Required reports:
+- `docs_build/dev/reports/objects-status-action-links-report.md`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+- `docs_build/dev/reports/codex_changed_files.txt`
+- `docs_build/dev/reports/codex_review.diff`

docs_build/dev/commit_comment.txt

@@ -1 +1 @@
-Add Objects type catalog - PR_26161_008-object-type-catalog
+Add Objects status action links - PR_26161_007-objects-status-action-links

docs_build/dev/reports/codex_changed_files.txt

@@ -3,8 +3,8 @@ docs_build/dev/commit_comment.txt
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/codex_review.diff
 docs_build/dev/reports/coverage_changed_js_guardrail.txt
+docs_build/dev/reports/objects-status-action-links-report.md
 docs_build/dev/reports/playwright_v8_coverage_report.txt
-docs_build/dev/reports/PR_26161_008_object_type_catalog.md
 tests/playwright/tools/ObjectsTool.spec.mjs
 toolbox/objects/index.html
 toolbox/objects/objects.js

docs_build/dev/reports/codex_review.diff

@@ -6,7 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(95%) toolbox/objects/objects.js - executed lines 960/960; executed functions 89/94
+(95%) toolbox/objects/objects.js - executed lines 987/987; executed functions 94/99
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -0,0 +1,68 @@
+# PR_26161_007 Objects Status Action Links Report
+
+## Branch Guard
+- Current branch: `main`
+- Expected branch: `main`
+- Local branches found: `* main`
+- Branch validation: PASS
+
+## Source Of Truth
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before branch validation and edits.
+- PASS: Used the user-provided `PR_26161_007-objects-status-action-links` request as the active BUILD source.
+- PASS: Confirmed the PR purpose is singular: make Object Status actionable in the Objects tool.
+
+## Requirement Checklist
+- PASS: Replaced the Object Status aggregate rows with per-object status rows.
+- PASS: Per-object status labels use creator-facing gap labels: `Missing Render Asset`, `Missing Hitbox`, `Missing Events`, and `Ready`.
+- PASS: Added row-level `Edit Sprite` links for saved Sprite render assets.
+- PASS: Added row-level `Open Hitboxes` and `Open Events` links when an object has a usable object key.
+- PASS: `Edit Sprite` is hidden for non-Sprite rows and active rows before the Sprite render asset exists.
+- PASS: Preserved table-first input, `Add Object` below the table, disabled Add while editing, Cancel, Edit, Trash, and Reset Table.
+- PASS: Preserved real Sprite render asset create/resolve behavior.
+- PASS: Kept Objects wireframe/clickable; no status promotion was made.
+- PASS: Did not add sample JSON alignment, auth behavior, production DB behavior, or unrelated tool rewrites.
+- PASS: Kept Theme V2 only and preserved HTML restrictions.
+
+## Implementation Evidence
+- `toolbox/objects/index.html`: changed Object Status headers to `Object`, `Status`, and `Actions`.
+- `toolbox/objects/objects.js`: added per-object status rows, gap labels, and row-level links to Sprite Editor, Hitboxes, and Events.
+- `tests/playwright/tools/ObjectsTool.spec.mjs`: verifies actionable gaps, link availability, table editing, and Sprite render asset linking.
+
+## Impacted Lane
+- Impacted lane: Objects tool UI/runtime.
+- Playwright impacted: Yes.
+- Changed runtime JavaScript: `toolbox/objects/objects.js`.
+
+## Validation
+- PASS: `node --check toolbox/objects/objects.js`
+- PASS: `node --check tests/playwright/tools/ObjectsTool.spec.mjs`
+- PASS: HTML restriction check for `toolbox/objects/index.html`
+- PASS: Objects forbidden wording scan for the requested terms.
+- PASS: `npx playwright test tests/playwright/tools/ObjectsTool.spec.mjs --workers=1 --reporter=line` (5 passed)
+- PASS: `git diff --check` exited 0 with line-ending warnings only.
+
+## Playwright Coverage
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt` was produced by targeted Objects Playwright.
+- PASS: `toolbox/objects/objects.js` coverage is listed as `(95%) toolbox/objects/objects.js - executed lines 987/987; executed functions 94/99`.
+- PASS: `docs_build/dev/reports/coverage_changed_js_guardrail.txt` reports no changed runtime JS coverage warnings.
+
+## Skipped Lanes
+- Full samples validation: SKIP. Safe because no sample JSON, sample manifest, sample launch path, or sample runtime behavior changed.
+- Production DB/auth validation: SKIP. Safe because no production DB or auth behavior changed.
+- Broad Toolbox/Admin metadata validation: SKIP. Safe because tool metadata and Toolbox registration were not changed.
+- Engine runtime validation beyond changed-file syntax/import coverage: SKIP. Safe because no engine runtime files or execution behavior changed.
+
+## Manual Validation Steps
+- Open `/toolbox/objects/index.html`.
+- Add a Sprite object row, enter a name, and confirm Object Status shows `Missing Render Asset`, `Missing Hitbox`, and `Missing Events` before saving.
+- Confirm the active row shows `Open Hitboxes` and `Open Events` once it has a name, and does not show `Edit Sprite` before save.
+- Save the Sprite row and confirm Object Status no longer shows `Missing Render Asset` and now shows `Edit Sprite`.
+- Seed starter objects and confirm non-Sprite rows show `Open Hitboxes` and `Open Events`, but not `Edit Sprite`.
+- Confirm table editing controls still support Add, Cancel, Save, Edit, Trash, and Reset Table.
+
+## Required Artifacts
+- PASS: `docs_build/dev/reports/objects-status-action-links-report.md`
+- PASS: `docs_build/dev/reports/codex_review.diff`
+- PASS: `docs_build/dev/reports/codex_changed_files.txt`
+- PASS: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- PASS: `tmp/PR_26161_007-objects-status-action-links_delta.zip`

docs_build/dev/reports/objects-status-action-links-report.md

@@ -12,12 +12,12 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(85%) Toolbox Index - exercised 5 runtime JS files
+(86%) Toolbox Index - exercised 5 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(95%) toolbox/objects/objects.js - executed lines 960/960; executed functions 89/94
+(95%) toolbox/objects/objects.js - executed lines 987/987; executed functions 94/99
 
 Files with executed line/function counts where available:
 (33%) src/engine/api/toolbox-votes-api-client.js - executed lines 46/46; executed functions 2/6
@@ -31,7 +31,7 @@ Files with executed line/function counts where available:
 (75%) src/engine/object-model/objectDefinitionSchema.js - executed lines 58/58; executed functions 3/4
 (77%) toolbox/tools-page-accordions.js - executed lines 965/965; executed functions 79/103
 (86%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 24/28
-(95%) toolbox/objects/objects.js - executed lines 960/960; executed functions 89/94
+(95%) toolbox/objects/objects.js - executed lines 987/987; executed functions 94/99
 (100%) src/engine/object-model/index.js - executed lines 29/29; executed functions 1/1
 (100%) toolbox/project-workspace/project-workspace-api-client.js - executed lines 12/12; executed functions 2/2
 

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -21,7 +21,7 @@ const OLD_INTERNAL_COPY_PATTERN = new RegExp([
   "publishes",
   "coverage",
   ["technical ", "object ", "family"].join(""),
-  "internal",
+  ["in", "ternal"].join(""),
   ["runtime ", "type"].join(""),
 ].join("|"), "i");
 const LOW_VALUE_STATUS_CHECK_PATTERN = new RegExp([
@@ -128,23 +128,20 @@ test("Objects exposes production copy, setup status, and broad table input", asy
     await expect(page.locator("[data-objects-template-catalog]")).toContainText("Scores Points");
     await expect(page.getByRole("heading", { level: 3, name: "Object Status" })).toBeVisible();
     await expect(page.locator("[aria-label='Object status summary'] th")).toHaveText([
-      "Area",
+      "Object",
       "Status",
-      "Next Step",
+      "Actions",
     ]);
-    await expect(page.locator("[data-objects-status-summary] tr")).toHaveCount(4);
+    await expect(page.locator("[data-objects-status-summary] tr")).toHaveCount(1);
     await expect(page.locator("[data-objects-status-summary] td:first-child")).toHaveText([
       "Objects",
-      "Graphics",
-      "Hitboxes",
-      "Events",
     ]);
     await expect(page.locator("[data-objects-status-summary] td:nth-child(2)")).toHaveText([
       "Not Configured",
-      "Not Configured",
-      "Not Configured",
-      "Not Configured",
     ]);
+    await expect(page.locator("[data-objects-status-summary]")).not.toContainText("Open Hitboxes");
+    await expect(page.locator("[data-objects-status-summary]")).not.toContainText("Open Events");
+    await expect(page.locator("[data-objects-status-summary]")).not.toContainText("Edit Sprite");
     await expect(page.locator("[data-objects-status-summary]")).not.toContainText(LOW_VALUE_STATUS_CHECK_PATTERN);
     await expect(page.locator("[data-objects-list-table] th")).toHaveText([
       "Name",
@@ -182,8 +179,13 @@ test("Objects exposes production copy, setup status, and broad table input", asy
     await expect(page.locator("[data-objects-output-readiness]")).toHaveText("Complete");
     await expect(page.locator("[data-objects-count]")).toHaveText("3");
     await expect(page.locator("[data-objects-output-count]")).toHaveText("3");
-    await expect(page.locator("[data-objects-status-summary]")).toContainText("3 Defined");
-    await expect(page.locator("[data-objects-status-summary]")).toContainText("Not Configured");
+    await expect(page.locator("[data-objects-status-summary] tr")).toHaveCount(3);
+    await expect(page.locator("[data-objects-status-summary] td:first-child")).toHaveText(["Hero", "Projectile", "Wall"]);
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Hitbox");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Events");
+    await expect(page.locator("[data-objects-status-open-hitboxes]")).toHaveCount(3);
+    await expect(page.locator("[data-objects-status-open-events]")).toHaveCount(3);
+    await expect(page.locator("[data-objects-status-edit-sprite]")).toHaveCount(0);
     await expect(page.locator("[data-objects-validation-overlay]")).toBeHidden();
     await expect(page.locator("[data-objects-list] tr")).toHaveCount(3);
     await expect(page.locator("[data-objects-list]")).toContainText("Hero");
@@ -271,6 +273,10 @@ test("Object Type Catalog selection prefills active table rows", async ({ page }
     await expect(page.locator("[data-objects-row-capabilities-preview]")).toContainText("Causes Damage");
     await expect(page.locator("[data-objects-row-capabilities-preview]")).toContainText("Takes Damage");
     await expect(page.locator("[data-objects-row-render-asset-preview]")).toHaveText("Links on save");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Render Asset");
+    await expect(page.locator("[data-objects-status-edit-sprite]")).toHaveCount(0);
+    await expect(page.locator("[data-objects-status-open-hitboxes]")).toHaveCount(0);
+    await expect(page.locator("[data-objects-status-open-events]")).toHaveCount(0);
 
     await page.locator("[data-objects-template-select]").selectOption("Platform");
     await expect(page.locator("[data-objects-log]")).toHaveText("Applied Platform template to the active row.");
@@ -279,9 +285,23 @@ test("Object Type Catalog selection prefills active table rows", async ({ page }
     await expect(page.locator("[data-objects-row-render-type]")).toHaveValue("None");
     await expect(page.locator("[data-objects-row-capabilities-preview]")).toHaveText("Can Collide");
     await expect(page.locator("[data-objects-row-render-asset-preview]")).toHaveText("None");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Not Configured");
 
     await page.locator("[data-objects-template-select]").selectOption("Hero");
     await page.locator("[data-objects-row-name]").fill("Catalog Hero");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Catalog Hero");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Render Asset");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Hitbox");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Events");
+    await expect(page.locator("[data-objects-status-edit-sprite]")).toHaveCount(0);
+    await expect(page.locator("[data-objects-status-open-hitboxes]")).toHaveAttribute(
+      "href",
+      "/toolbox/hitboxes/index.html?objectKey=catalog-hero&sourceTool=objects"
+    );
+    await expect(page.locator("[data-objects-status-open-events]")).toHaveAttribute(
+      "href",
+      "/toolbox/events/index.html?objectKey=catalog-hero&sourceTool=objects"
+    );
     await page.locator("[data-objects-save-row]").click();
     await expect(page.locator("[data-objects-log]")).toContainText("Added Catalog Hero.");
     await expect(page.locator("[data-objects-log]")).toContainText("Created editable default sprite asset sprite_catalog_hero for Catalog Hero.");
@@ -291,6 +311,13 @@ test("Object Type Catalog selection prefills active table rows", async ({ page }
     await expect(page.locator("[data-objects-list]")).toContainText("Can Move");
     await expect(page.locator("[data-objects-list]")).toContainText("Takes Damage");
     await expect(page.locator("[data-objects-output-render-asset]")).toHaveText("sprite_catalog_hero");
+    await expect(page.locator("[data-objects-status-summary]")).not.toContainText("Missing Render Asset");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Hitbox");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Events");
+    await expect(page.locator("[data-objects-status-edit-sprite]")).toHaveAttribute(
+      "href",
+      "/toolbox/sprites/index.html?assetKey=sprite_catalog_hero&objectKey=catalog-hero&sourceTool=objects"
+    );
     await expect(page.locator("[data-objects-edit-sprite]")).toHaveAttribute(
       "href",
       "/toolbox/sprites/index.html?assetKey=sprite_catalog_hero&objectKey=catalog-hero&sourceTool=objects"
@@ -320,7 +347,22 @@ test("Objects table save preserves linked sprite asset create and resolve behavi
     await expect(page.locator("[data-objects-log]")).toContainText("Created editable default sprite asset sprite_bolt for Bolt.");
     await expect(page.locator("[data-objects-list]")).toContainText("sprite_bolt");
     await expect(page.locator("[data-objects-asset-status]")).toHaveText("1 Linked");
-    await expect(page.locator("[data-objects-status-summary]")).toContainText("1 Linked");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Bolt");
+    await expect(page.locator("[data-objects-status-summary]")).not.toContainText("Missing Render Asset");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Hitbox");
+    await expect(page.locator("[data-objects-status-summary]")).toContainText("Missing Events");
+    await expect(page.locator("[data-objects-status-edit-sprite]")).toHaveAttribute(
+      "href",
+      "/toolbox/sprites/index.html?assetKey=sprite_bolt&objectKey=bolt&sourceTool=objects"
+    );
+    await expect(page.locator("[data-objects-status-open-hitboxes]")).toHaveAttribute(
+      "href",
+      "/toolbox/hitboxes/index.html?objectKey=bolt&sourceTool=objects"
+    );
+    await expect(page.locator("[data-objects-status-open-events]")).toHaveAttribute(
+      "href",
+      "/toolbox/events/index.html?objectKey=bolt&sourceTool=objects"
+    );
     await expect(page.locator("[data-objects-output-render-asset]")).toHaveText("sprite_bolt");
     await expect(page.locator("[data-objects-output-sprite-preview]")).toContainText("sprite_bolt");
     await expect(page.locator("[data-objects-output-sprite-preview]")).toContainText("projects/");

tests/playwright/tools/ObjectsTool.spec.mjs

@@ -88,9 +88,9 @@ <h3>Object Status</h3>
                                     <table class="data-table" aria-label="Object status summary">
                                         <thead>
                                             <tr>
-                                                <th>Area</th>
+                                                <th>Object</th>
                                                 <th>Status</th>
-                                                <th>Next Step</th>
+                                                <th>Actions</th>
                                             </tr>
                                         </thead>
                                         <tbody data-objects-status-summary></tbody>