Skip to content

Commit 25918db

Browse files
author
Delta Team
committed
Merge PR_26177_DELTA_002-hitboxes-foundation
# Conflicts: # docs_build/dev/reports/codex_changed_files.txt # docs_build/dev/reports/codex_review.diff
2 parents c8c2cc2 + 3667bd6 commit 25918db

11 files changed

Lines changed: 542 additions & 5804 deletions
Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
const FOUNDATION_MILESTONES = Object.freeze([
2+
Object.freeze({
3+
milestone: "Tool shell",
4+
notes: "Theme V2 page shell is available from the toolbox.",
5+
status: "Ready",
6+
}),
7+
Object.freeze({
8+
milestone: "Local API contract",
9+
notes: "Placeholder service boundary is reserved for later persistence work.",
10+
status: "Placeholder",
11+
}),
12+
Object.freeze({
13+
milestone: "Editor",
14+
notes: "Drawing and editing start in a later focused PR.",
15+
status: "Deferred",
16+
}),
17+
]);
18+
19+
const elements = {
20+
contractCount: document.querySelector("[data-hitboxes-contract-count]"),
21+
foundationStatus: document.querySelector("[data-hitboxes-foundation-status]"),
22+
log: document.querySelector("[data-hitboxes-log]"),
23+
mode: document.querySelector("[data-hitboxes-mode]"),
24+
owner: document.querySelector("[data-hitboxes-owner]"),
25+
persistence: document.querySelector("[data-hitboxes-persistence]"),
26+
scopeCount: document.querySelector("[data-hitboxes-scope-count]"),
27+
service: document.querySelector("[data-hitboxes-service]"),
28+
table: document.querySelector("[data-hitboxes-foundation-table]"),
29+
toolState: document.querySelector("[data-hitboxes-tool-state]"),
30+
};
31+
32+
function setText(element, value) {
33+
if (element) {
34+
element.textContent = value;
35+
}
36+
}
37+
38+
function createCell(text) {
39+
const cell = document.createElement("td");
40+
cell.textContent = text;
41+
return cell;
42+
}
43+
44+
function createRow(milestone) {
45+
const row = document.createElement("tr");
46+
const heading = document.createElement("th");
47+
heading.scope = "row";
48+
heading.textContent = milestone.milestone;
49+
row.append(heading, createCell(milestone.status), createCell(milestone.notes));
50+
return row;
51+
}
52+
53+
function renderFoundation() {
54+
elements.table?.replaceChildren(...FOUNDATION_MILESTONES.map(createRow));
55+
setText(elements.contractCount, String(FOUNDATION_MILESTONES.length));
56+
setText(elements.scopeCount, "0");
57+
setText(elements.foundationStatus, "Foundation ready");
58+
setText(elements.owner, "Team Delta");
59+
setText(elements.persistence, "Local API contract pending");
60+
setText(elements.service, "hitboxes-service-placeholder");
61+
setText(elements.mode, "read-only foundation");
62+
setText(elements.toolState, "Foundation");
63+
setText(elements.log, "Hitboxes foundation loaded. Drawing and editing are intentionally deferred.");
64+
}
65+
66+
renderFoundation();

docs_build/dev/admin-notes/tools/index.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Order,Tool,Group,Status,Complete
2020
19,Build Game,Build/Create,Wireframe,No
2121
20,Game Testing,Play,Wireframe,No
2222
21,Controls,Platform,Wireframe,No
23-
22,Hitboxes,Platform,Wireframe,No
23+
22,Hitboxes,Platform,Under Construction,No
2424
23,Saved Data,Platform,Wireframe,No
2525
24,Debug,Platform,Wireframe,No
2626
25,Performance,Platform,Wireframe,No
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
# PR_26177_DELTA_002-hitboxes-foundation
2+
3+
Team: Delta
4+
Branch: PR_26177_DELTA_002-hitboxes-foundation
5+
Base: main
6+
Scope: Hitboxes MVP foundation only
7+
8+
## Summary
9+
10+
Hitboxes now has a Team Delta-owned MVP foundation surface. The tool is launchable from Toolbox metadata, uses the existing Theme V2 page structure, and loads a dedicated external JavaScript module for foundation-only status rendering.
11+
12+
## Changes
13+
14+
- Updated Hitboxes metadata from planned/wireframe launch behavior to `Under Construction` with beta release-channel routing.
15+
- Replaced the static Hitboxes wireframe copy with a Theme V2 foundation shell.
16+
- Added `assets/toolbox/hitboxes/js/index.js` for external-only page behavior.
17+
- Updated admin notes tool status for Hitboxes to `Under Construction`.
18+
19+
## Deferred
20+
21+
- Drawing and editing are not implemented in this PR.
22+
- Object binding is not implemented in this PR.
23+
- Hitbox type validation is not implemented in this PR.
24+
- Preview rendering is not implemented in this PR.
25+
26+
## Scope Guard
27+
28+
- No unrelated tools changed.
29+
- No `start_of_day` files changed.
30+
- No engine core changes.
31+
- No inline scripts, styles, or event handlers were added.
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# PR_26177_DELTA_002 Hitboxes Foundation Branch Validation
2+
3+
Branch: PR_26177_DELTA_002-hitboxes-foundation
4+
Base: main
5+
6+
Result: PASS
7+
8+
| Check | Status | Notes |
9+
|---|---|---|
10+
| Ownership baseline completed first | PASS | `main` includes `PR_26177_DELTA_001-hitboxes-team-ownership`. |
11+
| Main branch clean before PR branch | PASS | `git status` reported a clean main after ownership merge. |
12+
| Main synced before PR branch | PASS | `git rev-list --left-right --count main...origin/main` returned `0 0`. |
13+
| PR branch created from main | PASS | Work is on `PR_26177_DELTA_002-hitboxes-foundation`. |
14+
| Scope is Hitboxes foundation only | PASS | Changed Hitboxes page, Hitboxes JS, toolbox metadata, admin status, and reports only. |
15+
| start_of_day untouched | PASS | No `start_of_day` files changed. |
16+
| No implementation drawing/editing | PASS | Foundation status rendering only; no drawing, editing, binding, validation, or preview implementation. |
Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
# PR_26177_DELTA_002 Hitboxes Foundation Manual Validation Notes
2+
3+
- Confirmed ownership baseline on `main` before creating the foundation branch.
4+
- Confirmed Hitboxes is Team Delta-owned in Project Instructions.
5+
- Reviewed `toolbox/hitboxes/index.html` for Theme V2 shell structure.
6+
- Confirmed the page links only external scripts.
7+
- Confirmed the foundation UI does not expose drawing, editing, object binding, type validation, or preview controls.
8+
- Confirmed the toolbox metadata route remains `toolbox/hitboxes/index.html`.
9+
- Broader registry baseline test failure is pre-existing and unrelated to this PR: missing `physics-sandbox`.
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26177_DELTA_002 Hitboxes Foundation Requirement Checklist
2+
3+
| Requirement | Status | Notes |
4+
|---|---|---|
5+
| Use ownership PR as baseline | PASS | Ownership PR merged to `main` before branch creation. |
6+
| Move Hitboxes out of Planned | PASS | Hitboxes metadata now uses `status: "Under Construction"` and `releaseChannel: "beta"`. |
7+
| Team Delta MVP/tool ownership status | PASS | Existing Project Instructions ownership places Hitboxes under Team Delta; this PR keeps that baseline. |
8+
| Foundation only | PASS | Page shell and external JS foundation status only. |
9+
| Toolbox navigation/metadata clickable | PASS | Hitboxes route remains `toolbox/hitboxes/index.html` and beta-channel launch is not planned-blocked. |
10+
| Theme V2 page shell only | PASS | Hitboxes page uses existing Theme V2 CSS and tool workspace classes. |
11+
| External JS only | PASS | Added `assets/toolbox/hitboxes/js/index.js`; no inline script behavior added. |
12+
| No inline scripts/styles/handlers | PASS | Focused grep checks found no inline style or handler attributes; script tags all use `src`. |
13+
| Local API/service placeholders only | PASS | Foundation UI exposes placeholder service/contract status without persistence implementation. |
14+
| Do not implement drawing/editing | PASS | Editable region count remains `0`; milestones defer editor work. |
15+
| Do not modify unrelated tools | PASS | No unrelated tool page or tool JS changed. |
16+
| Do not modify start_of_day folders | PASS | No `start_of_day` files changed. |
17+
| Required reports | PASS | PR report, branch validation, requirement checklist, validation lane, manual notes, Codex diff, and changed-file manifest produced. |
18+
| Repo-structured ZIP | PASS | `tmp/PR_26177_DELTA_002-hitboxes-foundation_delta.zip` produced. |
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# PR_26177_DELTA_002 Hitboxes Foundation Validation Lane
2+
3+
## Commands
4+
5+
| Command | Status | Notes |
6+
|---|---|---|
7+
| `git branch --show-current` | PASS | Confirmed PR branch. |
8+
| `node --check assets/toolbox/hitboxes/js/index.js` | PASS | External JS parses successfully. |
9+
| Hitboxes metadata import check | PASS | `getToolById("hitboxes")` exists, status is `Under Construction`, release channel is `beta`, route is `toolbox/hitboxes/index.html`, and tool is visible. |
10+
| `rg -n "style=" toolbox/hitboxes/index.html assets/toolbox/hitboxes/js/index.js` | PASS | No inline styles found. |
11+
| `rg -n " onclick=| onchange=| oninput=| onsubmit=| onload=" toolbox/hitboxes/index.html assets/toolbox/hitboxes/js/index.js` | PASS | No inline event handlers found. |
12+
| `rg -n "<script" toolbox/hitboxes/index.html` | PASS | All script tags use external `src` files. |
13+
| `rg -n "Alfa - Hitboxes" docs_build/dev/ProjectInstructions` | PASS | No Alfa-owned Hitboxes backlog entry found. |
14+
| `node ./scripts/run-node-test-files.mjs tests/tools/RequiredToolsBaseline.test.mjs tests/shared/tools/ToolContractCoverage.test.mjs tests/shared/ProjectWorkspaceToolRegistrationValidation.test.mjs` | FAIL | Existing unrelated failure: `Tool registry entry missing: physics-sandbox`. No Hitboxes failure was reported before the lane stopped. |
15+
16+
## Result
17+
18+
PASS for focused Hitboxes foundation validation. One broader existing baseline lane remains failing outside this PR scope.
Lines changed: 11 additions & 87 deletions
Original file line numberDiff line numberDiff line change
@@ -1,87 +1,11 @@
1-
R100 docs_build/dev/dod/tool_ui_readiness_dod.md archive/docs_build/dev/dod/tool_ui_readiness_dod.md
2-
R100 docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE.md
3-
R100 docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_APPEND.md archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_APPEND.md
4-
R100 docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE.md archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE.md
5-
R100 docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE_8_19.md archive/docs_build/dev/roadmaps/MASTER_ROADMAP_ENGINE_LEVEL_8_UPDATE_8_19.md
6-
R100 docs_build/dev/roadmaps/MASTER_ROADMAP_RECOVERY.md archive/docs_build/dev/roadmaps/MASTER_ROADMAP_RECOVERY.md
7-
R100 docs_build/dev/roadmaps/MASTER_ROADMAP_SAMPLES2TOOLS.md archive/docs_build/dev/roadmaps/MASTER_ROADMAP_SAMPLES2TOOLS.md
8-
R100 docs_build/dev/roadmaps/MASTER_ROADMAP_TOOLS.md archive/docs_build/dev/roadmaps/MASTER_ROADMAP_TOOLS.md
9-
R100 docs_build/dev/roadmaps/MIDI_STUDIO_V2_ROADMAP.md archive/docs_build/dev/roadmaps/MIDI_STUDIO_V2_ROADMAP.md
10-
R100 docs_build/dev/roadmaps/README.md archive/docs_build/dev/roadmaps/README.md
11-
R100 docs_build/dev/roadmaps/phases.txt archive/docs_build/dev/roadmaps/phases.txt
12-
D docs_build/dev/BUILD_PR.md
13-
D docs_build/dev/BUILD_PR_LEVEL_10_6B_STANDALONE_SAMPLE_GENERIC_FAILURE_CLOSEOUT.md
14-
D docs_build/dev/NEXT_RESTART.md
15-
D docs_build/dev/PLAN_PR.md
16-
D docs_build/dev/PLAN_PR_LEVEL_10_6B_STANDALONE_SAMPLE_GENERIC_FAILURE_CLOSEOUT.md
17-
D docs_build/dev/PROJECT_INSTRUCTIONS.md
18-
D docs_build/dev/PROJECT_MULTI_PC.txt
19-
M docs_build/dev/ProjectInstructions/PROJECT_INSTRUCTIONS.md
20-
M docs_build/dev/ProjectInstructions/README.txt
21-
M docs_build/dev/ProjectInstructions/TEAM_START_COMMANDS.md
22-
A docs_build/dev/ProjectInstructions/addendums/assistant_execution_modes.md
23-
M docs_build/dev/ProjectInstructions/addendums/branch_context_governance.md
24-
M docs_build/dev/ProjectInstructions/addendums/branch_lock_governance.md
25-
A docs_build/dev/ProjectInstructions/addendums/canonical_repository_structure.md
26-
A docs_build/dev/ProjectInstructions/addendums/codex_artifact_and_reporting_standard.md
27-
A docs_build/dev/ProjectInstructions/addendums/codex_project_instructions_startup.md
28-
R100 docs_build/dev/koti_layout_contract.md docs_build/dev/ProjectInstructions/addendums/koti_layout_contract.md
29-
A docs_build/dev/ProjectInstructions/addendums/legacy_migration_policy.md
30-
M docs_build/dev/ProjectInstructions/addendums/multi_team.md
31-
A docs_build/dev/ProjectInstructions/addendums/no_mock_repository_runtime_source.md
32-
M docs_build/dev/ProjectInstructions/addendums/pr_workflow.md
33-
M docs_build/dev/ProjectInstructions/addendums/preservation.md
34-
A docs_build/dev/ProjectInstructions/addendums/project_instructions_single_source_eod_lock.md
35-
M docs_build/dev/ProjectInstructions/addendums/release_gate.md
36-
R100 docs_build/dev/samples2tools_adapter_guidance.md docs_build/dev/ProjectInstructions/addendums/samples2tools_adapter_guidance.md
37-
M docs_build/dev/ProjectInstructions/addendums/team_release_readiness.md
38-
M docs_build/dev/ProjectInstructions/addendums/team_start_and_release.md
39-
A docs_build/dev/ProjectInstructions/addendums/test_structure_standardization.md
40-
A docs_build/dev/ProjectInstructions/addendums/tool_mvp_stacked_pr_standard.md
41-
R100 docs_build/dev/workspace_v2_playwright_gate.md docs_build/dev/ProjectInstructions/addendums/workspace_v2_playwright_gate.md
42-
M docs_build/dev/ProjectInstructions/team_assignments/TEAM_ASSIGNMENTS.md
43-
D docs_build/dev/bundle_readme.md
44-
D docs_build/dev/codex_commands.md
45-
D docs_build/dev/codex_rules.md
46-
D docs_build/dev/commit_comment.txt
47-
A docs_build/dev/pr/BUILD_PR.md
48-
A docs_build/dev/pr/PLAN_PR.md
49-
R100 docs_build/dev/plan_pr_tool_workspace_manifest_boundaries.md docs_build/dev/pr/plan_pr_tool_workspace_manifest_boundaries.md
50-
R096 docs_build/dev/pr_koti_layout_contract.md docs_build/dev/pr/pr_koti_layout_contract.md
51-
R100 docs_build/dev/pr_tool_fix_asset_browser_1505.md docs_build/dev/pr/pr_tool_fix_asset_browser_1505.md
52-
R100 docs_build/dev/pr_tool_fix_fullscreen_exit_state.md docs_build/dev/pr/pr_tool_fix_fullscreen_exit_state.md
53-
R100 docs_build/dev/pr_tool_fix_parallax_header_metadata.md docs_build/dev/pr/pr_tool_fix_parallax_header_metadata.md
54-
R100 docs_build/dev/pr_tool_header_singleline.md docs_build/dev/pr/pr_tool_header_singleline.md
55-
R100 docs_build/dev/pr_tool_interactive_uat.md docs_build/dev/pr/pr_tool_interactive_uat.md
56-
R100 docs_build/dev/pr_tool_layout_workflow_baseline.md docs_build/dev/pr/pr_tool_layout_workflow_baseline.md
57-
R100 docs_build/dev/pr_tool_remove_future_import_hints.md docs_build/dev/pr/pr_tool_remove_future_import_hints.md
58-
R100 docs_build/dev/pr_tool_remove_static_header_intro.md docs_build/dev/pr/pr_tool_remove_static_header_intro.md
59-
R100 docs_build/dev/pr_tool_stabilization.md docs_build/dev/pr/pr_tool_stabilization.md
60-
R100 docs_build/dev/pr_tool_uat_closeout.md docs_build/dev/pr/pr_tool_uat_closeout.md
61-
R100 docs_build/dev/pr_tool_uat_fix_fullscreen_header_wiring.md docs_build/dev/pr/pr_tool_uat_fix_fullscreen_header_wiring.md
62-
R100 docs_build/dev/pr_tool_uat_fix_header_asset_browser.md docs_build/dev/pr/pr_tool_uat_fix_header_asset_browser.md
63-
R100 docs_build/dev/pr_tool_uat_fixes.md docs_build/dev/pr/pr_tool_uat_fixes.md
64-
A docs_build/dev/reports/PR_26177_OWNER_007-project-instructions-single-source-eod-lock.md
65-
A docs_build/dev/reports/PR_26177_OWNER_007-project-instructions-single-source-eod-lock_branch-validation.md
66-
A docs_build/dev/reports/PR_26177_OWNER_007-project-instructions-single-source-eod-lock_manual-validation-notes.md
67-
A docs_build/dev/reports/PR_26177_OWNER_007-project-instructions-single-source-eod-lock_requirement-checklist.md
68-
A docs_build/dev/reports/PR_26177_OWNER_007-project-instructions-single-source-eod-lock_validation-lane.md
69-
R100 docs_build/dev/component-audit.md docs_build/dev/reports/audits/component-audit.md
70-
R100 docs_build/dev/css-audit.md docs_build/dev/reports/audits/css-audit.md
71-
R100 docs_build/dev/security-audit.md docs_build/dev/reports/audits/security-audit.md
72-
M docs_build/dev/reports/codex_changed_files.txt
73-
M docs_build/dev/reports/codex_review.diff
74-
A docs_build/dev/reports/legacy-docs-archive-report.md
75-
D docs_build/dev/restart_notes_11_105.md
76-
D docs_build/dev/restart_notes_11_110.md
77-
D docs_build/dev/restart_notes_11_111.md
78-
D docs_build/dev/restart_notes_11_112.md
79-
D docs_build/dev/restart_notes_11_116.md
80-
D docs_build/dev/restart_notes_11_118.md
81-
D docs_build/dev/restart_notes_11_119.md
82-
D docs_build/dev/restart_notes_11_120.md
83-
D docs_build/dev/restart_notes_11_121.md
84-
D docs_build/dev/restart_notes_11_122.md
85-
D docs_build/dev/restart_notes_11_123.md
86-
D docs_build/dev/validation_checklist.txt
87-
A project-instructions/README.md
1+
assets/toolbox/hitboxes/js/index.js
2+
docs_build/dev/admin-notes/tools/index.txt
3+
docs_build/dev/reports/PR_26177_DELTA_002-hitboxes-foundation.md
4+
docs_build/dev/reports/PR_26177_DELTA_002-hitboxes-foundation_branch-validation.md
5+
docs_build/dev/reports/PR_26177_DELTA_002-hitboxes-foundation_manual-validation-notes.md
6+
docs_build/dev/reports/PR_26177_DELTA_002-hitboxes-foundation_requirement-checklist.md
7+
docs_build/dev/reports/PR_26177_DELTA_002-hitboxes-foundation_validation-lane.md
8+
src/shared/toolbox/tool-metadata-inventory.js
9+
toolbox/hitboxes/index.html
10+
docs_build/dev/reports/codex_changed_files.txt
11+
docs_build/dev/reports/codex_review.diff

0 commit comments

Comments
 (0)