Compact Controls controller profiles and limit profile device type to gamepads - PR_26161_028-controls-compact-controller-profile

Author: ToolboxAid

docs_build/dev/reports/codex_changed_files.txt

@@ -1,10 +1,8 @@
-docs_build/dev/reports/controls-controller-profile-generation-report.md
+docs_build/dev/reports/controls-compact-controller-profile-report.md
 docs_build/dev/reports/codex_review.diff
 docs_build/dev/reports/codex_changed_files.txt
 docs_build/dev/reports/playwright_v8_coverage_report.txt
 docs_build/dev/reports/coverage_changed_js_guardrail.txt
-src/dev-runtime/persistence/mock-db-store.js
-src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js
 tests/playwright/tools/InputMappingV2Tool.spec.mjs
 toolbox/controls/controls.js
 toolbox/controls/index.html

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,58 @@
+# PR_26161_028 Controls Compact Controller Profile
+
+## Branch Validation
+PASS: current branch was verified as `main` before edits.
+
+## Impacted Lane
+Controls / Input Mapping targeted lane.
+
+## Playwright Impacted
+Yes.
+
+## Request Checklist
+- PASS: Controls status remains Wireframe.
+- PASS: Controls mappings, controller profiles, and custom actions remain DB-backed through the shared DB/mock adapter.
+- PASS: Controller Profile Device Type dropdown now shows detected game controllers only.
+- PASS: Keyboard and Mouse no longer appear in the Controller Profile Device Type dropdown.
+- PASS: Keyboard and Mouse remain valid in Input Mapping row Input Device selection.
+- PASS: Controller Profile vertical space was reduced by removing the standalone Input column.
+- PASS: Generated controller inputs are displayed as compact Button/Input plus Action dropdown pairs.
+- PASS: Generated Actions are placed under the controller row in a full-width grid that stacks left to right and top to bottom.
+- PASS: Actions are displayed under the Controller Profile details row instead of a separate Input column.
+- PASS: Add Profile still creates DB-backed controller profile records.
+- PASS: Generated gamepad buttons, axes, triggers, and d-pad inputs are preserved.
+- PASS: Custom Action creation still persists and appears in Action dropdowns after reload.
+- PASS: Reset Mappings confirmation remains unchanged.
+- PASS: Input Mapping and Controller Profile remain accordions.
+- PASS: Mapping/profile persistence after reload remains covered.
+- PASS: No sample JSON alignment, auth behavior, production game runtime behavior, or unrelated rewrites were added.
+- PASS: Theme V2-only restrictions were preserved; no inline CSS, inline JS, script blocks, style blocks, or inline event handlers were added.
+
+## Testing Performed
+- `node --check toolbox/controls/controls.js`
+- `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+  - Result: 7 passed.
+- `git diff --check -- . ':!docs_build/dev/reports/codex_review.diff'`
+  - Result: PASS, with Git line-ending warnings only.
+
+## Playwright Coverage
+- Produced `docs_build/dev/reports/playwright_v8_coverage_report.txt`.
+- Changed browser runtime JS covered: `toolbox/controls/controls.js` at 91% function coverage.
+- The V8 report lists prior server-side DB/mock adapter files as advisory WARN entries from the repository diff baseline; this PR did not change those files, and the targeted Controls browser runtime behavior is covered.
+
+## Manual Validation Steps
+1. Open `toolbox/controls/index.html`.
+2. Verify Controller Profile Device Type only lists detected game controllers and does not list Keyboard or Mouse.
+3. Add a mapping row and verify Input Device still offers Keyboard, Mouse, and Gamepad.
+4. Mock or connect a gamepad, click Refresh Devices, select the detected gamepad, and click Add Profile.
+5. Verify the saved profile shows generated inputs as compact input/action pairs under the controller row and no separate Input column.
+6. Assign Actions, save profile actions, reload, and verify profile/mapping data persists.
+7. Add a custom Action, reload, and verify it appears in Action dropdowns.
+
+## Skipped Lanes
+- Full samples validation was skipped as requested. This PR is scoped to Controls UI/tool behavior and does not change samples or production game runtime behavior.
+- Broad workspace/full-suite validation was skipped because targeted Controls/Input Mapping Playwright covers the changed tool behavior directly.
+
+## Runtime Engine Behavior
+Confirmed: no production game runtime behavior was changed.

docs_build/dev/reports/controls-compact-controller-profile-report.md

@@ -8,7 +8,7 @@ Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 Changed runtime JS files considered:
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(92%) toolbox/controls/controls.js - executed lines 1622/1622; executed functions 165/180
+(91%) toolbox/controls/controls.js - executed lines 1626/1626; executed functions 165/181
 
 Guardrail warnings:
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file missing from coverage; advisory only

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,21 +12,21 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(90%) Toolbox Index - exercised 4 runtime JS files
+(89%) Toolbox Index - exercised 4 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (59%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
 (0%) src/dev-runtime/persistence/mock-db-store.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - WARNING: changed runtime JS file was not collected by Playwright V8 coverage; advisory only
-(92%) toolbox/controls/controls.js - executed lines 1622/1622; executed functions 165/180
+(91%) toolbox/controls/controls.js - executed lines 1626/1626; executed functions 165/181
 
 Files with executed line/function counts where available:
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (58%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 603/603; executed functions 30/52
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
-(92%) toolbox/controls/controls.js - executed lines 1622/1622; executed functions 165/180
+(91%) toolbox/controls/controls.js - executed lines 1626/1626; executed functions 165/181
 (100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
 (100%) toolbox/objects/objects-api-client.js - executed lines 10/10; executed functions 2/2
 
@@ -38,4 +38,4 @@ Changed JS files considered:
 (0%) src/dev-runtime/persistence/mock-db-store.js - changed JS file not collected as browser runtime coverage
 (0%) src/dev-runtime/persistence/tool-repositories/input-mapping-mock-repository.js - changed JS file not collected as browser runtime coverage
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(92%) toolbox/controls/controls.js - changed JS file with browser V8 coverage
+(91%) toolbox/controls/controls.js - changed JS file with browser V8 coverage

docs_build/dev/reports/playwright_v8_coverage_report.txt

@@ -268,7 +268,6 @@ test("Controls Input Mapping launch panels, defaults, diagnostics, and workspace
       "Controller Name",
       "Controller ID",
       "Mapping Profile",
-      "Input",
       "Action",
     ]);
     await expect(page.locator("[data-controller-profile-list]")).toContainText("No controller profiles saved yet.");
@@ -280,11 +279,10 @@ test("Controls Input Mapping launch panels, defaults, diagnostics, and workspace
     await expect(page.locator("[data-controller-profile-planning]")).toContainText("Future game launch will match Controller ID to a saved Mapping Profile");
     await expect(page.locator("[data-controller-profile-add]")).toBeVisible();
     await expect(page.locator("[data-controller-device-select] option")).toHaveText([
-      "Choose a controller",
-      "Keyboard",
-      "Mouse",
-      "Unknown or unavailable controller",
+      "Choose a game controller",
     ]);
+    await expect(page.locator("[data-controller-device-select]")).not.toContainText("Keyboard");
+    await expect(page.locator("[data-controller-device-select]")).not.toContainText("Mouse");
     expect(await controllerProfileRecords(page)).toHaveLength(0);
     await expect(page.locator("[data-input-mapping-table] th")).toHaveText([
       "Object",
@@ -365,6 +363,7 @@ test("Controls Input Mapping supports table-first inline add, cancel, save, and
     await expect(page.locator("[data-input-row-capture-keyboard]")).toBeVisible();
     await expect(page.locator("[data-input-row-capture-mouse]")).toHaveCount(0);
     await expect(page.locator("[data-input-row-capture-gamepad]")).toHaveCount(0);
+    await expect(page.locator("[data-input-row-device] option")).toHaveText(["Keyboard", "Mouse", "Gamepad"]);
     await page.locator("[data-input-row-device]").selectOption("mouse");
     await expect(page.locator("[data-input-row-capture-keyboard]")).toHaveCount(0);
     await expect(page.locator("[data-input-row-capture-mouse]")).toBeVisible();
@@ -613,12 +612,11 @@ test("Controls generates controller profiles, shows fallback status, and mapping
     });
     await page.locator("[data-input-refresh-devices]").click();
     await expect(page.locator("[data-controller-device-select] option")).toHaveText([
-      "Choose a controller",
-      "Keyboard",
-      "Mouse",
+      "Choose a game controller",
       "Gamepad: Arcade Test Pad",
-      "Unknown or unavailable controller",
     ]);
+    await expect(page.locator("[data-controller-device-select]")).not.toContainText("Keyboard");
+    await expect(page.locator("[data-controller-device-select]")).not.toContainText("Mouse");
 
     await page.locator("[data-controller-device-select]").selectOption("gamepad-0");
     await expect(page.locator("[data-controller-profile-editing-row]")).toHaveCount(0);
@@ -631,6 +629,18 @@ test("Controls generates controller profiles, shows fallback status, and mapping
     await expect(page.locator("[data-controller-profile-list]")).toContainText("Arcade Test Pad");
     await expect(page.locator("[data-controller-profile-list]")).toContainText("Arcade Test Pad Profile");
     await expect(page.locator("[data-controller-profile-list]")).toContainText("Action Required");
+    await expect(page.locator("[data-controller-profile-table] th")).toHaveText([
+      "Device Type",
+      "Controller Name",
+      "Controller ID",
+      "Mapping Profile",
+      "Action",
+    ]);
+    await expect(page.locator("[data-controller-profile-row]").first()).not.toContainText("Button0");
+    await expect(page.locator("[data-controller-profile-actions-row]").first().locator(".content-grid--three")).toBeVisible();
+    await expect(page.locator("[data-controller-profile-actions-row]").first().locator("[data-controller-profile-input-pair]")).toHaveCount(18);
+    await expect(page.locator("[data-controller-profile-actions-row]").first().locator("[data-controller-profile-input-pair]").first().locator("strong")).toHaveText("Button0");
+    await expect(page.locator("[data-controller-profile-actions-row]").first().locator("[data-controller-profile-input-pair]").first().locator("select")).toBeVisible();
     await expect(page.locator("[data-controller-profile-fallback-status]")).toContainText("Exact saved profile");
 
     let profiles = await controllerProfileRecords(page);
@@ -689,10 +699,6 @@ test("Controls generates controller profiles, shows fallback status, and mapping
     expect(profiles).toHaveLength(1);
     expect(profiles[0].mappingProfile).toBe("Arcade Test Pad Profile");
 
-    await page.locator("[data-controller-device-select]").selectOption("unavailable-controller");
-    await expect(page.locator("[data-controller-profile-status]")).toContainText("WARN: Unknown or unavailable controller.");
-    await expect(page.locator("[data-controller-profile-status]")).toContainText("refresh devices");
-    await expect(page.locator("[data-controller-profile-fallback-status]")).toContainText("Missing Mapping");
     expect(profiles).toHaveLength(1);
 
     await page.reload({ waitUntil: "networkidle" });