Remove final theme engine remnants and validate active versus deprecated structure ownership - PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup

Author: ToolboxAid

assets/theme/v1/README.md

@@ -2,7 +2,7 @@
 
 Task:
 
-- `PR_26154_015-theme-v1-removal-fontawesome-v2`
+- `PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup`
 
 Commands run:
 
@@ -11,48 +11,55 @@ Commands run:
 - `git status --short --untracked-files=all`
 - Targeted `Get-ChildItem` and `Get-Content` inspection for:
   - `assets/theme/v1/`
-  - `assets/theme/v2/fonts/`
+  - `assets/theme/v2/images/`
+  - `assets/theme/v2/css/theme/v2/`
   - `src/engine/theme/`
   - `src/engine/ui/toolboxaid-header.html`
-  - `src/engine/theme/toolboxaid-header.html`
-- Targeted `rg` reference checks for:
-  - `assets/theme/v1`
-  - `assets/theme/v1/fontawesome`
-  - `fontawesome`
-  - `assets/theme/v2/fonts/fontawesome`
-  - `CapturePreviewRuntime`
-  - `src/engine/theme`
-- Node verified move of `assets/theme/v1/fontawesome/` to `assets/theme/v2/fonts/fontawesome/`.
-- Updated `src/engine/theme/main.css`.
-- Updated `assets/theme/v1/README.md`.
-- Updated `src/engine/theme/README.md`.
-- Node targeted validator for:
-  - old Font Awesome V1 source removal
-  - moved Font Awesome destination file existence
-  - absence of active old Font Awesome path refs
-  - remaining active V1 references
-  - active V2 Font Awesome import resolution
-  - `src/engine/theme/CapturePreviewRuntime.js` absence
-  - `src/engine/theme/` non-empty status
+  - `tools/shared/tooling/CapturePreviewRuntime.js`
+  - `tools/dev/checkStyleSystemGuard.mjs`
+  - `tools/dev/checkSharedExtractionGuard.baseline.json`
+- Targeted ownership inventory for:
+  - `tools/`
+  - `old-tools/`
+  - `games/`
+  - `old_games/`
+  - `old_samples/`
+  - `docs/`
+  - `docs_build/`
+- Targeted active stale-reference checks for:
+  - `GameFoundryStudio/`
+  - `src/engine/theme/`
+  - `assets/theme/v1/`
+  - `favicon.ico`
+- Moved `assets/theme/v1/images/toolboxaid-header.png` to `assets/theme/v2/images/toolboxaid-header.png`.
+- Updated `src/engine/ui/toolboxaid-header.html`.
+- Updated `tools/shared/tooling/CapturePreviewRuntime.js`.
+- Updated `tools/dev/checkStyleSystemGuard.mjs`.
+- Updated `tools/dev/checkSharedExtractionGuard.baseline.json`.
+- Deleted `assets/theme/v1/`.
+- Deleted `src/engine/theme/`.
+- `node tools/dev/checkStyleSystemGuard.mjs`
+- `node --check tools/shared/tooling/CapturePreviewRuntime.js`
+- `node --check tools/dev/checkStyleSystemGuard.mjs`
 - Node static validation for changed HTML, JS, CSS, JSON, and Markdown files.
 - `git diff --check`
-- `git status --short -- start_of_day old_games old_samples old-tools`
+- `git status --short -- start_of_day old-tools old_games old_samples`
 - `npm run codex:review-artifacts`
-- ZIP packaging for `tmp/PR_26154_015-theme-v1-removal-fontawesome-v2_delta.zip`
+- ZIP packaging for `tmp/PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup_delta.zip`
 
 Validation summary:
 
-- PASS `assets/theme/v1/fontawesome/` moved out of Theme V1.
-- PASS Font Awesome CSS and font files exist under `assets/theme/v2/fonts/fontawesome/`.
-- PASS `src/engine/theme/main.css` imports the V2 Font Awesome path.
-- PASS no active old Font Awesome V1-path references remain.
-- PASS remaining active `assets/theme/v1` refs are limited to runtime header image consumers.
-- PASS `src/engine/theme/CapturePreviewRuntime.js` was already absent and has no active exact-path refs.
-- PASS `src/engine/theme/` remains non-empty and was not deleted.
+- PASS `assets/theme/v1/` removed.
+- PASS `src/engine/theme/` removed.
+- PASS active header image now resolves from `assets/theme/v2/images/toolboxaid-header.png`.
+- PASS no active stale references remain for `GameFoundryStudio/`, `src/engine/theme/`, `assets/theme/v1/`, or `favicon.ico`.
+- PASS active structure inventory completed for active and deprecated ownership areas.
+- PASS `node tools/dev/checkStyleSystemGuard.mjs`.
+- PASS syntax checks for changed JS files.
 - PASS static validation for changed HTML, JS, CSS, JSON, and Markdown files.
 - PASS `git diff --check`.
-- PASS no `start_of_day/`, `old_games/`, `old_samples/`, or `old-tools/` changes.
+- PASS no `start_of_day/`, `old-tools/`, `old_games/`, or `old_samples/` changes.
 - PASS review artifact generation.
 - PASS repo-structured delta ZIP packaging.
 - SKIPPED `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
-- SKIPPED old games, old samples, old tools, and full samples smoke validation per request.
+- SKIPPED old tools, old games, old samples, and full samples smoke validation per request.

…ts/theme/v1/images/toolboxaid-header.png …ts/theme/v2/images/toolboxaid-header.pngassets/theme/v1/images/toolboxaid-header.png renamed to assets/theme/v2/images/toolboxaid-header.png assets/theme/v1/images/toolboxaid-header.png renamed to assets/theme/v2/images/toolboxaid-header.png

@@ -1,9 +1,9 @@
-Theme V1 removal and Font Awesome V2 migration
+Final theme engine removal and active structure cleanup
 
-PR: PR_26154_015-theme-v1-removal-fontawesome-v2
+PR: PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup
 
-- Move `assets/theme/v1/fontawesome/` to `assets/theme/v2/fonts/fontawesome/`.
-- Update `src/engine/theme/main.css` to import Font Awesome from the V2 fonts path.
-- Keep `assets/theme/v1/` because two active runtime header templates still consume `images/toolboxaid-header.png`.
-- Confirm `src/engine/theme/CapturePreviewRuntime.js` is already absent and `src/engine/theme/` remains non-empty/runtime-owned.
-- Validate targeted references, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.
+- Move the final V1 header image to `assets/theme/v2/images/toolboxaid-header.png`.
+- Delete `assets/theme/v1/` and `src/engine/theme/` after active reference removal.
+- Remove active `src/engine/theme` dependencies from capture tooling and dev guards.
+- Produce final active-vs-deprecated ownership inventory and cleanup candidate report.
+- Validate targeted active references, changed static files, diff whitespace, review artifacts, and repo-structured delta ZIP packaging.

docs_build/dev/codex_commands.md

@@ -0,0 +1,73 @@
+# PR_26154_016 Active vs Deprecated Inventory Report
+
+Task: `PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup`
+
+## Active Ownership
+
+| Area | Ownership | Verification |
+| --- | --- | --- |
+| `assets/` | Public/static assets, including Theme V2 CSS, JS, partials, fonts, and images. | `assets/theme/v1/` removed; active header image now lives at `assets/theme/v2/images/toolboxaid-header.png`. |
+| `tools/` | Active tool surfaces and active tool support code. | Active tool folders use `tools/[toolname]/index.html`; support folders and support files remain under `tools/`. |
+| `games/` | Active game category surfaces and active game assets. | Game category folders with `index.html`: `action`, `adventure`, `arcade`, `puzzle`, `racing`, `retro`, `strategy`. `games/assets/` is support content. |
+| `docs/` | User-facing documentation only. | Contains `index.html`, `faq.html`, `reference.html`, `support.html`, and `README.md`. |
+| `docs_build/` | Governance, PR, reports, schemas docs, workflow, and build/development documentation. | Contains build/governance folders such as `dev/`, `pr/`, `reports/`, `schemas/`, `tools/`, and related workflow areas. |
+| `src/` | Active engine/source code excluding removed theme shell. | `src/engine/theme/` removed after active dependencies were removed. |
+
+## Active Tools
+
+Active tool folders with `index.html`:
+
+- `tools/ai-assistant/index.html`
+- `tools/animation/index.html`
+- `tools/assets/index.html`
+- `tools/builder/index.html`
+- `tools/cloud/index.html`
+- `tools/code/index.html`
+- `tools/configuration-admin/index.html`
+- `tools/creator/index.html`
+- `tools/game-builder/index.html`
+- `tools/game-design/index.html`
+- `tools/input/index.html`
+- `tools/localization/index.html`
+- `tools/midi/index.html`
+- `tools/object-vector/index.html`
+- `tools/palette/index.html`
+- `tools/particles/index.html`
+- `tools/publish/index.html`
+- `tools/sound/index.html`
+- `tools/storage/index.html`
+- `tools/world-vector/index.html`
+
+Active tool support areas/files:
+
+- `tools/dev/`
+- `tools/schemas/`
+- `tools/shared/`
+- `tools/index.html`
+- `tools/renderToolsIndex.js`
+- `tools/toolRegistry.js`
+- `tools/tools-page-accordions.js`
+
+## Deprecated Ownership
+
+| Area | Ownership | Verification |
+| --- | --- | --- |
+| `old-tools/` | Deprecated tool references. | Contains deprecated `old_*` tools plus deprecated/common support folders. |
+| `old_games/` | Deprecated playable games. | Contains legacy playable game folders and support/metadata files. |
+| `old_samples/` | Deprecated samples. | Contains legacy phase sample folders and support/metadata files. |
+
+## Remaining Cleanup Candidates
+
+These were identified but not moved in this PR:
+
+- `tools/_templates-v2/` still exists under `tools/` with an `index.html`; confirm whether it is an active template surface or should join deprecated template content under `old-tools/`.
+- `tools/dev/`, `tools/schemas/`, and `tools/shared/` are support folders under `tools/`, not user-facing tool surfaces. Future structure cleanup could document this exception or move support code if a new owner is approved.
+- `tools/renderToolsIndex.js` and `tools/toolRegistry.js` remain root-level tool support files; future cleanup could consolidate them only if active imports are mapped first.
+- `games/assets/` is a support folder under `games/`, not a game category page.
+- `docs_build/account/`, `docs_build/archive/`, `docs_build/operations/`, and related docs_build folders are build/governance documentation; keep out of public `/docs/`.
+
+## Validation
+
+- PASS: Active stale-reference validation for `GameFoundryStudio/`, `src/engine/theme/`, `assets/theme/v1/`, and `favicon.ico`.
+- PASS: Active structure inventory completed for `tools/`, `old-tools/`, `games/`, `old_games/`, `old_samples/`, `docs/`, and `docs_build/`.
+- PASS: Deprecated areas were not modified.

docs_build/dev/commit_comment.txt

@@ -0,0 +1,55 @@
+# PR_26154_016 Final Theme Engine Removal Report
+
+Task: `PR_26154_016-final-theme-engine-removal-and-active-structure-cleanup`
+
+## Scope
+
+- Read `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
+- Audited active references excluding docs, tests, reports, `old-tools/`, `old_games/`, `old_samples/`, and `start_of_day/`.
+- Removed remaining `assets/theme/v1/` content after moving the last active image to Theme V2.
+- Removed remaining `src/engine/theme/` content after removing active dependencies.
+- Did not modify `start_of_day/`, `old-tools/`, `old_games/`, or `old_samples/`.
+
+## Theme Cleanup
+
+| Item | Result |
+| --- | --- |
+| `assets/theme/v1/images/toolboxaid-header.png` | Moved to `assets/theme/v2/images/toolboxaid-header.png`. |
+| `assets/theme/v1/` | Deleted after active references were removed. |
+| `src/engine/theme/` | Deleted after active references were removed. |
+| `src/engine/ui/toolboxaid-header.html` | Updated to use `/assets/theme/v2/images/toolboxaid-header.png`. |
+| `tools/shared/tooling/CapturePreviewRuntime.js` | Removed imports from `src/engine/theme/Theme.js` and `ThemeTokens.js`; preserved the small document-theme setup locally. |
+| `tools/dev/checkStyleSystemGuard.mjs` | Retargeted required theme files to `assets/theme/v2/css/theme/v2/` and removed deprecated old sample/game/template pages from the active guard list. |
+| `tools/dev/checkSharedExtractionGuard.baseline.json` | Removed the deleted `src/engine/theme/mount-shared-header.js` baseline entry. |
+
+## Path Normalization
+
+Active reference validation found zero remaining active references to:
+
+- `GameFoundryStudio/`
+- `src/engine/theme/`
+- `assets/theme/v1/`
+- `favicon.ico`
+
+Historical references may remain in docs, reports, tests, or deprecated folders by exclusion.
+
+## Validation
+
+- PASS: `assets/theme/v1/` does not exist.
+- PASS: `src/engine/theme/` does not exist.
+- PASS: `assets/theme/v2/images/toolboxaid-header.png` exists.
+- PASS: `assets/theme/v2/fonts/fontawesome/css/font-awesome.min.css` exists.
+- PASS: Targeted active stale-reference validator found no active `GameFoundryStudio/`, `src/engine/theme/`, `assets/theme/v1/`, or `favicon.ico` references.
+- PASS: `node tools/dev/checkStyleSystemGuard.mjs`.
+- PASS: `node --check tools/shared/tooling/CapturePreviewRuntime.js`.
+- PASS: `node --check tools/dev/checkStyleSystemGuard.mjs`.
+- PASS: Static validation for 7 changed HTML/JS/CSS/JSON/Markdown files, including `.mjs`.
+- PASS: `git diff --check`.
+- PASS: `git status --short -- start_of_day old-tools old_games old_samples` returned no output.
+- SKIPPED: `npm run test:workspace-v2`; active Workspace V2 launch/navigation behavior was not changed.
+- SKIPPED: old tools, old games, old samples, and full samples smoke tests per request.
+
+## Notes
+
+- `tools/shared/tooling/CapturePreviewRuntime.js` remains active tooling and was kept in place.
+- `assets/theme/v2/fonts/fontawesome/` remains the Font Awesome location created in PR_26154_015.