Clarify local API startup logging for site and API URLs - PR_26169_026-local-api-startup-url-logging

Author: ToolboxAid

docs_build/dev/reports/PR_26169_026-local-api-startup-url-logging.md

@@ -0,0 +1,58 @@
+# PR_26169_026-local-api-startup-url-logging Report
+
+## Summary
+
+Fixed misleading local API startup logging in `scripts/start-local-api-server.mjs`. The startup output now reports the API bind URL separately from configured public site/API URLs and no longer appends `/account/sign-in.html` to the API runtime URL.
+
+## Branch Guard
+
+| Check | Expected | Actual | Status |
+| --- | --- | --- | --- |
+| Current branch | `main` | `main` | PASS |
+| Local branches found | includes `main` | `main` | PASS |
+
+## Requirement Checklist
+
+| Requirement | Evidence | Status |
+| --- | --- | --- |
+| Log API runtime server bind URL separately | `formatStartupLogLines()` first line is `GameFoundry API runtime server running at ${localServer.baseUrl}`. | PASS |
+| Log configured site URL from `GAMEFOUNDRY_SITE_URL` | Startup formatting prints `Configured site URL: ...`. | PASS |
+| Missing site URL shows `(not configured)` | `tests/dev-runtime/LocalApiStartupLogging.test.mjs` covers missing site URL. | PASS |
+| Log configured API URL from `GAMEFOUNDRY_API_URL` | Startup formatting prints `Configured API URL: ...` when env value is present. | PASS |
+| Missing API URL derives default from bind URL plus `/api` | Targeted test covers `http://127.0.0.1:5599/api` derived from bind URL. | PASS |
+| Preserve `.env` load, auth connection, database connection, SSL mode, stop logs | Targeted test asserts all required log lines and order. | PASS |
+| Do not change bind behavior | `startLocalApiServer({ host, port })` remains driven by existing `GAMEFOUNDRY_LOCAL_API_HOST` / `GAMEFOUNDRY_LOCAL_API_PORT` defaults. | PASS |
+| Do not expose secrets | Targeted test passes secret-like env values and asserts they do not appear in logs. | PASS |
+| Do not touch unrelated app areas | Only startup script, targeted test, and required docs/reports changed. | PASS |
+
+## Validation
+
+| Command | Result |
+| --- | --- |
+| `git branch --show-current` | PASS, `main` |
+| `node --check scripts/start-local-api-server.mjs` | PASS |
+| `node --check tests/dev-runtime/LocalApiStartupLogging.test.mjs` | PASS |
+| `node --test tests/dev-runtime/LocalApiStartupLogging.test.mjs` | PASS, 2 tests |
+
+## Manual Startup Shape
+
+Expected configured output shape after this PR:
+
+```text
+GameFoundry API runtime server running at http://127.0.0.1:5501
+Configured site URL: http://127.0.0.1:5500
+Configured API URL: http://127.0.0.1:5501/api
+.env loaded for API runtime (... key(s) applied).
+Configured auth connection: ...
+Configured database connection: ...
+Database SSL mode: ...
+Press Ctrl+C to stop.
+```
+
+## Lane Decisions
+
+| Lane | Decision |
+| --- | --- |
+| Runtime/startup logging | Executed targeted Node syntax and startup-log unit validation. |
+| Browser/UI/API behavior | Skipped; no browser, route, auth, membership, marketplace, owner, admin, or banner runtime behavior changed. |
+| Samples | Skipped; samples are not in scope and were not touched. |

docs_build/dev/reports/codex_changed_files.txt

@@ -1,36 +1,16 @@
 # git status --short
-M assets/theme-v2/js/account-auth-service.js
- M assets/theme-v2/js/gamefoundry-partials.js
  M docs_build/dev/reports/codex_changed_files.txt
  M docs_build/dev/reports/codex_review.diff
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
- M docs_build/dev/reports/environment_agnostic_browser_gate_report.md
- M docs_build/dev/reports/playwright_v8_coverage_report.txt
- M scripts/validate-browser-env-agnostic.mjs
- M src/api/server-api-client.js
- M src/dev-runtime/server/local-api-router.mjs
-?? docs_build/dev/reports/PR_26169_025-browser-api-url-config.md
-?? docs_build/pr/BUILD_PR_26169_025-browser-api-url-config.md
-?? src/api/public-config-client.js
-?? tests/dev-runtime/PublicApiUrlClient.test.mjs
-?? tests/playwright/tools/BrowserApiUrlConfig.spec.mjs
+ M scripts/start-local-api-server.mjs
+?? docs_build/dev/reports/PR_26169_026-local-api-startup-url-logging.md
+?? docs_build/pr/BUILD_PR_26169_026-local-api-startup-url-logging.md
+?? tests/dev-runtime/LocalApiStartupLogging.test.mjs
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/PR_26169_025-browser-api-url-config.md
-docs_build/pr/BUILD_PR_26169_025-browser-api-url-config.md
-src/api/public-config-client.js
-tests/dev-runtime/PublicApiUrlClient.test.mjs
-tests/playwright/tools/BrowserApiUrlConfig.spec.mjs
+docs_build/dev/reports/PR_26169_026-local-api-startup-url-logging.md
+docs_build/pr/BUILD_PR_26169_026-local-api-startup-url-logging.md
+tests/dev-runtime/LocalApiStartupLogging.test.mjs
 
-# git diff --stat
-assets/theme-v2/js/account-auth-service.js         |    6 +-
- assets/theme-v2/js/gamefoundry-partials.js         |  219 +-
- docs_build/dev/reports/codex_changed_files.txt     |   44 +-
- docs_build/dev/reports/codex_review.diff           | 2349 +++++++++++---------
- .../dev/reports/coverage_changed_js_guardrail.txt  |   65 +-
- .../environment_agnostic_browser_gate_report.md    |    2 +-
- .../dev/reports/playwright_v8_coverage_report.txt  |  126 +-
- scripts/validate-browser-env-agnostic.mjs          |    4 +-
- src/api/server-api-client.js                       |   13 +-
- src/dev-runtime/server/local-api-router.mjs        |    7 +
- 10 files changed, 1537 insertions(+), 1298 deletions(-)
+# git diff --stat -- . :!docs_build/dev/reports/codex_review.diff :!docs_build/dev/reports/codex_changed_files.txt
+ scripts/start-local-api-server.mjs | 109 +++++++++++++++++++++++++------------
+ 1 file changed, 75 insertions(+), 34 deletions(-)