Skip to content

Commit 0e1edf0

Browse files
ToolboxAidToolboxAid
committed
asdf
1 parent daf2acb commit 0e1edf0

15 files changed

Lines changed: 1812 additions & 1058 deletions

‎docs_build/dev/PROJECT_INSTRUCTIONS.md‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1634,6 +1634,16 @@ UI consistency validation expectations:
16341634
- accordion controls must open, close, preserve state when expected, and expose no dead accordion behavior
16351635
- dead accordion enforcement is mandatory for tool completion and recovery/UAT lanes
16361636

1637+
### Summary Table / Notes Table Governance
1638+
1639+
For tools that present Summary Table or Notes Table note-management surfaces:
1640+
- Add Note controls belong below the table.
1641+
- Clicking Add Note opens an inline input row inside the table.
1642+
- Tables with notes must include Edit and Delete actions on the right.
1643+
- System-created notes cannot be deleted.
1644+
- System-created notes may only have status changed when the tool explicitly allows status editing.
1645+
- Selected Note Metadata must be shown as table columns, not as a separate detached panel.
1646+
16371647
## INPUT RESOLUTION RULES
16381648

16391649
- Discover real files and directories.

‎docs_build/dev/reports/PR_26171_021-summary-notes-table-governance-manual-validation.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26171_021 Manual Validation Notes
2+
3+
## Manual Review
4+
- Reviewed `docs_build/dev/PROJECT_INSTRUCTIONS.md` and confirmed the new Summary Table / Notes Table Governance section is under the existing UI Consistency Contract.
5+
- Confirmed the change is documentation-only and does not modify runtime, UI, database, tests, or tooling code.
6+
7+
## Expected Outcome
8+
- Future Summary Table and Notes Table implementations place Add Note controls below the table.
9+
- Future Add Note actions open an inline input row inside the table.
10+
- Future note tables expose Edit and Delete actions on the right, while preserving system-created note restrictions.
11+
- Future selected note metadata is represented in table columns rather than a detached panel.
12+
13+
## Out Of Scope
14+
- Runtime implementation.
15+
- UI changes.
16+
- Database changes.
17+
- Playwright/browser validation.

‎docs_build/dev/reports/PR_26171_021-summary-notes-table-governance-validation.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# PR_26171_021 Validation Report
2+
3+
## Validation Performed
4+
- PASS: `git diff --check -- docs_build/dev/PROJECT_INSTRUCTIONS.md`
5+
- PASS: `rg -n "### Summary Table / Notes Table Governance|Add Note controls belong below the table|Clicking Add Note opens an inline input row inside the table|Tables with notes must include Edit and Delete actions on the right|System-created notes cannot be deleted|System-created notes may only have status changed|Selected Note Metadata must be shown as table columns" docs_build/dev/PROJECT_INSTRUCTIONS.md`
6+
- PASS: `git diff --check -- docs_build/dev/PROJECT_INSTRUCTIONS.md docs_build/dev/reports/codex_changed_files.txt docs_build/dev/reports/PR_26171_021-summary-notes-table-governance.md docs_build/dev/reports/PR_26171_021-summary-notes-table-governance-validation.md docs_build/dev/reports/PR_26171_021-summary-notes-table-governance-manual-validation.md`
7+
- PASS: `rg -n "No Playwright impact|Playwright was not run|No runtime implementation|No UI changes|No database changes" docs_build/dev/reports -g "PR_26171_021-summary-notes-table-governance*.md"`
8+
9+
## Validation Scope
10+
- Docs/static validation only.
11+
- Playwright was not run.
12+
- No runtime, UI, or database validation was required because this is a governance-only documentation PR.
13+
14+
## Result
15+
- PASS: The requested governance section exists in `docs_build/dev/PROJECT_INSTRUCTIONS.md`.
16+
- PASS: The requested behavior bullets are present.
17+
- PASS: The docs-only diff has no whitespace errors.

‎docs_build/dev/reports/PR_26171_021-summary-notes-table-governance.md‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# PR_26171_021 Summary / Notes Table Governance
2+
3+
## Summary
4+
- Added docs-only project instruction governance for Summary Table and Notes Table note-management behavior.
5+
- Scope is documentation only.
6+
7+
## Governance Added
8+
- Add Note controls belong below the table.
9+
- Clicking Add Note opens an inline input row inside the table.
10+
- Tables with notes must include Edit and Delete actions on the right.
11+
- System-created notes cannot be deleted.
12+
- System-created notes may only have status changed when the tool explicitly allows status editing.
13+
- Selected Note Metadata must be shown as table columns, not as a separate detached panel.
14+
15+
## Scope Controls
16+
- No runtime implementation.
17+
- No UI changes.
18+
- No database changes.
19+
- No Playwright impact. This PR is docs/workflow only.
20+
21+
## Changed Files
22+
- `docs_build/dev/PROJECT_INSTRUCTIONS.md`
23+
- `docs_build/dev/reports/codex_review.diff`
24+
- `docs_build/dev/reports/codex_changed_files.txt`
25+
- `docs_build/dev/reports/PR_26171_021-summary-notes-table-governance.md`
26+
- `docs_build/dev/reports/PR_26171_021-summary-notes-table-governance-validation.md`
27+
- `docs_build/dev/reports/PR_26171_021-summary-notes-table-governance-manual-validation.md`

‎docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction-manual-validation.md‎

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,24 @@
1+
# PR_26171_023 Manual Validation Notes
2+
3+
## Summary Table Pattern
4+
- Confirmed detached Add Note, Selected Note Metadata, and standalone Note Tree accordions are absent.
5+
- Confirmed Add Note control renders below the Summary Table.
6+
- Confirmed clicking Add Note opens an inline row inside the Summary Table.
7+
- Confirmed note Edit opens inline editing inside the selected table row.
8+
- Confirmed Note Tree renders as an embedded subtable row under the Add row or edited/selected row.
9+
- Confirmed Edit/Delete actions render in the rightmost Actions column.
10+
11+
## System-Created Notes
12+
- Confirmed a system-created note shows `System-created` in the Owner column.
13+
- Confirmed system-created note Delete is disabled.
14+
- Confirmed system-created note name/type fields are disabled in the inline edit row.
15+
- Existing system-created item behavior still allows status changes through the selected item editor when permitted.
16+
17+
## Persistence
18+
- Confirmed Local API add/update/delete note methods work against a temp SQLite path.
19+
- Confirmed no new database tables were required.
20+
21+
## PR_015, PR_017, PR_019 Visibility
22+
- Confirmed recommended target rows are visible.
23+
- Confirmed progress dashboard is visible.
24+
- Confirmed completion insight headings/copy are visible, including `What To Do Next`.

‎docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction-requirements.md‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# PR_26171_023 Requirement Checklist
2+
3+
| Requirement | Status | Evidence |
4+
| --- | --- | --- |
5+
| Add Note button belongs below the table. | PASS | Add Note control moved under `data-journey-summary-table`. |
6+
| Clicking Add Note opens an inline input row inside the table. | PASS | `data-journey-add-note-row` renders inside `data-journey-summary-body`. |
7+
| Current Edit opens inline editing in the selected table row. | PASS | `data-journey-edit-note-row` renders name/type inputs for the selected note. |
8+
| Note Tree renders as a subtable under the Add row or edited/selected row. | PASS | `data-journey-note-tree-row` embeds `Selected note item subtable`. |
9+
| Edit/Delete actions appear on the right side of each row. | PASS | Actions column added as the final Summary Table column. |
10+
| System-created notes cannot be deleted. | PASS | System note Delete is disabled and repository `deleteNote` refuses system notes. |
11+
| System-created notes may only allow status changes. | PASS | System note name/type fields are disabled; item status behavior remains controlled by existing editor rules. |
12+
| Selected Note Metadata shown as table columns, not detached panel. | PASS | Type, Owner, Updated, and Actions are Summary Table columns; detached panel removed. |
13+
| Verify PR_26171_015 requested Journey UI changes are visible/functioning. | PASS | Targeted dashboard validation confirms recommended target rows and persistence surface. |
14+
| Verify PR_26171_017 requested Journey UI changes are visible/functioning. | PASS | Targeted dashboard validation confirms actionable completion insight copy. |
15+
| Verify PR_26171_019 requested Journey UI changes are visible/functioning. | PASS | Targeted dashboard validation confirms polished dashboard labels and status text. |
16+
| Do not add new database tables. | PASS | Reused existing Game Journey repository/tables. |
17+
| Do not add gamification, badges, XP, or publishing gates. | PASS | No such features added. |
18+
| Theme V2 only. | PASS | Reused existing Theme V2 classes. |
19+
| No inline styles, style blocks, inline handlers, page-local CSS, or tool-local CSS. | PASS | Targeted Playwright check asserts `style, [style], script:not([src])` count is zero. |
20+
| Run targeted Game Journey validation. | PASS | Focused Playwright command passed 2 tests. |
21+
| Run `npm run test:workspace-v2`. | FAIL (unrelated) | Lane ran and failed on root tool count/sign-in expectations outside Game Journey scope. |

‎docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction-validation.md‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# PR_26171_023 Validation Report
2+
3+
## Targeted Syntax Checks
4+
- PASS: `node --check toolbox/game-journey/game-journey.js`
5+
- PASS: `node --check src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js`
6+
- PASS: `node --check src/dev-runtime/server/local-api-router.mjs`
7+
- PASS: `node --check tests/playwright/tools/GameJourneyTool.spec.mjs`
8+
9+
## Targeted Game Journey Validation
10+
- PASS: `npx playwright test tests/playwright/tools/GameJourneyTool.spec.mjs -g "Game Journey (summary table uses inline notes and item subtables|progress dashboard summarizes completion metrics)" --workers=1 --reporter=list`
11+
- Result: 2 passed.
12+
- Coverage:
13+
- Summary Table inline Add Note row.
14+
- Inline note edit row.
15+
- Embedded Note Tree subtable.
16+
- Right-side Edit/Delete row actions.
17+
- System-created note delete protection.
18+
- PR_26171_015 recommended target UI persistence surface.
19+
- PR_26171_017 actionable insight copy.
20+
- PR_26171_019 dashboard polish labels and empty/status text surface.
21+
22+
## Local API And SQLite Smoke
23+
- PASS: Direct Local API smoke against a temp SQLite path.
24+
- Result: added `PR 023 SQLite Note`, updated it to `PR 023 SQLite Note Updated`, deleted it, and confirmed `stillExists: false`.
25+
26+
## Workspace Lane
27+
- FAIL: `npm run test:workspace-v2`
28+
- Command note: script name is legacy; user-facing language is Project Workspace.
29+
- Failure appears unrelated to PR_26171_023:
30+
- `RootToolsFutureState.spec.mjs` expected `Tool Count: 13/42`, received `Tool Count: 14/46`.
31+
- `RootToolsFutureState.spec.mjs` expected nav label `Sign In`, received signed-in labels `DavidQ`, `Owner`, `Admin`.
32+
- No Game Journey failure was reported by this lane.

‎docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction.md‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
# PR_26171_023 Game Journey Summary Table Correction
2+
3+
## Summary
4+
- Moved Game Journey note creation, note metadata, note actions, and the Note Tree into Summary Table patterns.
5+
- Replaced detached Add Note, Selected Note Metadata, and standalone Note Tree panels with inline table rows and embedded item subtables.
6+
- Added user-created note update/delete support through the existing Game Journey Local API repository model.
7+
- Preserved system-created note protections: system notes cannot be deleted and their note-level name/type fields remain locked.
8+
- Verified PR_26171_015, PR_26171_017, and PR_26171_019 visible surfaces through the focused Game Journey dashboard validation.
9+
10+
## Scope
11+
- Runtime UI: `toolbox/game-journey/index.html`
12+
- Runtime behavior: `toolbox/game-journey/game-journey.js`
13+
- Repository behavior: `src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js`
14+
- Local API routing persistence exception for Game Journey tool-store writes: `src/dev-runtime/server/local-api-router.mjs`
15+
- Targeted Playwright coverage: `tests/playwright/tools/GameJourneyTool.spec.mjs`
16+
17+
## Notes
18+
- No new database tables were added.
19+
- No gamification, badges, XP, publishing gates, or unrelated tool integrations were added.
20+
- No inline styles, style blocks, inline event handlers, page-local CSS, or tool-local CSS were added.

‎docs_build/dev/reports/codex_changed_files.txt‎

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
1-
docs_build/database/ddl/messages.sql
2-
docs_build/database/dml/messages.sql
3-
docs_build/database/seed/messages.json
4-
docs_build/dev/commit_comment.txt
5-
docs_build/dev/reports/PR_26171_008-message-tts-profile-foundation-manual-validation.md
6-
docs_build/dev/reports/PR_26171_008-message-tts-profile-foundation-validation.txt
7-
docs_build/dev/reports/PR_26171_008-message-tts-profile-foundation.md
8-
docs_build/dev/reports/codex_changed_files.txt
1+
src/dev-runtime/persistence/tool-repositories/game-journey-mock-repository.js
2+
src/dev-runtime/server/local-api-router.mjs
3+
tests/playwright/tools/GameJourneyTool.spec.mjs
4+
toolbox/game-journey/game-journey.js
5+
toolbox/game-journey/index.html
6+
docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction.md
7+
docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction-validation.md
8+
docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction-manual-validation.md
9+
docs_build/dev/reports/PR_26171_023-game-journey-summary-table-correction-requirements.md
910
docs_build/dev/reports/codex_review.diff
10-
docs_build/dev/reports/coverage_changed_js_guardrail.txt
11-
docs_build/dev/reports/playwright_v8_coverage_report.txt
12-
src/dev-runtime/messages/messages-sqlite-service.mjs
13-
tests/playwright/tools/MessagesTool.spec.mjs
14-
toolbox/messages/index.html
15-
toolbox/messages/messages-api-client.js
16-
toolbox/messages/messages.js
11+
docs_build/dev/reports/codex_changed_files.txt

0 commit comments

Comments
 (0)