Add Controls event tooltips defaults and lock engine pause - PR_26162_049-controls-tooltips-defaults-pause-lock

Author: ToolboxAid

account/user-controls-page.js

@@ -351,7 +351,7 @@ export class AccountUserControlsPage {
         row.append(
           tableCell(mapping.physicalInput),
           tableCell(mapping.normalizedInput || mapping.positiveNormalizedInput || mapping.negativeNormalizedInput || "Unassigned"),
-          tableCell("Default profile in use"),
+          tableCell("Default profile"),
         );
         rowsByFamily.get(family)?.push(row);
       });

account/user-controls.html

@@ -34,7 +34,7 @@ <h2>Physical Input Mapping</h2>
                             <details class="vertical-accordion" open data-account-user-controls-section="Keyboard">
                                 <summary>Keyboard</summary>
                                 <div class="accordion-body content-stack">
-                                    <p class="status">Default profile in use. Create my profile to save your own keyboard mappings.</p>
+                                    <p class="status">Default profile. Create my profile to save your own keyboard mappings.</p>
                                     <div class="table-wrapper">
                                         <table class="data-table" aria-label="Default keyboard fallback" data-account-user-controls-defaults="Keyboard">
                                             <thead>
@@ -68,7 +68,7 @@ <h2>Physical Input Mapping</h2>
                             <details class="vertical-accordion" open data-account-user-controls-section="Mouse">
                                 <summary>Mouse</summary>
                                 <div class="accordion-body content-stack">
-                                    <p class="status">Default profile in use. Create my profile to save your own mouse mappings.</p>
+                                    <p class="status">Default profile. Create my profile to save your own mouse mappings.</p>
                                     <div class="table-wrapper">
                                         <table class="data-table" aria-label="Default mouse fallback" data-account-user-controls-defaults="Mouse">
                                             <thead>

docs_build/dev/reports/codex_changed_files.txt

@@ -1,18 +1,18 @@
 # git status --short
-M assets/theme-v2/css/colors.css
- M assets/theme-v2/css/forms.css
- M docs_build/dev/reports/coverage_changed_js_guardrail.txt
+M docs_build/dev/reports/coverage_changed_js_guardrail.txt
  M docs_build/dev/reports/playwright_v8_coverage_report.txt
  M tests/playwright/tools/InputMappingV2Tool.spec.mjs
-?? docs_build/dev/reports/controls-checkbox-state-styling-report.md
+ M toolbox/controls/controls.js
+ M toolbox/controls/index.html
+?? docs_build/dev/reports/controls-tooltips-defaults-pause-lock-report.md
 
 # git ls-files --others --exclude-standard
-docs_build/dev/reports/controls-checkbox-state-styling-report.md
+docs_build/dev/reports/controls-tooltips-defaults-pause-lock-report.md
 
 # git diff --stat
-assets/theme-v2/css/colors.css                     |  3 +++
- assets/theme-v2/css/forms.css                      | 26 +++++++++++++++++++
- .../dev/reports/coverage_changed_js_guardrail.txt  |  3 +--
- .../dev/reports/playwright_v8_coverage_report.txt  | 29 ++++++----------------
- tests/playwright/tools/InputMappingV2Tool.spec.mjs | 29 ++++++++++++++++++++++
- 5 files changed, 66 insertions(+), 24 deletions(-)
+.../dev/reports/coverage_changed_js_guardrail.txt  |   2 +-
+ .../dev/reports/playwright_v8_coverage_report.txt  |   8 +-
+ tests/playwright/tools/InputMappingV2Tool.spec.mjs | 100 ++++++++----
+ toolbox/controls/controls.js                       | 171 ++++++++++++++++++---
+ toolbox/controls/index.html                        |   8 +-
+ 5 files changed, 231 insertions(+), 58 deletions(-)

docs_build/dev/reports/codex_review.diff

@@ -0,0 +1,75 @@
+# PR_26162_049-controls-tooltips-defaults-pause-lock
+
+## Branch Validation
+- PASS: current branch is `main`.
+- Expected branch: `main`.
+
+## Requirement Checklist
+- PASS: Read `docs_build/dev/PROJECT_INSTRUCTIONS.md` before edits.
+- PASS: Continued from PR_26162_048 without changing the enabled checkbox styling.
+- PASS: Added hover/ARIA tooltip text for Game Controls columns:
+  - `D = Down`
+  - `H = Hold`
+  - `U = Up`
+  - `DC = Double Click / Double Press`
+- PASS: Movement default rows now use Hold only.
+- PASS: Aim default rows now use Hold only.
+- PASS: Movement and aim defaults leave Down, Up, and Double Click unchecked.
+- PASS: `action.pause` remains visible in Game Controls.
+- PASS: `action.pause` is engine-owned and rendered read-only/locked.
+- PASS: `action.pause` cannot be disabled through the UI because no edit action is exposed and loaded/saved pause rows are normalized to enabled.
+- PASS: `action.pause` cannot be deleted through the UI because no Trash action is exposed and save/read repair restores it if missing.
+- PASS: Game Controls explains `Pause is handled by the engine.`
+- PASS: DB-backed Game Controls and Account User Controls separation is preserved.
+- PASS: No sample JSON alignment, auth behavior, production account system, or unrelated rewrites were added.
+
+## Changed Files
+- `toolbox/controls/index.html`
+- `toolbox/controls/controls.js`
+- `tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- `docs_build/dev/reports/coverage_changed_js_guardrail.txt`
+- `docs_build/dev/reports/controls-tooltips-defaults-pause-lock-report.md`
+
+## Impacted Lanes
+- Toolbox Controls runtime lane.
+- Playwright impacted: Yes.
+
+## Validation Performed
+- PASS: `node --check toolbox/controls/controls.js`
+- PASS: `node --check tests/playwright/tools/InputMappingV2Tool.spec.mjs`
+- PASS: `git diff --check`
+- PASS: `rg -n "<style|style\\s*=|\\son[a-z]+\\s*=" toolbox/controls/index.html toolbox/controls/controls.js` returned no matches.
+- PASS: `npx playwright test tests/playwright/tools/InputMappingV2Tool.spec.mjs --grep "Toolbox Controls|Game Controls edits|Game Controls validates|Controls split"`
+
+## Playwright Result
+- PASS: 4 targeted Controls tests passed.
+- Covered behavior:
+  - D/H/U/DC hover and ARIA tooltip metadata.
+  - Movement and aim defaults use Hold only.
+  - Pause remains visible and locked.
+  - Pause has no Edit or Trash action.
+  - Pause remains enabled and canonical after save/reload.
+  - Existing Controls runtime/Account User Controls separation remains intact.
+
+## V8 Coverage
+- Generated: `docs_build/dev/reports/playwright_v8_coverage_report.txt`
+- Result: `(94%) toolbox/controls/controls.js - executed lines 667/667; executed functions 68/72`
+- Guardrail: no changed runtime JS coverage warnings.
+
+## Skipped Lanes
+- Full samples validation skipped: samples are out of scope and no sample JSON, game runtime, or sample launch behavior changed.
+- Full workspace suite skipped: this PR only changes the Controls tool UI/runtime behavior and targeted Controls Playwright covers the affected behavior.
+- Account/User Controls full behavior lane skipped beyond separation regression: no Account/User Controls files or behavior were changed.
+
+## Manual Validation Steps
+1. Open `/toolbox/controls/index.html`.
+2. Hover the D, H, U, and DC column headers and confirm their tooltip meanings.
+3. Confirm Move and Aim rows show Hold checked and Down, Up, and Double Click unchecked.
+4. Confirm `action.pause` / Pause is visible.
+5. Confirm the Pause row says `Pause is handled by the engine.`
+6. Confirm Pause has no Edit or Trash button.
+7. Reload the page and confirm Pause remains visible, enabled, and locked.
+
+## Samples Decision
+- SKIP: Full samples validation was not run because this PR does not touch samples, sample data, or production runtime behavior.

docs_build/dev/reports/controls-tooltips-defaults-pause-lock-report.md

@@ -6,7 +6,7 @@ Missing changed runtime JS files are WARN, not FAIL.
 Source: Playwright/Chromium built-in V8 coverage from the active Playwright run.
 
 Changed runtime JS files considered:
-(67%) toolbox/controls/controls.js - executed lines 546/546; executed functions 35/52
+(94%) toolbox/controls/controls.js - executed lines 667/667; executed functions 68/72
 
 Guardrail warnings:
 (100%) none - no changed runtime JS coverage warnings

docs_build/dev/reports/coverage_changed_js_guardrail.txt

@@ -12,25 +12,25 @@ Note: entry percentages use function coverage when available, otherwise line cov
 Note: coverage entries are aggregated across every page/tool where coverageReporter.start(page) and coverageReporter.stop(page) ran.
 
 Exercised tool entry points detected:
-(71%) Toolbox Index - exercised 3 runtime JS files
+(89%) Toolbox Index - exercised 3 runtime JS files
 (0%) Tool Template V2 - not exercised by this Playwright run
 (58%) Theme V2 Shared JS - exercised 2 runtime JS files
 
 Changed runtime JS files covered:
-(67%) toolbox/controls/controls.js - executed lines 546/546; executed functions 35/52
+(94%) toolbox/controls/controls.js - executed lines 667/667; executed functions 68/72
 
 Files with executed line/function counts where available:
 (29%) src/engine/input/NormalizedInputRegistry.js - executed lines 321/321; executed functions 6/21
 (53%) src/engine/api/server-api-client.js - executed lines 159/159; executed functions 10/19
 (57%) assets/theme-v2/js/gamefoundry-partials.js - executed lines 625/625; executed functions 30/53
 (64%) assets/theme-v2/js/tool-display-mode.js - executed lines 209/209; executed functions 9/14
-(67%) toolbox/controls/controls.js - executed lines 546/546; executed functions 35/52
 (75%) toolbox/tool-registry-api-client.js - executed lines 152/152; executed functions 21/28
+(94%) toolbox/controls/controls.js - executed lines 667/667; executed functions 68/72
 (100%) toolbox/controls/controls-api-client.js - executed lines 12/12; executed functions 2/2
 
 Uncovered or low-coverage changed JS files:
 (100%) none - no low-coverage changed runtime JS files
 
 Changed JS files considered:
 (0%) tests/playwright/tools/InputMappingV2Tool.spec.mjs - changed JS file not collected as browser runtime coverage
-(67%) toolbox/controls/controls.js - changed JS file with browser V8 coverage
+(94%) toolbox/controls/controls.js - changed JS file with browser V8 coverage