Skip to content

Commit 00d9c5f

Browse files
ToolboxAidToolboxAid
committed
Rebuild PR022 remaining src dependency cleanup
1 parent 2e38e9e commit 00d9c5f

11 files changed

Lines changed: 154 additions & 257 deletions

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_branch-validation.md‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
# Branch Validation - PR_26180_OWNER_022-resolve-remaining-src-dependencies
2+
3+
- Current branch: `PR_26180_OWNER_022-resolve-remaining-src-dependencies`
4+
- Current branch is not `main`: PASS
5+
- Base branch used: `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`
6+
- Base commit: `2e38e9e31`
7+
- `www/` exists: PASS
8+
- `api/` exists: PASS
9+
- Root tracked `assets/`: 0 files, PASS
10+
- Root tracked `games/`: 0 files, PASS
11+
- Root tracked `learn/`: 0 files, PASS
12+
- Root tracked `toolbox/`: 0 files, PASS
13+
- Root `src` files before cleanup: 65
14+
- Root `src` files after cleanup: 64
15+
16+
## Result
17+
18+
PASS

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_manual-validation-notes.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
# Manual Validation Notes - PR_26180_OWNER_022-resolve-remaining-src-dependencies
2+
3+
- No manual browser route validation was required because public URLs and product behavior were not changed.
4+
- `www/toolbox/toolRegistry.js` import smoke returned 47 tools after the path correction.
5+
- Full `src/` retirement remains out of scope.
6+
- `-v2` contracts and manifest/sample schemas remain root `src` transition files because active validation still references them.

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_report.md‎

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,71 @@
1+
# PR_26180_OWNER_022-resolve-remaining-src-dependencies Report
2+
3+
## Executive Summary
4+
5+
Rebuilt PR022 from the migration stack base `PR_26180_OWNER_021-archive-legacy-games-samples-teardown` at `2e38e9e31`, not from `main`.
6+
7+
The rebuilt PR is intentionally narrow:
8+
9+
- Deletes obsolete `src/shared/projectDataStore/inMemoryProjectDataStore.js`.
10+
- Deletes the stale self-test that only validated that obsolete in-memory store.
11+
- Confirms `src/shared/number/numbers.js` is not present on PR021 and the active equivalent remains at `www/src/shared/number/numbers.js`.
12+
- Preserves `-v2` tool contract files because active dev contract tests still import them.
13+
- Preserves manifest-era/sample-era schemas because active validation still references them.
14+
- Updates `www/toolbox/toolRegistry.js` to import the existing `www/src/shared/toolbox/tool-metadata-inventory.js` equivalent rather than traversing to root `src`.
15+
16+
## Branch Model
17+
18+
- Model: Owner stacked PR
19+
- Base branch: `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`
20+
- Base commit: `2e38e9e31`
21+
- Source branch: `PR_26180_OWNER_022-resolve-remaining-src-dependencies`
22+
- Rebuilt from migration stack: YES
23+
- Used `main` as base: NO
24+
25+
## Migration Stack Gates
26+
27+
| Gate | Result |
28+
|---|---:|
29+
| Current branch is not `main` | PASS |
30+
| `www/` exists | PASS |
31+
| `api/` exists | PASS |
32+
| root `assets/` tracked active folder absent | PASS |
33+
| root `games/` tracked active folder absent | PASS |
34+
| root `learn/` tracked active folder absent | PASS |
35+
| root `toolbox/` tracked active folder absent | PASS |
36+
37+
## Root Src Count
38+
39+
- Before: 65 tracked files under `src/`
40+
- After: 64 tracked files under `src/`
41+
42+
## Cleanup Decisions
43+
44+
| Item | Decision | Reason |
45+
|---|---|---|
46+
| `src/shared/projectDataStore/inMemoryProjectDataStore.js` | Deleted | Obsolete in-memory project data store; no active references remain after deleting stale self-test. |
47+
| `dev/tests/shared/InMemoryProjectDataStore.test.mjs` | Deleted | Test only validated the deleted obsolete helper. |
48+
| `src/shared/number/numbers.js` | No action | Root file is absent; active equivalent exists under `www/src/shared/number/numbers.js`. |
49+
| `-v2` tool contract files under `src/shared/contracts/tools/` | Preserved | Active dev contract tests import these modules directly. |
50+
| `src/shared/schemas/game.manifest.schema.json` | Preserved | Active `validate-json-contracts` and fixtures still reference it. |
51+
| `src/shared/schemas/samples/sample.tool-payload.schema.json` | Preserved | Active sample validation reports and `ToolManifestBoundary` still reference it. |
52+
| `www/toolbox/toolRegistry.js` import path | Updated | Existing equivalent is under `www/src/shared/toolbox/`; avoids root `src` traversal. |
53+
54+
## Protected Paths
55+
56+
No files under `dev/workspace/generated/tool-images/**` were touched.
57+
58+
## Validation Summary
59+
60+
- `git diff --check`: PASS
61+
- `npm run validate:canonical-structure`: PASS
62+
- `node --check www/toolbox/toolRegistry.js`: PASS
63+
- Browser registry import smoke: PASS, returned 47 tools
64+
- `node ./dev/tests/shared/ProjectDataStoreContract.test.mjs`: PASS
65+
- `node ./dev/tests/dev-runtime/ArchitectureCleanupApiNavInvitations.test.mjs`: PASS
66+
- `node ./dev/tests/tools/ToolManifestBoundary.test.mjs`: PASS
67+
- Targeted root `src` reference scans: PASS with active references documented and preserved
68+
69+
## Outcome
70+
71+
PR022 has been rebuilt from PR021 and is ready as a narrow migration-stack cleanup branch. It does not attempt broad `src/` retirement.

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_requirement-checklist.md‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# Requirement Checklist - PR_26180_OWNER_022-resolve-remaining-src-dependencies
2+
3+
| Requirement | Status | Notes |
4+
|---|---:|---|
5+
| Checkout PR021 base | PASS | Rebuilt from `PR_26180_OWNER_021-archive-legacy-games-samples-teardown`. |
6+
| Hard stop if current branch is main | PASS | Work performed on PR022 branch. |
7+
| Hard stop if `www/` or `api/` missing | PASS | Both present. |
8+
| Hard stop if root tracked `assets/`, `games/`, `learn/`, `toolbox/` exist | PASS | Tracked counts are 0. |
9+
| Confirm remaining root `src` files | PASS | 65 before cleanup. |
10+
| Delete `inMemoryProjectDataStore.js` | PASS | Deleted. |
11+
| Resolve `src/shared/number/numbers.js` | PASS | Root file absent; `www/src/shared/number/numbers.js` exists. |
12+
| Delete/archive obsolete `-v2` toolId files | PASS | None deleted because active tests reference them. |
13+
| Delete/archive manifest/sample files only after scan | PASS | Preserved due active validation references. |
14+
| Do not touch `dev/workspace/generated/tool-images/**` | PASS | Protected path untouched. |
15+
| Preserve runtime behavior | PASS | Only path correction and obsolete validation helper deletion. |
16+
| Run required validation | PASS | See validation report. |
17+
| Produce ZIP under `dev/workspace/zips/` | PASS | `_delta.zip` created. |

‎dev/reports/PR_26180_OWNER_022-resolve-remaining-src-dependencies_validation-report.md‎

Lines changed: 41 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
# Validation Report - PR_26180_OWNER_022-resolve-remaining-src-dependencies
2+
3+
## Commands
4+
5+
```text
6+
git diff --check
7+
npm run validate:canonical-structure
8+
node --check www/toolbox/toolRegistry.js
9+
node --input-type=module -e "const m=await import('./www/toolbox/toolRegistry.js'); console.log(m.getToolRegistrySnapshot().tools.length);"
10+
node ./dev/tests/shared/ProjectDataStoreContract.test.mjs
11+
node ./dev/tests/dev-runtime/ArchitectureCleanupApiNavInvitations.test.mjs
12+
node ./dev/tests/tools/ToolManifestBoundary.test.mjs
13+
```
14+
15+
## Targeted Scans
16+
17+
- `git ls-files -- src` count before/after
18+
- active references to `src/shared/projectDataStore/inMemoryProjectDataStore.js`
19+
- active references to root `src/shared/number/numbers.js`
20+
- `toolId: "*-v2"` files under `src`
21+
- active imports of matching `-v2` contract files
22+
- active references to `game.manifest.schema.json` and `sample.tool-payload.schema.json`
23+
24+
## Results
25+
26+
- `git diff --check`: PASS
27+
- `npm run validate:canonical-structure`: PASS
28+
- `node --check www/toolbox/toolRegistry.js`: PASS
29+
- Browser registry import smoke: PASS, returned 47 tools
30+
- `ProjectDataStoreContract.test.mjs`: PASS
31+
- `ArchitectureCleanupApiNavInvitations.test.mjs`: PASS
32+
- `ToolManifestBoundary.test.mjs`: PASS
33+
- Root `src` count: 65 before, 64 after
34+
- In-memory store scan: PASS, no active references remain
35+
- Root number helper scan: PASS, root file absent; active references use `www/src/shared/number/numbers.js`
36+
- `-v2` contract scan: PASS, active test references documented and preserved
37+
- Manifest/sample schema scan: PASS, active validation references documented and preserved
38+
39+
## Result
40+
41+
PASS

‎dev/reports/codex_changed_files.txt‎

-4.57 KB
Binary file not shown.

‎dev/reports/codex_review.diff‎

-687 KB
Binary file not shown.

‎dev/tests/shared/InMemoryProjectDataStore.test.mjs‎

Lines changed: 0 additions & 147 deletions
This file was deleted.

‎dev/workspace/zips/PR_26180_OWNER_022-resolve-remaining-src-dependencies_delta.zip‎

4.18 KB
Binary file not shown.

0 commit comments

Comments
 (0)