Added option to query whether a metadatum is known, and only emit warning if it is, but could not be created

Author: TimHeldmann

graph/include/metadata/MetaData.h

@@ -30,7 +30,7 @@ class MCGManager;
  *  A class *must* implement a  static constexpr const char *key that contains the class
  *  name as a string. This is used for registration in the MetaData field of the CgNode.
  */
-template <class CRTPBase>
+template <class CRTPBase=void>
 class MetaDataFactory {
  public:
   template <class... T>
@@ -64,6 +64,22 @@ class MetaDataFactory {
 
   friend CRTPBase;
 
+  /**
+ * Checks whether a metadatas key is registered
+ *
+ * @param metadataKey the key of the metadat to search for
+ * @return true if the key is known
+ */
+  static bool isRegistered(const std::string& metadataKey) {
+    for (const auto& [registeredMetadataName, _] : data()) {
+      if (registeredMetadataName == metadataKey)
+        return true;
+    }
+    return false;
+  }
+
+
+
  private:
   class Key {
     Key() = default;

graph/src/io/VersionFourMCGReader.cpp

@@ -178,7 +178,10 @@ std::unique_ptr<metacg::Callgraph> metacg::io::VersionFourMCGReader::read() {
           if (auto md = metacg::MetaData::create<>(mdKey, mdValJ, strToNode); md) {
             cg->addEdgeMetaData({nodeData.nodeId, calleeNode->getId()}, std::move(md));
           } else {
-              errConsole->debug("Could not create edge metadata of type {} for edge {} to {}", mdKey, nodeData.nodeId, calleeNode->getId());
+            if (MetaDataFactory<>::isRegistered(mdKey)) {
+              errConsole->warn("Could not create edge metadata of type {} for edge {} to {}", mdKey, nodeData.nodeId,
+                                calleeNode->getId());
+            }
             if (failedMetadataCb) {
               (*failedMetadataCb)(nodeData.nodeId, mdKey, mdValJ);
             }
@@ -193,7 +196,9 @@ std::unique_ptr<metacg::Callgraph> metacg::io::VersionFourMCGReader::read() {
       if (auto md = metacg::MetaData::create<>(mdKey, mdVal, strToNode); md) {
         node->addMetaData(std::move(md));
       } else {
-          errConsole->debug("Could not create metadata of type {} for node {}", mdKey, node->getFunctionName());
+        if (MetaDataFactory<>::isRegistered(mdKey)) {
+          errConsole->warn("Could not create metadata of type {} for node {}", mdKey, node->getFunctionName());
+        }
         if (failedMetadataCb) {
           (*failedMetadataCb)(node->getId(), mdKey, mdVal);
         }
@@ -209,7 +214,9 @@ std::unique_ptr<metacg::Callgraph> metacg::io::VersionFourMCGReader::read() {
     if (auto md = metacg::MetaData::create<>(mdKey, mdValJ, strToNode); md) {
       cg->addMetaData(std::move(md));
     } else {
-        errConsole->debug("Could not create global metadata of type {}", mdKey);
+      if (MetaDataFactory<>::isRegistered(mdKey)) {
+        errConsole->warn("Could not create global metadata of type {}", mdKey);
+      }
       if (failedMetadataCb) {
         (*failedMetadataCb)(std::nullopt, mdKey, mdValJ);
       }