Fix 실시간 환율 정보 api 수정 (#121)

- /exchange/live api 1개에서 12개의 통화 한꺼번에 보내주는 것으로 수정

Author: bagjuna

src/main/java/org/scoula/domain/exchange/controller/ExchangeRateController.java

@@ -81,25 +81,14 @@ public SuccessResponse<List<ExchangeMonthlyResponse>> calculateExchangeMonthlyGr
 		);
 	}
 
-	/**
-	 * 단일 통화 환율 조회
-	 *
-	 * @param currency 통화 코드 (USD, JPY 등)
-	 * @return 환율 정보
-	 */
 	@ApiOperation(
 		value = "실시간 환율 조회",
 		notes = "특정 통화에 대한 실시간 환율 정보를 조회합니다. "
-				+ "예시: /exchange/USD, /exchange/EUR 등"
+			+ "예시: /exchange/USD, /exchange/EUR 등"
 	)
-	@GetMapping("/live/{currency}")
-	public SuccessResponse<ExchangeLiveResponse> getExchangeRate(HttpServletRequest request,@PathVariable String currency) {
-
-		ExchangeLiveResponse latestExchangeRate = exchangeRateQuickService.getLatestExchangeRate(request,
-			currency.toUpperCase());
-
-		return SuccessResponse.ok(latestExchangeRate);
-
+	@GetMapping("/live")
+	public SuccessResponse<List<ExchangeLiveResponse>> getExchangeRate(HttpServletRequest request) {
+		return SuccessResponse.ok(exchangeRateQuickService.getLatestExchangeRate(request));
 	}
 
 

src/main/java/org/scoula/domain/exchange/dto/response/ExchangeConcurrencyList.java

@@ -0,0 +1,8 @@
+package org.scoula.domain.exchange.dto.response;
+
+import java.math.BigDecimal;
+
+public class ExchangeConcurrencyList {
+	private String cuncurrency;
+	private BigDecimal exchangeRate;
+}

src/main/java/org/scoula/domain/exchange/dto/response/ExchangeLiveResponse.java

@@ -1,10 +1,21 @@
 package org.scoula.domain.exchange.dto.response;
 
+import java.math.BigDecimal;
+
+import io.swagger.annotations.ApiModel;
+import io.swagger.annotations.ApiModelProperty;
 import lombok.AllArgsConstructor;
+import lombok.Builder;
 import lombok.Data;
 
-@AllArgsConstructor
 @Data
+@Builder
+@AllArgsConstructor
+@ApiModel(description = "실시간 환율 응답 DTO")
 public class ExchangeLiveResponse {
-	public String text;
+	@ApiModelProperty(value = "환율 통황", example = "USD")
+	private String currency;
+	@ApiModelProperty(value = "환율 값", example = "1300.50")
+	private BigDecimal exchangeRate;
+
 }

src/main/java/org/scoula/domain/exchange/mapper/ExchangeRateMapper.java

@@ -2,6 +2,7 @@
 
 import java.util.List;
 
+import org.scoula.domain.exchange.dto.response.ExchangeLiveResponse;
 import org.scoula.domain.exchange.entity.ExchangeRate;
 import org.apache.ibatis.annotations.Param;
 
@@ -33,7 +34,6 @@ ExchangeRate findByBankAndTargetCurrencyAndType(
      * 최신 환율 조회 (가장 최근 날짜)
      */
     List<ExchangeRate> findLatestRates(
-        @Param("targetCurrency") String targetCurrency,
         @Param("type") String type
     );
 
@@ -45,4 +45,9 @@ ExchangeRate findUsdExchangeRate(
         @Param("bankName") String bankName
     );
 
+    /**
+     * 실시간 환율 조회
+     * @return 실시간 환율 리스트
+     */
+    List<ExchangeLiveResponse> getExchangeLiveList();
 }

src/main/java/org/scoula/domain/exchange/service/ExchangeRateQuickService.java

@@ -1,5 +1,7 @@
 package org.scoula.domain.exchange.service;
 
+import java.util.List;
+
 import javax.servlet.http.HttpServletRequest;
 
 import org.scoula.domain.exchange.dto.request.ExchangeBankRequest;
@@ -16,5 +18,5 @@ public interface ExchangeRateQuickService {
 
 	ExchangeQuickResponse calculateExchangeQuick(ExchangeQuickRequest request, HttpServletRequest httpServletRequest);
 
-	ExchangeLiveResponse getLatestExchangeRate(HttpServletRequest request,String upperCase);
+	List<ExchangeLiveResponse> getLatestExchangeRate(HttpServletRequest request);
 }

src/main/java/org/scoula/domain/exchange/service/ExchangeRateQuickServiceImpl.java

@@ -1,8 +1,5 @@
 package org.scoula.domain.exchange.service;
 
-import static org.scoula.domain.member.exception.MemberErrorCode.*;
-import static org.scoula.domain.wallet.exception.WalletErrorCode.*;
-
 import java.math.BigDecimal;
 import java.math.RoundingMode;
 import java.text.DecimalFormat;
@@ -13,7 +10,6 @@
 
 import javax.servlet.http.HttpServletRequest;
 
-import org.scoula.domain.account.exception.AccountErrorCode;
 import org.scoula.domain.exchange.dto.request.ExchangeQuickRequest;
 import org.scoula.domain.exchange.dto.response.ExchangeLiveResponse;
 import org.scoula.domain.exchange.dto.response.exchangeResponse.BankRateInfo;
@@ -222,12 +218,12 @@ public ExchangeQuickResponse calculateExchangeQuick(ExchangeQuickRequest request
 	}
 
 	@Override
-	public ExchangeLiveResponse getLatestExchangeRate(HttpServletRequest request, String upperCase) {
+	public List<ExchangeLiveResponse> getLatestExchangeRate(HttpServletRequest request) {
 
 		// 기준 통화(KRW)에서 목표 통화로의 환율 조회
-		ExchangeRate baseRate = exchangeRateMapper.findLatestExchangeRate("하나은행", "BASE", upperCase);
+		List<ExchangeLiveResponse> baseExchangeRates = exchangeRateMapper.getExchangeLiveList();
 
-		if (baseRate == null) {
+		if (baseExchangeRates.isEmpty()) {
 			throw new CustomException(ExchangeErrorCode.EXCHANGE_NOT_FOUND, LogLevel.WARNING, null,
 				Common.builder().deviceInfo(request.getHeader("host-agent"))
 					.srcIp(request.getRemoteAddr())
@@ -237,15 +233,13 @@ public ExchangeLiveResponse getLatestExchangeRate(HttpServletRequest request, St
 					.build());
 		}
 
-		BigDecimal exchangeValue = baseRate.getExchangeValue();
-		String formattedRate = rateFormatter.format(exchangeValue);
-
-		if (upperCase.equals("JPY") || upperCase.equals("VND")) {
-			formattedRate = String.format("%s %s (100)", formattedRate, upperCase);
-		} else {
-			formattedRate = String.format("%s %s", formattedRate, upperCase);
+		for (ExchangeLiveResponse baseExchangeRate : baseExchangeRates) {
+			// 환율값 소수 2자리에서 반올림
+			baseExchangeRate.setExchangeRate(
+				baseExchangeRate.getExchangeRate().setScale(2, RoundingMode.HALF_UP));
 		}
-		return new ExchangeLiveResponse(formattedRate);
+
+		 return baseExchangeRates;
 	}
 
 	/**

src/main/resources/org/scoula/domain/exchange/mapper/ExchangeRateMapper.xml

@@ -68,7 +68,7 @@
           AND exchange_date = (
             SELECT MAX(exchange_date)
             FROM exchange_rate
-            WHERE target_exchange = #{targetCurrency} AND type = #{type}
+            WHERE type = BASE
         )
         ORDER BY exchange_value ASC
     </select>
@@ -85,4 +85,40 @@
             LIMIT 1
     </select>
 
+    <!-- 방법 3: JOIN 사용 (성능 최적화) -->
+    <select id="getExchangeLiveList" resultType="org.scoula.domain.exchange.dto.response.ExchangeLiveResponse">
+        SELECT e1.target_exchange AS currency,
+               e1.exchange_value AS exchangeRate
+        FROM exchange_rate e1
+                 INNER JOIN (
+            SELECT target_exchange,
+                   MAX(created_at) as max_created_at
+            FROM exchange_rate
+            WHERE base_exchange = 'KRW'
+              AND bank_name = '국민은행'
+              AND type = 'BASE'
+              AND target_exchange IN ('USD', 'JPY', 'EUR', 'GBP', 'CAD', 'HKD',
+                                      'CNY', 'THB', 'IDR', 'VND', 'RUB', 'MYR')
+            GROUP BY target_exchange
+        ) e2 ON e1.target_exchange = e2.target_exchange
+            AND e1.created_at = e2.max_created_at
+        WHERE e1.base_exchange = 'KRW'
+          AND e1.bank_name = '국민은행'
+          AND e1.type = 'BASE'
+        ORDER BY CASE e1.target_exchange
+                     WHEN 'USD' THEN 1
+                     WHEN 'JPY' THEN 2
+                     WHEN 'EUR' THEN 3
+                     WHEN 'GBP' THEN 4
+                     WHEN 'CAD' THEN 5
+                     WHEN 'HKD' THEN 6
+                     WHEN 'CNY' THEN 7
+                     WHEN 'THB' THEN 8
+                     WHEN 'IDR' THEN 9
+                     WHEN 'VND' THEN 10
+                     WHEN 'RUB' THEN 11
+                     WHEN 'MYR' THEN 12
+                     END
+    </select>
+
 </mapper>