Skip to content

Commit 24473b8

Browse files
committed
Ensure proper formatting when no upper age boundary.
1 parent 91551ab commit 24473b8

2 files changed

Lines changed: 8 additions & 3 deletions

File tree

src/palace/manager/celery/tasks/generate_inventory_and_hold_reports.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -437,7 +437,10 @@ def inventory_report_query() -> Select:
437437
),
438438
literal_column("''"),
439439
),
440-
(target_age_upper_raw.is_(None), cast(target_age_lower_adj, String)),
440+
(
441+
target_age_upper_raw.is_(None),
442+
func.concat(cast(target_age_lower_adj, String), "-"),
443+
),
441444
(target_age_lower_raw.is_(None), cast(target_age_upper_adj, String)),
442445
(
443446
target_age_lower_adj == target_age_upper_adj,

tests/manager/celery/tasks/test_generate_inventory_and_hold_reports.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,8 @@ def test_generate_report(
330330
collection=collection,
331331
genre="genre_z",
332332
)
333-
work2.target_age = tuple_to_numericrange((6, 8))
333+
# No upper bound: formats as "18-" per report specification
334+
work2.target_age = tuple_to_numericrange((18, None))
334335

335336
licensepool_no_licenses_owned = db.licensepool(
336337
edition=edition2,
@@ -595,7 +596,8 @@ def store_stream_mock(
595596
assert book2_row["published_date"] == "2020-10-05"
596597
assert book2_row["audience"] == "Adult" # Default audience
597598
assert book2_row["genres"] == "genre_z"
598-
assert book2_row["target_age"] == "6-8"
599+
# No upper bound formats as "{lower}-"
600+
assert book2_row["target_age"] == "18-"
599601
assert book2_row["format"] == edition.BOOK_MEDIUM
600602
assert book2_row["data_source"] == data_source
601603
assert book2_row["collection_name"] == collection_name

0 commit comments

Comments
 (0)