Attempt to improve notification handling on Android 10 (PP-3631).

Author: io7m

README-CHANGES.xml

@@ -1012,8 +1012,14 @@
         </c:change>
       </c:changes>
     </c:release>
-    <c:release date="2026-02-03T12:33:36+00:00" is-open="true" ticket-system="org.lyrasis.jira" version="1.25.0">
-      <c:changes/>
+    <c:release date="2026-02-03T13:29:02+00:00" is-open="true" ticket-system="org.lyrasis.jira" version="1.25.0">
+      <c:changes>
+        <c:change date="2026-02-03T13:29:02+00:00" summary="Attempt to allow notifications on Android 10.">
+          <c:tickets>
+            <c:ticket id="PP-3631"/>
+          </c:tickets>
+        </c:change>
+      </c:changes>
     </c:release>
   </c:releases>
   <c:ticket-systems>

palace-notifications/src/main/java/NotificationChannelInfo.kt

@@ -1,3 +1,7 @@
 package org.nypl.simplified.notifications
 
-class NotificationChannelInfo(val id: String, val name: String, val description: String)
+data class NotificationChannelInfo(
+  val id: String,
+  val name: String,
+  val description: String
+)

palace-notifications/src/main/java/NotificationsService.kt

@@ -3,7 +3,6 @@ package org.nypl.simplified.notifications
 import android.app.NotificationChannel
 import android.app.NotificationManager
 import android.content.Context
-import android.os.Build
 import org.nypl.simplified.profiles.api.ProfileNoneCurrentException
 import org.nypl.simplified.profiles.controller.api.ProfilesControllerType
 import org.slf4j.LoggerFactory
@@ -19,40 +18,47 @@ class NotificationsService(
     LoggerFactory.getLogger(NotificationsService::class.java)
 
   init {
-    createNotificationChannels()
+    this.createNotificationChannels()
 
     try {
       httpCalls.registerFCMTokenForProfileAccounts(profilesController.profileCurrent())
-    } catch (exception: ProfileNoneCurrentException) {
-      logger.error("No profile to register FCM token")
+    } catch (_: ProfileNoneCurrentException) {
+      this.logger.error("No profile to register FCM token")
     }
   }
 
   private fun createNotificationChannels() {
-    if (Build.VERSION.SDK_INT < Build.VERSION_CODES.O) {
+    this.logger.debug("Creating notification channels.")
+
+    val notificationManager =
+      this.context.getSystemService(Context.NOTIFICATION_SERVICE)
+        as? NotificationManager
+
+    if (notificationManager == null) {
+      this.logger.warn("No system notification manager is available.")
       return
     }
 
-    val notificationManager = context.getSystemService(Context.NOTIFICATION_SERVICE) as?
-      NotificationManager ?: return
-
     // delete possible usages for the old notifications channel
-    notificationManager.deleteNotificationChannel(notificationResources.notificationChannelNameOld)
-
-    // there's no harm on constantly creating notification channels
-    notificationResources.notificationChannels.forEach { channel ->
-      this.logger.debug("Creating notification channel: {}", channel)
-
-      notificationManager.createNotificationChannel(
-        NotificationChannel(
-          channel.id,
-          channel.name,
-          NotificationManager.IMPORTANCE_DEFAULT
-        ).apply {
-          description = channel.description
-          enableVibration(true)
-        }
-      )
+    notificationManager.deleteNotificationChannel(this.notificationResources.notificationChannelNameOld)
+
+    for (channelDescription in this.notificationResources.notificationChannels) {
+      this.logger.debug("Creating notification channel: {}", channelDescription)
+
+      try {
+        val channelInfo =
+          NotificationChannel(
+            channelDescription.id,
+            channelDescription.name,
+            NotificationManager.IMPORTANCE_DEFAULT
+          )
+
+        channelInfo.description = channelDescription.description
+        channelInfo.enableVibration(true)
+        notificationManager.createNotificationChannel(channelInfo)
+      } catch (e: Throwable) {
+        this.logger.debug("Failed to create notification channel {}: ", channelDescription.id, e)
+      }
     }
   }
 }

palace-ui/src/main/java/org/nypl/simplified/ui/main/MainLogging.kt

@@ -132,7 +132,7 @@ object MainLogging {
     logbackLevel("org.nypl.simplified.books.covers.BookCoverGenerator", Level.ERROR)
     logbackLevel("org.nypl.simplified.books.covers.BookCoverProvider", Level.ERROR)
     logbackLevel("org.nypl.simplified.files.FileLocking", Level.ERROR)
-    logbackLevel("org.nypl.simplified.notifications.NotificationsService", Level.ERROR)
+    logbackLevel("org.nypl.simplified.notifications.NotificationsService", Level.DEBUG)
     logbackLevel("org.sqlite.core.NativeDB", Level.ERROR)
   }
 

palace-ui/src/main/java/org/nypl/simplified/ui/main/MainNotifications.kt

@@ -3,6 +3,7 @@ package org.nypl.simplified.ui.main
 import android.app.Activity
 import android.content.Intent
 import android.content.pm.PackageManager
+import android.os.Build
 import android.provider.Settings
 import androidx.core.content.ContextCompat
 
@@ -36,11 +37,20 @@ object MainNotifications {
         "android.permission.FOREGROUND_SERVICE",
       ) == PackageManager.PERMISSION_GRANTED
 
+    /*
+     * The FOREGROUND_SERVICE_MEDIA_PLAYBACK permission is required on API 34 and up.
+     * If we're on an earlier version of Android, we just pretend that it's allowed.
+     */
+
     val foregroundMediaOk =
-      ContextCompat.checkSelfPermission(
-        activity,
-        "android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK",
-      ) == PackageManager.PERMISSION_GRANTED
+      if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
+        ContextCompat.checkSelfPermission(
+          activity,
+          "android.permission.FOREGROUND_SERVICE_MEDIA_PLAYBACK",
+        ) == PackageManager.PERMISSION_GRANTED
+      } else {
+        true
+      }
 
     return notificationsOk && foregroundOk && foregroundMediaOk
   }