Skip to content

Inconsistent _prev type: sets vs tuples #3

Description

@Terminay

_create_child converts prev to a tuple (line 44), but several methods pass {self} (a set) instead of (self,) (a tuple).
This works by accident but is inconsistent:
exp, log, sigmoid, softmax, relu, tanh, leaky_relu, and gelu all use sets, while __add__, __sub__, __mul__, __truediv__, __pow__, __matmul__, and __neg__ use tuples.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions