EntityEffect:Get/SetVarData

[TaigaTreant]

EntityEffects seem to have a vardata array of 4 values, similar to a lot of other classes. While this is utilized for a number of things for a number of different effects, this is most notable for seemingly being where tearflags are kept for effects that store and use them (there even seems to be a dedicated function for setting tearflags on effects that uses this exact array). As tearflags are a pretty important thing and generally pretty hard to work with as is for effect entities, it would be very worthwhile to expose this vardata.

[namishere]

hasn't been exposed because pointers also get loaded into that space. indev has [Get/Set/Add/Clear/Has]AquariusTearFlags that only works for EffectVariant.PLAYER_CREEP_HOLYWATER_TRAIL effects

[TaigaTreant]

Would probably be good to expand that to other effects that use them then (like brimstone balls, chain lightning and tech dots).

[namishere]

hmm.
okay, i see a couple ways of going forward:

• make a bunch of duplicate but distinctly named functions that allow accessing vardata while filtering by Variant
• rename current function into [Get/Set]VarData, and
  1. expand the filter to encapsulate other variants
  2. invert filter to exclude timer variant
  3. remove filter, add a marker to timer EntityEffects either in EntityPlus or some padding in the struct that the functions check for and cancel the operation

[ConnorForan]

Can probably just rename the Aquarius functions to TearFlags and document how they only work for a very specific subset of effects (ie, list them)

Since the aquarius functions have not been included in a proper release we are under no obligation to not rename it

[ConnorForan]

I honestly didn't know that other effects stored TearFlags here

[TaigaTreant]

I agree, makes them more straightforward to use for the average user as well.

[TaigaTreant]

Just learned today cause I was trying to figure how to get the brimstone ball to have homing. I honestly thought it was just aquarius til now

[namishere]

i may still look into implementing that marker byte, can probably hook CreateTimer for that (need to get ghidra back up and running though, wiped with new os)

[ConnorForan]

The TearFlags will additionally be accessible for BRIMSTONE_BALL, TECH_DOT, and CHAIN_LIGHTNING

Are there any others known that use tearflags? (Ocular Rift doesn't, it calls GetTearHitParams)