Description
Some refactoring improvements for CardputerKeyboard.cpp were identified during code review but deferred for future work.
Remaining Items
The following items from the code review should be addressed:
Convert static local state to instance members: The processKeyboard() method uses static local booleans (shift_pressed, sym_pressed, cap_toggle, cap_toggle_armed) which should be converted to instance member variables in the CardputerKeyboard class. This ensures state is properly tied to the object instance.
Context
Note
Most suggestions from the review were already applied. This issue tracks the remaining items for future implementation.
Description
Some refactoring improvements for
CardputerKeyboard.cppwere identified during code review but deferred for future work.Remaining Items
The following items from the code review should be addressed:
Convert static local state to instance members: The
processKeyboard()method uses static local booleans (shift_pressed,sym_pressed,cap_toggle,cap_toggle_armed) which should be converted to instance member variables in theCardputerKeyboardclass. This ensures state is properly tied to the object instance.Context
Boards/M5stackCardputerAdv/Source/devices/CardputerKeyboard.cppNote
Most suggestions from the review were already applied. This issue tracks the remaining items for future implementation.