[Hotfix] Copy assignment operator reference to local object error fix (#109)

Author: ddbaptiste

src/internals/markov_internals.hpp

@@ -40,11 +40,10 @@ class MarkovImpl : public virtual Markov {
     }
 
     MarkovImpl &operator=(const MarkovImpl &other) {
-        MarkovImpl temp(GetLoggerName());
-
-        temp.SetTransitions(other.GetTransitions());
-        temp.SetState(other.GetState());
-        return temp;
+        _logger_name = other.GetLoggerName();
+        this->SetTransitions(other.GetTransitions());
+        this->SetState(other.GetState());
+        return *this;
     }
 
     void SetState(const Eigen::VectorXd &state_vector) override {
@@ -74,7 +73,7 @@ class MarkovImpl : public virtual Markov {
     std::string GetLoggerName() const override { return _logger_name; }
 
 private:
-    const std::string _logger_name;
+    std::string _logger_name;
     Eigen::VectorXd _state;
     std::vector<transition> _transitions = {};
     std::map<int, stamper> _stamper_functions;
@@ -121,4 +120,4 @@ class MarkovImpl : public virtual Markov {
 };
 } // namespace respond
 
-#endif // RESPOND_MARKOVINTERNALS_HPP_
+#endif // RESPOND_MARKOVINTERNALS_HPP_