Snapshot-naming collisions in async method that verifies multiple snapshots

[N-Olbert]

Describe the bug
Within a single async method, using multiple snapshots with different names does not work.

To Reproduce

[TestMethod]
public async Task TestFoo()
{
    var something = new Foo();
    var fullName1 = Snapshot.FullName(new SnapshotNameExtension("GetFoo"));
    var fullName2 = Snapshot.FullName(new SnapshotNameExtension("GetBar"));

    something.GetFoo().MatchSnapshot(fullName1);
    something.GetBar().MatchSnapshot(fullName2);  // BOOM - fails since fullname 2 is identical to fullName1

}

Expected behavior
Two different snapshots should be created and verified.

Desktop (please complete the following information):

• OS: Windows 10
• Version 22H2

Additional context
Using MSTest

The problem is that the entire snapshot-naming info is cached in an AsyncLocal, therfore the second Snapshot.FullName has no effect since this cache is already initialized:
https://github.com/SwissLife-OSS/snapshooter/blob/94f9c77703a05e0d03b02aba9adb68d655fab820/src/Snapshooter.MSTest/Snapshot.cs#L15C5-L17C75

[N-Olbert]

It works if you do it like that:

[TestMethod]
public async Task TestFoo()
{
    var something = new Foo();
    var fullName1 = Snapshot.FullName(new SnapshotNameExtension("GetFoo"));
    something.GetFoo().MatchSnapshot(fullName1);

    var fullName2 = Snapshot.FullName(new SnapshotNameExtension("GetBar"));
    something.GetBar().MatchSnapshot(fullName2); 

}

... still odd behaviour in my opinion

[garcipat]

In your example i would make an array with the two items in it and a snapshot afterwards, that si way easier to maintain.

Having two snapshots in one test is a bit of a smell for me that the test is testing two things. But thats my opinion.

If you have a Theory (multiple test cases you go through, you also have to go with something like @N-Olbert showed with using the SnapshotNameExtension.