Download screen and emailed document filename is not updated after changing the conditions that set it through the review screen

[KelizaMcGuire]

Describe the bug
In the MLH Divorce interview, (once the user has reached the download screen for the first time) the Judgment of Divorce filename does not update after adding children or removing all children through the review screen.

The title of the document will be correct when opening it in a new tab from the download screen, and the document itself will be correct. However, the filename on the download screen and on the file that is emailed to the user will still be the original filename that was determined when the user first reached the download screen.

This bundle uses Bates page numbering, and it is the only conditionally named bundle in the interview.

See code setting filename and title from documents.yml in repo:

objects:
  - judgment_and_addenda_bundle: ALDocumentBundle.using(elements=[
      judgment_ccmlh412,
      judgment_ccmlh413,
      judgment_addendum_personal_property_and_debt,
      judgment_addendum_vehicles_1_to_4,
      judgment_addendum_vehicles_5_to_8,
      judgment_addendum_vehicles_9_to_12,
      judgment_addendum_real_property_1_to_2,
      judgment_addendum_real_property_3_to_4,
      judgment_addendum_real_property_5_to_6,
      judgment_addendum_real_property_7_to_8,
      judgment_addendum_real_property_9_to_10,
      judgment_addendum_pensions,
      judgment_addendum_income_tax,
      judgment_addendum_parenting_time,
      judgment_overflow_addendum
      ], filename="Judgment of Divorce with Children CC-MLH-413" if there_are_marital_children else "Judgment of Divorce without Children CC-MLH-412", title="Judgment of Divorce with Children CC-MLH-413" if there_are_marital_children else "Judgment of Divorce without Children CC-MLH-412", enabled=True, add_page_numbers=True, page_number_area="BOTTOM_LEFT", page_number_digits=2, page_number_font_size=10, page_number_offset_horizontal=40, page_number_offset_vertical=25, page_number_prefix="Page ")

To Reproduce
Steps to reproduce the behavior:

1. Complete the Judgment of Divorce interview (or the complaint) with or without children.
2. On the download screen, note the name of the Judgment of Divorce (last file) and the title that appears when opened in browser.
3. Either add children (if you said no children originally) or remove all children (if you added them originally) through the review screen.
4. Click resume.
5. On the download screen, note the filename of the Judgment of Divorce and the title that appears when opened in browser.
6. The download screen (and emailed documents) will show the old filename, while the title will show the correct updated name.

Expected behavior
Ideally, the filename on the download screen and emailed documents should update to match the filename that is assigned. In this case, it depends on whether or not there are children.

Screenshots
First download screen, no children:

After adding children throught the review screen:

Version Information (should be in your.docassemble.server/updatepackage:

• Docassemble Version: Unsure, but @ekressmiller should know.
• AssemblyLine Version: 5.4.1

[franko-c]

two separate staleness issues compound here.

bundle.filename is set via .using(filename="..." if there_are_marital_children else "...") — that expression is evaluated once as a Python literal when the objects: block runs and stored in docassemble's interview state as a plain string. when there_are_marital_children changes via the review screen, the stored string is never re-evaluated.

as_pdf() in ALDocumentBundle (al_document.py ~line 1709) makes this worse: the combined PDF is cached in self.cache.final on first call. every subsequent call hits that cache and returns the old DAFile object — with pdf.filename already set to the original bundle filename. get_cacheable_documents() then sets download_filename from str(doc.filename) at line 2060, which is also the stale attribute value.

enabled_documents(refresh=True) correctly reconsidered which judgment form to include (hence the PDF content is right), but nothing analogous exists for filename or title on the bundle itself.

two fix paths:

interview-level — undefine the bundle's filename (and title) before the user hits the download screen again. the review screen's event handler or the download question block can do this:

undefine("judgment_and_addenda_bundle.filename", "judgment_and_addenda_bundle.title")

combined with setting filename in a reconsidered code block instead of inside .using().

library-level — in ALDocumentBundle.as_pdf(), when refresh=True, mirror what is_enabled does for the enabled attribute: delete self.filename (so docassemble can recompute it on the next access) and clear the self.cache.{key} entry so the PDF is regenerated with the new filename:

if refresh and hasattr(self.cache, safe_key):
    if hasattr(self, "filename"):
        del self.filename
    if hasattr(self, "title"):
        del self.title
    delattr(self.cache, safe_key)

this should also apply in as_zip() around line 1821, where self.cache.{zip_key} is checked.

the Bates numbering being present (adding a watermark pass on top of concatenation) doesn't change the root cause, but it does mean the cached PDF took longer to generate — so clearing self.cache.final will cost more on the next render for this particular bundle.