From 02d9130d0bed73d079e32014673e3c3e300e68ca Mon Sep 17 00:00:00 2001
From: Stuart Meeks <stuart.meeks@stuartmeeks.net>
Date: Mon, 8 Jun 2026 09:53:49 +0000
Subject: [PATCH 1/2] Fix installed builds crashing on launch: ship app
 resources.pri
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Published (Velopack) builds crashed at startup with a XamlParseException
on the first app-specific page (ShellPage), while running from Visual
Studio worked. Root cause: the self-contained Release publish shipped no
app resources.pri.

Two compounding defects:
- `dotnet publish` generated the app's PRI into bin but never copied it to
  the publish output, because the WinUI PRI/packaging targets weren't
  imported. `EnableMsixTooling=true` (required for unpackaged self-contained
  WinUI per the Windows App SDK docs) wires in the copy-to-publish step.
- An unpackaged app's runtime auto-loads only `resources.pri` from the exe
  directory, but the build names the app PRI after the assembly
  (Snipdeck.App.pri), which the runtime never loads. `ProjectPriFileName`
  pins the conventional name. See microsoft-ui-xaml#10856.

Verified on the Win11 build host: with both set, the published
self-contained Release build (R2R on, exact CI config) ships resources.pri
and launches to the shell instead of crashing.

Also surface HRESULT and Exception.Data on every logged exception in
CrashLog — the XamlParseException's RestrictedDescription in Data is what
pinpointed the missing resource (Message was only "XAML parsing failed").

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 CHANGELOG.md                         |  6 ++++++
 src/Snipdeck.App/CrashLog.cs         | 15 +++++++++------
 src/Snipdeck.App/Snipdeck.App.csproj | 12 ++++++++++++
 3 files changed, 27 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 62956ff..fa25b09 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- Installed (Velopack) builds crashed on launch with a blank window — the published app
+  was missing its resource index (`resources.pri`), so the first screen failed with a
+  XAML parsing error. The published build now ships the app's resources correctly, and
+  launches as expected. Running from Visual Studio was unaffected.
+
 ## [1.0.2] - 2026-06-08
 
 ### Added
diff --git a/src/Snipdeck.App/CrashLog.cs b/src/Snipdeck.App/CrashLog.cs
index ef8962f..5a45bc1 100644
--- a/src/Snipdeck.App/CrashLog.cs
+++ b/src/Snipdeck.App/CrashLog.cs
@@ -1,5 +1,4 @@
 using System.Globalization;
-using System.Runtime.InteropServices;
 using System.Text;
 
 using Microsoft.Extensions.DependencyInjection;
@@ -88,11 +87,8 @@ private static void AppendException(StringBuilder sb, Exception ex, int depth)
             var indent = new string(' ', depth * 2);
 
             _ = sb.Append(indent).Append("Type: ").AppendLine(ex.GetType().FullName ?? ex.GetType().Name);
-            if (ex is COMException)
-            {
-                _ = sb.Append(indent).Append("HRESULT: 0x")
-                      .AppendLine(ex.HResult.ToString("X8", CultureInfo.InvariantCulture));
-            }
+            _ = sb.Append(indent).Append("HRESULT: 0x")
+                  .AppendLine(ex.HResult.ToString("X8", CultureInfo.InvariantCulture));
             _ = sb.Append(indent).Append("Message: ").AppendLine(ex.Message);
             if (!string.IsNullOrEmpty(ex.Source))
             {
@@ -106,6 +102,13 @@ private static void AppendException(StringBuilder sb, Exception ex, int depth)
                     _ = sb.Append(indent).Append("  ").AppendLine(line.TrimEnd('\r'));
                 }
             }
+            // WinRT-sourced exceptions (e.g. XamlParseException) carry the real
+            // detail here, not in Message — the RestrictedDescription is what
+            // names the missing resource / failing element.
+            foreach (System.Collections.DictionaryEntry entry in ex.Data)
+            {
+                _ = sb.Append(indent).Append("Data[").Append(entry.Key).Append("]: ").AppendLine(entry.Value?.ToString());
+            }
             if (ex.InnerException is not null)
             {
                 _ = sb.Append(indent).AppendLine("Inner:");
diff --git a/src/Snipdeck.App/Snipdeck.App.csproj b/src/Snipdeck.App/Snipdeck.App.csproj
index 00c2205..96f9068 100644
--- a/src/Snipdeck.App/Snipdeck.App.csproj
+++ b/src/Snipdeck.App/Snipdeck.App.csproj
@@ -11,6 +11,18 @@
 		<WinUISDKReferences>false</WinUISDKReferences>
 		<WindowsPackageType>None</WindowsPackageType>
 		<WindowsAppSDKSelfContained>true</WindowsAppSDKSelfContained>
+		<!-- Imports the WinUI PRI/packaging targets. Without it the app's PRI is
+		     generated into bin but never copied to the publish output, so a
+		     published build ships with no app resources.pri at all. Required for
+		     unpackaged self-contained WinUI per the Windows App SDK docs. -->
+		<EnableMsixTooling>true</EnableMsixTooling>
+		<!-- Unpackaged + self-contained WinUI auto-loads only "resources.pri" from
+		     the exe directory; the build otherwise names the app's PRI after the
+		     assembly (Snipdeck.App.pri), which the runtime never loads — so every
+		     ms-appx:/// lookup for the app's own XAML/Assets fails and the first
+		     app-specific page throws XamlParseException ("Cannot locate resource").
+		     Forcing the conventional name fixes it. See microsoft-ui-xaml#10856. -->
+		<ProjectPriFileName>resources.pri</ProjectPriFileName>
 		<Platforms>x64</Platforms>
 		<!-- Use the explicit entry point in Program.cs instead of the
 		     XAML-generated Main, so Velopack + single-instance run first.

From 1cc15201b1c40bae6b07d8558c240e4351981a1e Mon Sep 17 00:00:00 2001
From: Stuart Meeks <stuart.meeks@stuartmeeks.net>
Date: Mon, 8 Jun 2026 09:58:20 +0000
Subject: [PATCH 2/2] Fix tray menu items doing nothing: use Command, not Click
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The tray "Show Snipdeck" and "Exit" menu items did nothing when clicked.
In an unpackaged app H.NotifyIcon's default context menu is a native Win32
PopupMenu, built from the MenuFlyout by invoking each item's Command — it
does not raise the WinUI routed Click event the items were wired to. (The
left-click action worked because it already used a Command.)

Drive the items via the existing RelayCommand instead of Click handlers.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 CHANGELOG.md                                  |  2 ++
 .../Services/HNotifyIconTrayService.cs        | 34 ++++++++++---------
 2 files changed, 20 insertions(+), 16 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fa25b09..ea87481 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   was missing its resource index (`resources.pri`), so the first screen failed with a
   XAML parsing error. The published build now ships the app's resources correctly, and
   launches as expected. Running from Visual Studio was unaffected.
+- The system tray menu's "Show Snipdeck" and "Exit" entries did nothing when clicked.
+  They now work.
 
 ## [1.0.2] - 2026-06-08
 
diff --git a/src/Snipdeck.App/Services/HNotifyIconTrayService.cs b/src/Snipdeck.App/Services/HNotifyIconTrayService.cs
index e2e639e..290e03e 100644
--- a/src/Snipdeck.App/Services/HNotifyIconTrayService.cs
+++ b/src/Snipdeck.App/Services/HNotifyIconTrayService.cs
@@ -57,38 +57,40 @@ public void Dispose()
 
         private MenuFlyout BuildContextMenu()
         {
-            var showItem = new MenuFlyoutItem { Text = "Show Snipdeck" };
-            showItem.Click += OnShowItemClick;
-
-            var exitItem = new MenuFlyoutItem { Text = "Exit" };
-            exitItem.Click += OnExitItemClick;
-
+            // In an unpackaged app H.NotifyIcon's default context menu is a native
+            // Win32 PopupMenu, built from this MenuFlyout by invoking each item's
+            // Command — it does NOT raise the WinUI routed Click event. So the menu
+            // items must use Command (like LeftClickCommand does), not Click, or
+            // they silently do nothing.
             return new MenuFlyout
             {
                 Items =
                 {
-                    showItem,
+                    new MenuFlyoutItem
+                    {
+                        Text = "Show Snipdeck",
+                        Command = new RelayCommand(RaiseShowRequested),
+                    },
                     new MenuFlyoutSeparator(),
-                    exitItem,
+                    new MenuFlyoutItem
+                    {
+                        Text = "Exit",
+                        Command = new RelayCommand(RaiseExitRequested),
+                    },
                 },
             };
         }
 
-        private void OnShowItemClick(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)
+        private void RaiseShowRequested()
         {
-            RaiseShowRequested();
+            ShowRequested?.Invoke(this, EventArgs.Empty);
         }
 
-        private void OnExitItemClick(object sender, Microsoft.UI.Xaml.RoutedEventArgs e)
+        private void RaiseExitRequested()
         {
             ExitRequested?.Invoke(this, EventArgs.Empty);
         }
 
-        private void RaiseShowRequested()
-        {
-            ShowRequested?.Invoke(this, EventArgs.Empty);
-        }
-
         private sealed partial class RelayCommand(Action execute) : System.Windows.Input.ICommand
         {
 #pragma warning disable CS0067 // 'CanExecuteChanged' is never used — relay never changes.