fix: search resilience — embed error fallback, consistent obs_type handling

Author: Stranmor

crates/cli/src/commands/search.rs

@@ -21,12 +21,11 @@ pub(crate) async fn run_search(
         )))
     };
     let search = SearchService::new(storage, embeddings, None, config.dedup_threshold);
-    let obs_type_lower = obs_type.map(|t| t.to_lowercase());
     let results = search
         .smart_search(
             Some(&query),
             project.as_deref(),
-            obs_type_lower.as_deref(),
+            obs_type.as_deref(),
             None,
             None,
             limit,

crates/service/src/search_service/hybrid_ops.rs

@@ -133,7 +133,12 @@ impl SearchService {
                     )
                 })
                 .await;
-            return self.with_cb(result);
+            match self.with_cb(result) {
+                Ok(results) => return Ok(results),
+                Err(e) => {
+                    tracing::warn!(error = %e, "hybrid_search_v2_with_filters failed, falling back to text-only search_with_filters");
+                }
+            }
         }
         let result = self
             .storage
@@ -196,14 +201,19 @@ impl SearchService {
         }
     }
 
-    /// Try to embed the query. Returns `Ok(None)` if embeddings are not configured.
-    /// Returns `Ok(Some(vec))` on success, `Err` on embedding failure.
+    /// Try to embed the query. Returns `Ok(None)` if embeddings are not configured
+    /// or if embedding generation fails (graceful degradation to text-only search).
     async fn try_embed(&self, query: &str) -> Result<Option<Vec<f32>>, ServiceError> {
         let Some(ref emb) = self.embeddings else {
             return Ok(None);
         };
-        let vec = embed_query(emb, query).await?;
-        Ok(Some(vec))
+        match embed_query(emb, query).await {
+            Ok(vec) => Ok(Some(vec)),
+            Err(e) => {
+                tracing::warn!(error = %e, "Embedding generation failed, falling back to text-only search");
+                Ok(None)
+            }
+        }
     }
 }