Skip to content

Commit c767f06

Browse files
TaranDahlStarkku
authored andcommitted
Fixed the issue where non-repairer units needed sensors to attack cloaked friendly units (Phobos-developers#2010)
<!-- Please manually add a label named [No Documentation Needed] if this change should not be mentioned in documentation, what's new and no credit needs to be given. If the changes are solely made to the documentation, please set the target branch to the pull request named "Weekly Regular Documentation Revisions", rather than the repository's existing branches. --> # Conflicts: # docs/Fixed-or-Improved-Logics.md # docs/Whats-New.md # src/Misc/Hooks.BugFixes.cpp
1 parent ec49fc2 commit c767f06

4 files changed

Lines changed: 8 additions & 1 deletion

File tree

CREDITS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -655,6 +655,7 @@ This page lists all the individual contributions to the project by their author.
655655
- Fix an issue where the vanilla script ignores jumpjets
656656
- CellSpread in cylinder shape
657657
- CellSpread damage check if victim is in air or on floor
658+
- Fix an issue where non-repairer units needed sensors to attack cloaked friendly units
658659
- **solar-III (凤九歌)**
659660
- Target scanning delay customization (documentation)
660661
- Skip target scanning function calling for unarmed technos (documentation)

docs/Fixed-or-Improved-Logics.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@ This page describes all ingame logics that are fixed or improved in Phobos witho
275275
- Fixed MPDebug timer displaying when debug's visibility is off.
276276
- Fixed the issue that units will goto farest location if target is closer than `MinimumRange`.
277277
- Purely visual animations and particles are no longer included in frame CRC generation and are thus exempt from any sync checks between players in multiplayer games.
278+
- Fixed the issue where non-repairer units needed sensors to attack cloaked friendly units.
278279

279280
## Fixes / interactions with other extensions
280281

docs/Whats-New.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,7 @@ Vanilla fixes:
512512
- Fixed MPDebug timer displaying when debug's visibility is off (by 11EJDE11)
513513
- Fixed the issue that units will goto farest location if target is closer than `MinimumRange` (by NetsuNegi)
514514
- Purely visual animations and particles excluded from sync checks (by Starkku)
515+
- Fixed the issue where non-repairer units needed sensors to attack cloaked friendly units (by TaranDahl)
515516
516517
Phobos fixes:
517518
- Fixed the bug that `AllowAirstrike=no` cannot completely prevent air strikes from being launched against it (by NetsuNegi)

src/Misc/Hooks.BugFixes.cpp

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
#include <AircraftClass.h>
1+
#include <AircraftClass.h>
22
#include <AircraftTrackerClass.h>
33
#include <AnimClass.h>
44
#include <BuildingClass.h>
@@ -2900,3 +2900,7 @@ DEFINE_HOOK(0x4440B0, BuildingClass_KickOutUnit_CloningFacility, 0x6)
29002900

29012901
return ContinueIn;
29022902
}
2903+
2904+
2905+
// Fixed the issue where non-repairer units needed sensors to attack cloaked friendly units.
2906+
DEFINE_JUMP(LJMP, 0x6FC278, 0x6FC289);

0 commit comments

Comments
 (0)