STAC-23457 Filter out stackpacks from backup listing

Author: rb3ckers

cmd/settings/list.go

@@ -240,6 +240,11 @@ func getBackupListFromLocalBucket(appCtx *app.Context) ([]BackupFileInfo, error)
 
 	filteredObjects := s3client.FilterMultipartBackupObjects(result.Contents, isMultiPartArchive)
 
+	filteredObjects, err = s3client.FilterByPrefixAndRegex(filteredObjects, "", backupFileNameRegex)
+	if err != nil {
+		return nil, fmt.Errorf("failed to filter objects: %w", err)
+	}
+
 	var backups []BackupFileInfo
 	for _, obj := range filteredObjects {
 		backups = append(backups, BackupFileInfo{

internal/clients/s3/filter_test.go

@@ -479,6 +479,19 @@ func TestFilterByPrefixAndRegex(t *testing.T) { //nolint:funlen // Table-driven
 			expectedKeys: []string{},
 			expectError:  false,
 		},
+		{
+			name: "excludes stackpacks backups when listing settings local bucket (empty prefix)",
+			objects: []Object{
+				{Key: "sts-backup-20240101.sty", Size: 1000, LastModified: now},
+				{Key: "sts-backup-20240101.sty.stackpacks.zip", Size: 500, LastModified: now},
+				{Key: "sts-backup-20240102.sty", Size: 2000, LastModified: now},
+				{Key: "sts-backup-20240102.sty.stackpacks.zip", Size: 300, LastModified: now},
+			},
+			prefix:       "",
+			pattern:      `^sts-backup-.*\.sty$`,
+			expectedKeys: []string{"sts-backup-20240101.sty", "sts-backup-20240102.sty"},
+			expectError:  false,
+		},
 		{
 			name: "filters with complex regex pattern",
 			objects: []Object{