-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathconfigure_test.go
More file actions
592 lines (550 loc) · 14.8 KB
/
configure_test.go
File metadata and controls
592 lines (550 loc) · 14.8 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
package elasticsearch
import (
"context"
"fmt"
"testing"
"github.com/stackvista/stackstate-backup-cli/internal/clients/elasticsearch"
"github.com/stackvista/stackstate-backup-cli/internal/foundation/config"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/kubernetes/fake"
)
// mockESClientForConfigure is a mock for testing configure command
type mockESClientForConfigure struct {
deleteRepoErr error
configureRepoErr error
configureSLMErr error
repoDeleted bool
repoConfigured bool
slmConfigured bool
lastRepoConfig map[string]string
lastSLMConfig map[string]interface{}
}
func (m *mockESClientForConfigure) DeleteSnapshotRepository(_ string) error {
if m.deleteRepoErr != nil {
return m.deleteRepoErr
}
m.repoDeleted = true
return nil
}
func (m *mockESClientForConfigure) ConfigureSnapshotRepository(name, bucket, endpoint, basePath, accessKey, secretKey string) error {
if m.configureRepoErr != nil {
return m.configureRepoErr
}
m.repoConfigured = true
m.lastRepoConfig = map[string]string{
"name": name,
"bucket": bucket,
"endpoint": endpoint,
"basePath": basePath,
"accessKey": accessKey,
"secretKey": secretKey,
}
return nil
}
func (m *mockESClientForConfigure) ConfigureSLMPolicy(name, schedule, snapshotName, repository, indices, expireAfter string, minCount, maxCount int) error {
if m.configureSLMErr != nil {
return m.configureSLMErr
}
m.slmConfigured = true
m.lastSLMConfig = map[string]interface{}{
"name": name,
"schedule": schedule,
"snapshotName": snapshotName,
"repository": repository,
"indices": indices,
"expireAfter": expireAfter,
"minCount": minCount,
"maxCount": maxCount,
}
return nil
}
func (m *mockESClientForConfigure) ListSnapshots(_ string) ([]elasticsearch.Snapshot, error) {
return nil, fmt.Errorf("not implemented")
}
func (m *mockESClientForConfigure) GetSnapshot(_, _ string) (*elasticsearch.Snapshot, error) {
return nil, fmt.Errorf("not implemented")
}
func (m *mockESClientForConfigure) ListIndices(_ string) ([]string, error) {
return nil, fmt.Errorf("not implemented")
}
func (m *mockESClientForConfigure) ListIndicesDetailed() ([]elasticsearch.IndexInfo, error) {
return nil, fmt.Errorf("not implemented")
}
func (m *mockESClientForConfigure) DeleteIndex(_ string) error {
return fmt.Errorf("not implemented")
}
func (m *mockESClientForConfigure) IndexExists(_ string) (bool, error) {
return false, fmt.Errorf("not implemented")
}
func (m *mockESClientForConfigure) RestoreSnapshot(_, _, _ string, _ bool) error {
return fmt.Errorf("not implemented")
}
func (m *mockESClientForConfigure) RolloverDatastream(_ string) error {
return fmt.Errorf("not implemented")
}
// TestConfigureCmd_Unit tests the command structure
func TestConfigureCmd_Unit(t *testing.T) {
flags := config.NewCLIGlobalFlags()
flags.Namespace = testNamespace
flags.ConfigMapName = testConfigMapName
flags.SecretName = testSecretName
cmd := configureCmd(flags)
// Test command metadata
assert.Equal(t, "configure", cmd.Use)
assert.Equal(t, "Configure Elasticsearch snapshot repository and SLM policy", cmd.Short)
assert.NotEmpty(t, cmd.Long)
assert.NotNil(t, cmd.Run)
}
// TestConfigureCmd_Integration tests the integration with Kubernetes client
//
//nolint:funlen
func TestConfigureCmd_Integration(t *testing.T) {
if testing.Short() {
t.Skip("skipping integration test in short mode")
}
tests := []struct {
name string
configData string
secretData string
expectError bool
errorContains string
}{
{
name: "successful configuration with complete data",
configData: `
elasticsearch:
service:
name: elasticsearch-master
port: 9200
restore:
scaleDownLabelSelector: app=test
indexPrefix: sts_
datastreamIndexPrefix: sts_k8s_logs
datastreamName: sts_k8s_logs
indicesPattern: "sts_*"
repository: backup-repo
snapshotRepository:
name: backup-repo
bucket: backups
endpoint: minio:9000
basepath: snapshots
accessKey: test-key
secretKey: test-secret
slm:
name: daily
schedule: "0 1 * * *"
snapshotTemplateName: "<snap-{now/d}>"
repository: backup-repo
indices: "sts_*"
retentionExpireAfter: 30d
retentionMinCount: 5
retentionMaxCount: 50
` + minimalMinioStackgraphConfig,
secretData: "",
expectError: false,
},
{
name: "missing credentials in config",
configData: `
elasticsearch:
service:
name: elasticsearch-master
port: 9200
restore:
scaleDownLabelSelector: app=test
indexPrefix: sts_
datastreamIndexPrefix: sts_k8s_logs
datastreamName: sts_k8s_logs
indicesPattern: "sts_*"
repository: backup-repo
snapshotRepository:
name: backup-repo
bucket: backups
endpoint: minio:9000
basepath: snapshots
accessKey: ""
secretKey: ""
slm:
name: daily
schedule: "0 1 * * *"
snapshotTemplateName: "<snap-{now/d}>"
repository: backup-repo
indices: "sts_*"
retentionExpireAfter: 30d
retentionMinCount: 5
retentionMaxCount: 50
` + minimalMinioStackgraphConfig,
secretData: `
elasticsearch:
snapshotRepository:
accessKey: secret-key
secretKey: secret-value
minio:
accessKey: secret-minio-key
secretKey: secret-minio-value
`,
expectError: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
fakeClient := fake.NewClientset()
// Create ConfigMap
cm := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: testConfigMapName,
Namespace: testNamespace,
},
Data: map[string]string{
"config": tt.configData,
},
}
_, err := fakeClient.CoreV1().ConfigMaps(testNamespace).Create(
context.Background(), cm, metav1.CreateOptions{},
)
require.NoError(t, err)
// Create Secret if provided
if tt.secretData != "" {
secret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: testSecretName,
Namespace: testNamespace,
},
Data: map[string][]byte{
"config": []byte(tt.secretData),
},
}
_, err := fakeClient.CoreV1().Secrets(testNamespace).Create(
context.Background(), secret, metav1.CreateOptions{},
)
require.NoError(t, err)
}
// Test that config loading works
secretName := ""
if tt.secretData != "" {
secretName = testSecretName
}
cfg, err := config.LoadConfig(fakeClient, testNamespace, testConfigMapName, secretName)
if tt.expectError {
assert.Error(t, err)
if tt.errorContains != "" {
assert.Contains(t, err.Error(), tt.errorContains)
}
} else {
require.NoError(t, err)
assert.NotNil(t, cfg)
assert.NotEmpty(t, cfg.Elasticsearch.SnapshotRepository.AccessKey)
assert.NotEmpty(t, cfg.Elasticsearch.SnapshotRepository.SecretKey)
}
})
}
}
// TestConfigureCmd_StorageIntegration tests the integration with Kubernetes client using StorageConfig
//
//nolint:funlen
func TestConfigureCmd_StorageIntegration(t *testing.T) {
if testing.Short() {
t.Skip("skipping integration test in short mode")
}
tests := []struct {
name string
configData string
secretData string
expectError bool
errorContains string
}{
{
name: "successful configuration with complete data (storage mode)",
configData: `
elasticsearch:
service:
name: elasticsearch-master
port: 9200
localPortForwardPort: 9200
restore:
scaleDownLabelSelector: app=test
indexPrefix: sts_
datastreamIndexPrefix: sts_k8s_logs
datastreamName: sts_k8s_logs
indicesPattern: "sts_*"
repository: backup-repo
snapshotRepository:
name: backup-repo
bucket: backups
endpoint: storage:9000
basepath: snapshots
accessKey: test-key
secretKey: test-secret
slm:
name: daily
schedule: "0 1 * * *"
snapshotTemplateName: "<snap-{now/d}>"
repository: backup-repo
indices: "sts_*"
retentionExpireAfter: 30d
retentionMinCount: 5
retentionMaxCount: 50
` + minimalStorageStackgraphConfig,
secretData: "",
expectError: false,
},
{
name: "missing credentials in config with secret override (storage mode)",
configData: `
elasticsearch:
service:
name: elasticsearch-master
port: 9200
localPortForwardPort: 9200
restore:
scaleDownLabelSelector: app=test
indexPrefix: sts_
datastreamIndexPrefix: sts_k8s_logs
datastreamName: sts_k8s_logs
indicesPattern: "sts_*"
repository: backup-repo
snapshotRepository:
name: backup-repo
bucket: backups
endpoint: storage:9000
basepath: snapshots
accessKey: ""
secretKey: ""
slm:
name: daily
schedule: "0 1 * * *"
snapshotTemplateName: "<snap-{now/d}>"
repository: backup-repo
indices: "sts_*"
retentionExpireAfter: 30d
retentionMinCount: 5
retentionMaxCount: 50
` + minimalStorageStackgraphConfig,
secretData: `
elasticsearch:
snapshotRepository:
accessKey: secret-key
secretKey: secret-value
storage:
accessKey: secret-storage-key
secretKey: secret-storage-value
`,
expectError: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
fakeClient := fake.NewClientset()
// Create ConfigMap
cm := &corev1.ConfigMap{
ObjectMeta: metav1.ObjectMeta{
Name: testConfigMapName,
Namespace: testNamespace,
},
Data: map[string]string{
"config": tt.configData,
},
}
_, err := fakeClient.CoreV1().ConfigMaps(testNamespace).Create(
context.Background(), cm, metav1.CreateOptions{},
)
require.NoError(t, err)
// Create Secret if provided
if tt.secretData != "" {
secret := &corev1.Secret{
ObjectMeta: metav1.ObjectMeta{
Name: testSecretName,
Namespace: testNamespace,
},
Data: map[string][]byte{
"config": []byte(tt.secretData),
},
}
_, err := fakeClient.CoreV1().Secrets(testNamespace).Create(
context.Background(), secret, metav1.CreateOptions{},
)
require.NoError(t, err)
}
// Test that config loading works
secretName := ""
if tt.secretData != "" {
secretName = testSecretName
}
cfg, err := config.LoadConfig(fakeClient, testNamespace, testConfigMapName, secretName)
if tt.expectError {
assert.Error(t, err)
if tt.errorContains != "" {
assert.Contains(t, err.Error(), tt.errorContains)
}
} else {
require.NoError(t, err)
assert.NotNil(t, cfg)
// Verify storage mode
assert.False(t, cfg.IsLegacyMode())
assert.True(t, cfg.GlobalBackupEnabled())
assert.NotEmpty(t, cfg.Elasticsearch.SnapshotRepository.AccessKey)
assert.NotEmpty(t, cfg.Elasticsearch.SnapshotRepository.SecretKey)
}
})
}
}
// TestMockESClientForConfigure demonstrates mock usage for configure
//
//nolint:funlen // Table-driven test
func TestMockESClientForConfigure(t *testing.T) {
tests := []struct {
name string
deleteRepoErr error
configureRepoErr error
configureSLMErr error
expectDeleteOK bool
expectRepoOK bool
expectSLMOK bool
}{
{
name: "successful configuration",
deleteRepoErr: nil,
configureRepoErr: nil,
configureSLMErr: nil,
expectDeleteOK: true,
expectRepoOK: true,
expectSLMOK: true,
},
{
name: "repository deletion fails",
deleteRepoErr: fmt.Errorf("repository deletion failed"),
configureRepoErr: nil,
configureSLMErr: nil,
expectDeleteOK: false,
expectRepoOK: false,
expectSLMOK: false,
},
{
name: "repository configuration fails",
deleteRepoErr: nil,
configureRepoErr: fmt.Errorf("repository creation failed"),
configureSLMErr: nil,
expectDeleteOK: true,
expectRepoOK: false,
expectSLMOK: false,
},
{
name: "SLM configuration fails",
deleteRepoErr: nil,
configureRepoErr: nil,
configureSLMErr: fmt.Errorf("SLM policy creation failed"),
expectDeleteOK: true,
expectRepoOK: true,
expectSLMOK: false,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
mockClient := &mockESClientForConfigure{
deleteRepoErr: tt.deleteRepoErr,
configureRepoErr: tt.configureRepoErr,
configureSLMErr: tt.configureSLMErr,
}
// Delete repository
err := mockClient.DeleteSnapshotRepository("backup-repo")
if tt.expectDeleteOK {
assert.NoError(t, err)
assert.True(t, mockClient.repoDeleted)
} else {
assert.Error(t, err)
return // Don't test configure if delete failed
}
// Configure repository
err = mockClient.ConfigureSnapshotRepository(
"backup-repo",
"backup-bucket",
"minio:9000",
"snapshots",
"access-key",
"secret-key",
)
if tt.expectRepoOK {
assert.NoError(t, err)
assert.True(t, mockClient.repoConfigured)
assert.Equal(t, "backup-repo", mockClient.lastRepoConfig["name"])
assert.Equal(t, "backup-bucket", mockClient.lastRepoConfig["bucket"])
} else {
assert.Error(t, err)
return // Don't test SLM if repo failed
}
// Configure SLM policy
err = mockClient.ConfigureSLMPolicy(
"daily-snapshots",
"0 1 * * *",
"<snap-{now/d}>",
"backup-repo",
"sts_*",
"30d",
5,
50,
)
if tt.expectSLMOK {
assert.NoError(t, err)
assert.True(t, mockClient.slmConfigured)
assert.Equal(t, "daily-snapshots", mockClient.lastSLMConfig["name"])
assert.Equal(t, "0 1 * * *", mockClient.lastSLMConfig["schedule"])
assert.Equal(t, 5, mockClient.lastSLMConfig["minCount"])
assert.Equal(t, 50, mockClient.lastSLMConfig["maxCount"])
} else {
assert.Error(t, err)
}
})
}
}
// TestConfigureValidation tests configuration validation
func TestConfigureValidation(t *testing.T) {
tests := []struct {
name string
accessKey string
secretKey string
expectError bool
errorContains string
}{
{
name: "valid credentials",
accessKey: "test-key",
secretKey: "test-secret",
expectError: false,
},
{
name: "missing access key",
accessKey: "",
secretKey: "test-secret",
expectError: true,
errorContains: "accessKey and secretKey are required",
},
{
name: "missing secret key",
accessKey: "test-key",
secretKey: "",
expectError: true,
errorContains: "accessKey and secretKey are required",
},
{
name: "missing both credentials",
accessKey: "",
secretKey: "",
expectError: true,
errorContains: "accessKey and secretKey are required",
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Simulate validation logic from runConfigure
hasError := tt.accessKey == "" || tt.secretKey == ""
if tt.expectError {
assert.True(t, hasError)
} else {
assert.False(t, hasError)
}
})
}
}