You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The tests around connection state are brittle. Additionally, it is hard to force server-initiated behaviours to occur, for example unsolicited out-of-band messages, connection faults, timeouts, etc.
Suggestion: move these tests to use the toy server, extending it to support the features we need. It doesn't need to be hosted in Kestrel or hosted on the socket layer - with minor work, a new in-proc spoof connection can be arranged via the pre-existing tunnel API.
This will be especially valuable for server maintenance events. There is already a MovedToSameEndpointTests that shows this concept being used with a specific -MOVED scenario, but:
this can be extended greatly
there is no need to use the actual socket layer - we can use the tunnel API to attach the two ends directly
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
The tests around connection state are brittle. Additionally, it is hard to force server-initiated behaviours to occur, for example unsolicited out-of-band messages, connection faults, timeouts, etc.
Suggestion: move these tests to use the toy server, extending it to support the features we need. It doesn't need to be hosted in Kestrel or hosted on the socket layer - with minor work, a new in-proc spoof connection can be arranged via the pre-existing tunnel API.
This will be especially valuable for server maintenance events. There is already a
MovedToSameEndpointTeststhat shows this concept being used with a specific-MOVEDscenario, but:Effort: non-trivial, but manageable
All reactions