diff --git a/cmd/list-app-federated-identity-credentials.go b/cmd/list-app-federated-identity-credentials.go index 5c93ed2..2dc0e18 100644 --- a/cmd/list-app-federated-identity-credentials.go +++ b/cmd/list-app-federated-identity-credentials.go @@ -84,7 +84,7 @@ func listAppFICs(ctx context.Context, client client.AzureClient, apps <-chan azu for item := range client.ListAzureADAppFICs(ctx, app.Data.Id, params) { if item.Error != nil { log.Error(item.Error, "unable to continue processing federated identity credentials for this app", "appId", app.Data.AppId) - } else { + } else { appFIC := models.AppFIC{ FIC: item.Ok, AppId: app.Data.AppId, @@ -95,7 +95,7 @@ func listAppFICs(ctx context.Context, client client.AzureClient, apps <-chan azu } } - if data.FICs != nil { + if data.FICs != nil { if ok := pipeline.Send(ctx.Done(), out, NewAzureWrapper( enums.KindAZFederatedIdentityCredential, data, diff --git a/models/azure/user-signinactivity.go b/models/azure/user-signinactivity.go index f83be98..5b754f4 100644 --- a/models/azure/user-signinactivity.go +++ b/models/azure/user-signinactivity.go @@ -2,10 +2,10 @@ package azure // SignInActivity represents Microsoft Graph's `signInActivity` object returned on the user entity. type SignInActivity struct { - LastSignInDateTime *string `json:"lastSignInDateTime,omitempty"` - LastSignInRequestId *string `json:"lastSignInRequestId,omitempty"` - LastNonInteractiveSignInDateTime *string `json:"lastNonInteractiveSignInDateTime,omitempty"` - LastNonInteractiveSignInRequestId *string `json:"lastNonInteractiveSignInRequestId,omitempty"` - LastSuccessfulSignInDateTime *string `json:"lastSuccessfulSignInDateTime,omitempty"` - LastSuccessfulSignInRequestId *string `json:"lastSuccessfulSignInRequestId,omitempty"` + LastSignInDateTime string `json:"lastSignInDateTime,omitempty"` + LastSignInRequestId string `json:"lastSignInRequestId,omitempty"` + LastNonInteractiveSignInDateTime string `json:"lastNonInteractiveSignInDateTime,omitempty"` + LastNonInteractiveSignInRequestId string `json:"lastNonInteractiveSignInRequestId,omitempty"` + LastSuccessfulSignInDateTime string `json:"lastSuccessfulSignInDateTime,omitempty"` + LastSuccessfulSignInRequestId string `json:"lastSuccessfulSignInRequestId,omitempty"` } diff --git a/models/azure/user_test.go b/models/azure/user_test.go index 7750f23..88ab6b8 100644 --- a/models/azure/user_test.go +++ b/models/azure/user_test.go @@ -41,7 +41,7 @@ func TestUserUnmarshal_PopulatesLastSuccessfulSignInDateTimeFromSignInActivity(t t.Fatalf("unexpected unmarshal error: %v", err) } - if *u.SignInActivity.LastSuccessfulSignInDateTime != "2025-01-27T22:20:22Z" { - t.Fatalf("expected LastSuccessfulSignInDateTime to be populated, got %q", *u.SignInActivity.LastSuccessfulSignInDateTime) + if u.SignInActivity.LastSuccessfulSignInDateTime != "2025-01-27T22:20:22Z" { + t.Fatalf("expected LastSuccessfulSignInDateTime to be populated, got %q", u.SignInActivity.LastSuccessfulSignInDateTime) } }