AdvancedFileOutput: Fix race condition while flushing the buffer, fixes #99

Bungeefan · Bungeefan · commit a27ba42b59c4 · 2025-07-21T02:25:44.000+02:00
diff --git a/lib/src/outputs/advanced_file_output.dart b/lib/src/outputs/advanced_file_output.dart
@@ -221,9 +221,11 @@ class AdvancedFileOutput extends LogOutput {
       _sink?.writeln(fileFooter);
     }
 
-    await _sink?.flush();
-    await _sink?.close();
-    _sink = null; // Explicitly set null until assigned again
+    final sink = _sink;
+    _sink = null; // disable writing in flushBuffer
+
+    await sink?.flush();
+    await sink?.close();
   }
 
   Future<void> _deleteRotatedFiles() async {

Original file line number	Diff line number	Diff line change
`@@ -221,9 +221,11 @@ class AdvancedFileOutput extends LogOutput {`
`221`	`221`	`_sink?.writeln(fileFooter);`
`222`	`222`	`}`
`223`	`223`
`224`		`- await _sink?.flush();`
`225`		`- await _sink?.close();`
`226`		`- _sink = null; // Explicitly set null until assigned again`
	`224`	`+ final sink = _sink;`
	`225`	`+ _sink = null; // disable writing in flushBuffer`
	`226`	`+`
	`227`	`+ await sink?.flush();`
	`228`	`+ await sink?.close();`
`227`	`229`	`}`
`228`	`230`
`229`	`231`	`Future<void> _deleteRotatedFiles() async {`