From c0cb896c59ede5fd888dd011f7cbe5c3b735ebbb Mon Sep 17 00:00:00 2001 From: Sharon Stratsianis Date: Sun, 21 Jun 2026 13:47:28 +1000 Subject: [PATCH 1/4] change to new auth for menu --- src/mainPage/menu.ts | 40 ++++++++++++++++++++++++++++++---------- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/src/mainPage/menu.ts b/src/mainPage/menu.ts index b43be7a4..9a3cbdb8 100644 --- a/src/mainPage/menu.ts +++ b/src/mainPage/menu.ts @@ -59,7 +59,20 @@ const applyMenuCollapsedState = (navMenu: HTMLElement | null): void => { updateCollapseButtonPosition(navMenu, collapseBtn) } -const isLoggedIn = (): boolean => Boolean(authSession?.info?.isLoggedIn) +const refreshAuthStateFromSession = async (): Promise => { + try { + await authn.checkUser() + if (!authn.currentUser()) { + await authn.checkUser() + } + } catch (error) { + // Keep the menu responsive even if auth refresh is transiently unavailable. + } + + return Boolean(authn.currentUser()) +} + +const isLoggedIn = (): boolean => Boolean(authn.currentUser()) const setFooterVisibility = (loggedIn: boolean): void => { const footer = document.querySelector('solid-ui-footer') as HTMLElement | null @@ -343,6 +356,7 @@ export const createLeftSideMenu = async (subject: NamedNode, outliner: OutlineMa const menuToggle = document.getElementById('MenuToggleBtn') as HTMLElement | null const menuOverlay = document.getElementById('MenuOverlay') as HTMLElement | null const navMenuContent = document.getElementById('NavMenuContent') as HTMLElement | null + await refreshAuthStateFromSession() const closeMobileMenu = () => { if (!navMenu || !menuToggle || !menuOverlay) return @@ -446,19 +460,25 @@ export const createLeftSideMenu = async (subject: NamedNode, outliner: OutlineMa } authSession.events.on('login', () => { - updateMenuVisibility() - refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') - refreshMenuItems() + void refreshAuthStateFromSession().then(() => { + updateMenuVisibility() + refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') + void refreshMenuItems() + }) }) authSession.events.on('logout', () => { - updateMenuVisibility() - refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') - refreshMenuItems() + void refreshAuthStateFromSession().then(() => { + updateMenuVisibility() + refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') + void refreshMenuItems() + }) }) authSession.events.on('sessionRestore', () => { - updateMenuVisibility() - refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') - refreshMenuItems() + void refreshAuthStateFromSession().then(() => { + updateMenuVisibility() + refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') + void refreshMenuItems() + }) }) navMenuContent.dataset.authEventsBound = 'true' } From 5e5f8a2af50f78d0d1fe2058036582cd59b9e893 Mon Sep 17 00:00:00 2001 From: Sharon Stratsianis Date: Sun, 21 Jun 2026 13:57:56 +1000 Subject: [PATCH 2/4] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/mainPage/menu.ts | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/mainPage/menu.ts b/src/mainPage/menu.ts index 9a3cbdb8..881668d4 100644 --- a/src/mainPage/menu.ts +++ b/src/mainPage/menu.ts @@ -61,15 +61,12 @@ const applyMenuCollapsedState = (navMenu: HTMLElement | null): void => { const refreshAuthStateFromSession = async (): Promise => { try { - await authn.checkUser() - if (!authn.currentUser()) { - await authn.checkUser() - } - } catch (error) { + const webId = await authn.checkUser() + return Boolean(webId || authn.currentUser()) + } catch { // Keep the menu responsive even if auth refresh is transiently unavailable. + return Boolean(authn.currentUser()) } - - return Boolean(authn.currentUser()) } const isLoggedIn = (): boolean => Boolean(authn.currentUser()) From 4c4fd89aaba1b06317b5cfd9cf1bf51b92de67f6 Mon Sep 17 00:00:00 2001 From: Sharon Stratsianis Date: Sun, 21 Jun 2026 14:48:52 +1000 Subject: [PATCH 3/4] fix build issues --- src/mainPage/menu.ts | 33 +++++++++++++++------------------ 1 file changed, 15 insertions(+), 18 deletions(-) diff --git a/src/mainPage/menu.ts b/src/mainPage/menu.ts index 881668d4..c5d8989b 100644 --- a/src/mainPage/menu.ts +++ b/src/mainPage/menu.ts @@ -456,26 +456,23 @@ export const createLeftSideMenu = async (subject: NamedNode, outliner: OutlineMa await renderMenuItems(subject, outliner, navMenuContent) } - authSession.events.on('login', () => { - void refreshAuthStateFromSession().then(() => { - updateMenuVisibility() - refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') - void refreshMenuItems() - }) + authSession.events.on('login', async () => { + await refreshAuthStateFromSession() + updateMenuVisibility() + refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') + await refreshMenuItems() }) - authSession.events.on('logout', () => { - void refreshAuthStateFromSession().then(() => { - updateMenuVisibility() - refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') - void refreshMenuItems() - }) + authSession.events.on('logout', async () => { + await refreshAuthStateFromSession() + updateMenuVisibility() + refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') + await refreshMenuItems() }) - authSession.events.on('sessionRestore', () => { - void refreshAuthStateFromSession().then(() => { - updateMenuVisibility() - refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') - void refreshMenuItems() - }) + authSession.events.on('sessionRestore', async () => { + await refreshAuthStateFromSession() + updateMenuVisibility() + refreshMenu(outliner.context?.environment?.layout === 'mobile' ? 'mobile' : 'desktop') + await refreshMenuItems() }) navMenuContent.dataset.authEventsBound = 'true' } From 85180436813792cfdbccc8a5612b52d94433c0de Mon Sep 17 00:00:00 2001 From: Alain Bourgeois Date: Sun, 21 Jun 2026 10:00:43 +0200 Subject: [PATCH 4/4] 4.4.2-1 --- package-lock.json | 4 ++-- package.json | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/package-lock.json b/package-lock.json index 3e41d7a3..f5e2b7ae 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "solid-panes", - "version": "4.4.2-0", + "version": "4.4.2-1", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "solid-panes", - "version": "4.4.2-0", + "version": "4.4.2-1", "license": "MIT", "dependencies": { "@solid/better-simple-slideshow": "^0.1.0", diff --git a/package.json b/package.json index ed71faf5..b027f44a 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "solid-panes", - "version": "4.4.2-0", + "version": "4.4.2-1", "description": "Solid-compatible Panes: applets and views for the mashlib and databrowser", "main": "dist/index.js", "types": "dist/index.d.ts",