Problem
In #109, code was added to check for cycle-to-cycle convergence for an open-loop 0D model. To do so, it tracks cycle-to-cycle changes in mean pressure and flow at vessel caps, which seem to be limited to connections between vessels and boundary_conditions. For closed-loop model, there are no boundary_conditions, so the periodicity check does not work.
Solution
Modify the periodicity check to consider inlets and outlets of all vessels, regardless of if they are connected to boundary conditions.
Additional context
@mrp089 @menon-karthik was there a reason this periodicity check was originally limited to vessel-boundary_condition connections?
Code of Conduct
Problem
In #109, code was added to check for cycle-to-cycle convergence for an open-loop 0D model. To do so, it tracks cycle-to-cycle changes in mean pressure and flow at vessel caps, which seem to be limited to connections between
vesselsandboundary_conditions. For closed-loop model, there are noboundary_conditions, so the periodicity check does not work.Solution
Modify the periodicity check to consider inlets and outlets of all vessels, regardless of if they are connected to boundary conditions.
Additional context
@mrp089 @menon-karthik was there a reason this periodicity check was originally limited to
vessel-boundary_conditionconnections?Code of Conduct