From 18d14645495a9983e558b68d1d07aab929da9a6e Mon Sep 17 00:00:00 2001 From: Rodrigo Navarro Date: Wed, 18 Mar 2026 11:53:00 -0300 Subject: [PATCH] Avoid duplicating definition of ActiveRecord::Relation.destroy_all --- lib/tapioca/dsl/compilers/active_record_relations.rb | 2 +- spec/tapioca/dsl/compilers/active_record_relations_spec.rb | 6 ------ 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/tapioca/dsl/compilers/active_record_relations.rb b/lib/tapioca/dsl/compilers/active_record_relations.rb index 4ae17c780..968b870bf 100644 --- a/lib/tapioca/dsl/compilers/active_record_relations.rb +++ b/lib/tapioca/dsl/compilers/active_record_relations.rb @@ -612,7 +612,7 @@ def create_common_methods create_common_method( "destroy_all", return_type: "T::Array[#{constant_name}]", - ) + ) unless RELATION_METHODS.include? :destroy_all FINDER_METHODS.each do |method_name| case method_name diff --git a/spec/tapioca/dsl/compilers/active_record_relations_spec.rb b/spec/tapioca/dsl/compilers/active_record_relations_spec.rb index e7a0f3dbc..e23eb0367 100644 --- a/spec/tapioca/dsl/compilers/active_record_relations_spec.rb +++ b/spec/tapioca/dsl/compilers/active_record_relations_spec.rb @@ -147,9 +147,6 @@ def destroy(*records); end sig { returns(T::Array[::Post]) } def destroy_all; end - sig { returns(T::Array[::Post]) } - def destroy_all; end - sig { params(args: T.untyped).returns(T::Array[::Post]) } def destroy_by(*args); end @@ -854,9 +851,6 @@ def destroy(*records); end sig { returns(T::Array[::Post]) } def destroy_all; end - sig { returns(T::Array[::Post]) } - def destroy_all; end - sig { params(args: T.untyped).returns(T::Array[::Post]) } def destroy_by(*args); end