Replace outdated ActiveModel::Serializers by Panko::Serializer

Author: byroot

Gemfile

@@ -1,6 +1,7 @@
 source 'https://rubygems.org'
 
 gemspec
+gem 'panko_serializer', github: 'panko-serializer/panko_serializer'
 
 gem 'sqlite3'
 

Gemfile.lock

@@ -1,8 +1,14 @@
+GIT
+  remote: https://github.com/panko-serializer/panko_serializer.git
+  revision: 36f457528c2865585c32767847469ac20c60558b
+  specs:
+    panko_serializer (0.7.4)
+      oj (~> 3.10.0)
+
 PATH
   remote: .
   specs:
     shipit-engine (0.33.0)
-      active_model_serializers (~> 0.9.3)
       ansi_stream (~> 0.0.6)
       attr_encrypted (~> 3.1.0)
       autoprefixer-rails (~> 6.4.1)
@@ -15,6 +21,7 @@ PATH
       lodash-rails (~> 4.6.1)
       octokit (~> 4.15)
       omniauth-github (~> 1.4)
+      panko_serializer (~> 0.7.4)
       pubsubstub (~> 0.2.0)
       rails (~> 6.0.0)
       rails-timeago (~> 2.13.0)
@@ -69,9 +76,6 @@ GEM
       erubi (~> 1.4)
       rails-dom-testing (~> 2.0)
       rails-html-sanitizer (~> 1.1, >= 1.2.0)
-    active_model_serializers (0.9.8)
-      activemodel (>= 3.2)
-      concurrent-ruby (~> 1.0)
     activejob (6.0.3.5)
       activesupport (= 6.0.3.5)
       globalid (>= 0.3.6)
@@ -185,6 +189,7 @@ GEM
     octokit (4.20.0)
       faraday (>= 0.9)
       sawyer (~> 0.8.0, >= 0.5.3)
+    oj (3.10.18)
     omniauth (1.9.1)
       hashie (>= 3.4.6)
       rack (>= 1.6.2, < 3)
@@ -337,6 +342,7 @@ DEPENDENCIES
   mini_racer
   mocha
   mysql2
+  panko_serializer!
   pg
   pry
   rubocop

app/controllers/concerns/shipit/active_model_serializers_patch.rb

@@ -5,7 +5,7 @@ module Rendering
       private
 
       def render_resources(resources, options = {})
-        options[:json] = resources
+        options[:json] = Panko::ArraySerializer.new(resources, each_serializer: Serializer.for(resources)).to_json
         render(options)
       end
 
@@ -15,7 +15,8 @@ def render_resource(resource, options = {})
         elsif resource.errors.any?
           render(options.reverse_merge(status: :unprocessable_entity, json: { errors: resource.errors }))
         else
-          render(options.reverse_merge(json: resource))
+          serializer = Serializer.for(resource).new
+          render(options.reverse_merge(json: serializer.serialize(resource)))
         end
       end
     end

app/controllers/concerns/shipit/api/rendering.rb

@@ -10,7 +10,7 @@ def index
       end
 
       def show
-        render(json: hook)
+        render_resource(hook)
       end
 
       params do

app/controllers/shipit/api/hooks_controller.rb

@@ -48,7 +48,7 @@ def abort
     end
 
     def tail
-      render(json: TailTaskSerializer.new(task, context: { last_byte: params[:last_byte].to_i }))
+      render(json: TailTaskSerializer.new(context: { last_byte: params[:last_byte].to_i }).serialize(task))
     end
 
     def lookup

app/controllers/shipit/tasks_controller.rb

@@ -1,6 +1,12 @@
 # frozen_string_literal: true
 module Shipit
   class AnonymousUser
+    class << self
+      def attribute_aliases
+        {}.freeze
+      end
+    end
+
     def present?
       false
     end

app/models/shipit/anonymous_user.rb

@@ -101,8 +101,8 @@ def listening_event(event)
       def coerce_payload(payload)
         coerced_payload = payload.dup
         payload.each do |key, value|
-          if serializer = ActiveModel::Serializer.serializer_for(value)
-            coerced_payload[key] = serializer.new(value)
+          if serializer = Serializer.for(value)
+            coerced_payload[key] = serializer.new.serialize(value)
           end
         end
         coerced_payload.to_json

app/models/shipit/hook.rb

@@ -2,16 +2,13 @@
 module Shipit
   class CommitSerializer < ShortCommitSerializer
     include GithubUrlHelper
-    include ConditionalAttributes
 
-    has_one :author
-    has_one :committer
+    has_one :author, serializer: UserSerializer
+    has_one :committer, serializer: UserSerializer
 
     attributes :additions, :deletions, :authored_at, :committed_at, :html_url, :pull_request, :status, :deployed
 
-    def deployed
-      object.deployed?
-    end
+    aliases deployed?: :deployed
 
     def status
       object.status.state
@@ -22,14 +19,14 @@ def html_url
     end
 
     def pull_request
-      {
-        number: object.pull_request_number,
-        html_url: github_pull_request_url(object),
-      }
-    end
-
-    def include_pull_request?
-      object.pull_request?
+      if object.pull_request?
+        {
+          number: object.pull_request_number,
+          html_url: github_pull_request_url(object),
+        }
+      else
+        SKIP
+      end
     end
   end
 end