fix(🐛): prevent EXC_BAD_ACCESS in Promise destructor after runtime teardown

When async operations (e.g. fromURI image loads) complete after the JSI runtime has been torn down, the Promise destructor crashes with a null pointer dereference in jsi::Pointer::~Pointer(). This happens because resolve_ and reject_ (jsi::Function members) attempt to release their PointerValue through the now-invalid runtime.

The fix adds an explicit destructor that moves the jsi::Function members to the heap before implicit member destruction runs. After std::move, the member's internal ptr_ is null (per jsi::Pointer's move constructor), so implicit destruction safely skips the runtime access. The heap copies are intentionally leaked (~32 bytes per Promise) since there is no safe way to release JSI pointers without a valid runtime.

Author: tbrushwyler

packages/skia/cpp/jsi/JsiPromises.cpp

@@ -6,6 +6,15 @@ JsiPromises::Promise::Promise(jsi::Runtime &rt, jsi::Function resolve,
                               jsi::Function reject)
     : runtime_(rt), resolve_(std::move(resolve)), reject_(std::move(reject)) {}
 
+JsiPromises::Promise::~Promise() {
+  // Move JSI function pointers to the heap so the member destructors
+  // see ptr_==nullptr and skip the runtime access. The heap copies are
+  // intentionally leaked — there is no safe way to release JSI pointers
+  // when the runtime may already be torn down.
+  (void)new jsi::Function(std::move(resolve_));
+  (void)new jsi::Function(std::move(reject_));
+}
+
 void JsiPromises::Promise::resolve(const jsi::Value &result) {
   resolve_.call(runtime_, result);
 }

packages/skia/cpp/jsi/JsiPromises.h

@@ -31,6 +31,7 @@ class JsiPromises {
 public:
   struct Promise : public LongLivedObject {
     Promise(jsi::Runtime &rt, jsi::Function resolve, jsi::Function reject);
+    ~Promise();
 
     void resolve(const jsi::Value &result);
     void reject(const std::string &error);