-
Notifications
You must be signed in to change notification settings - Fork 250
Expand file tree
/
Copy pathpush.test.ts
More file actions
405 lines (346 loc) · 13.1 KB
/
push.test.ts
File metadata and controls
405 lines (346 loc) · 13.1 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
import {createOrSelectTheme, push, PushFlags} from './push.js'
import {PullFlags} from './pull.js'
import {setDevelopmentTheme} from './local-storage.js'
import {uploadTheme} from '../utilities/theme-uploader.js'
import {ensureThemeStore} from '../utilities/theme-store.js'
import {findOrSelectTheme} from '../utilities/theme-selector.js'
import {runThemeCheck} from '../commands/theme/check.js'
import {mountThemeFileSystem} from '../utilities/theme-fs.js'
import {buildTheme} from '@shopify/cli-kit/node/themes/factories'
import {test, describe, vi, expect, beforeEach} from 'vitest'
import {themeCreate, fetchTheme, themePublish} from '@shopify/cli-kit/node/themes/api'
import {ensureAuthenticatedThemes} from '@shopify/cli-kit/node/session'
import {
DEVELOPMENT_THEME_ROLE,
LIVE_THEME_ROLE,
UNPUBLISHED_THEME_ROLE,
promptThemeName,
} from '@shopify/cli-kit/node/themes/utils'
import {renderConfirmationPrompt, renderError} from '@shopify/cli-kit/node/ui'
import {AbortError} from '@shopify/cli-kit/node/error'
import {Severity, SourceCodeType} from '@shopify/theme-check-node'
import {outputResult} from '@shopify/cli-kit/node/output'
vi.mock('../utilities/theme-uploader.js')
vi.mock('../utilities/theme-store.js')
vi.mock('../utilities/theme-selector.js')
vi.mock('./local-storage.js')
vi.mock('../utilities/theme-listing.js')
vi.mock('@shopify/cli-kit/node/themes/utils')
vi.mock('@shopify/cli-kit/node/session')
vi.mock('@shopify/cli-kit/node/themes/api')
vi.mock('@shopify/cli-kit/node/ui')
vi.mock('../commands/theme/check.js')
vi.mock('@shopify/cli-kit/node/output')
vi.mock('../utilities/theme-fs.js')
const path = '/my-theme'
const defaultFlags: PullFlags = {
path,
development: false,
live: false,
nodelete: false,
only: [],
ignore: [],
force: false,
}
const adminSession = {token: '', storeFqdn: ''}
describe('push', () => {
beforeEach(() => {
vi.mocked(uploadTheme).mockReturnValue({
workPromise: Promise.resolve(),
uploadResults: new Map(),
renderThemeSyncProgress: () => Promise.resolve(),
})
vi.mocked(ensureThemeStore).mockReturnValue('example.myshopify.com')
vi.mocked(ensureAuthenticatedThemes).mockResolvedValue(adminSession)
vi.mocked(outputResult).mockReturnValue()
})
test('should call themePublish if publish flag is provided', async () => {
// Given
const theme = buildTheme({id: 1, name: 'Theme', role: 'development'})!
vi.mocked(findOrSelectTheme).mockResolvedValue(theme)
// When
await push({...defaultFlags, publish: true}, adminSession)
// Then
expect(themePublish).toHaveBeenCalledWith(theme.id, adminSession)
})
test('includes errors in JSON output when using --json flag', async () => {
// Given
const theme = buildTheme({id: 1, name: 'Theme', role: 'development'})!
vi.mocked(findOrSelectTheme).mockResolvedValue(theme)
const uploadResults = new Map()
uploadResults.set('assets/theme.css', {
success: false,
errors: {
asset: ['Invalid CSS syntax at line 42'],
},
})
uploadResults.set('layout/theme.liquid', {
success: false,
errors: {
asset: ['Missing endif tag'],
},
})
uploadResults.set('assets/valid.js', {
success: true,
})
vi.mocked(uploadTheme).mockReturnValue({
workPromise: Promise.resolve(),
uploadResults,
renderThemeSyncProgress: () => Promise.resolve(),
})
// When
await push({...defaultFlags, json: true}, adminSession)
// Then
expect(outputResult).toHaveBeenCalledWith(
JSON.stringify({
theme: {
id: 1,
name: 'Theme',
role: 'development',
shop: '',
editor_url: 'https:///admin/themes/1/editor',
preview_url: 'https://?preview_theme_id=1',
warning: "The theme 'Theme' was pushed with errors",
errors: {
'assets/theme.css': ['Invalid CSS syntax at line 42'],
'layout/theme.liquid': ['Missing endif tag'],
},
},
}),
)
})
describe('strict mode', () => {
beforeEach(() => {
const theme = buildTheme({id: 1, name: 'Theme', role: 'development'})!
vi.mocked(findOrSelectTheme).mockResolvedValue(theme)
})
test('skips theme check when strict mode is disabled', async () => {
// Given
const flags = {...defaultFlags, strict: false}
// When
await push(flags, adminSession)
// Then
expect(runThemeCheck).not.toHaveBeenCalled()
})
test('blocks push when errors exist', async () => {
// Given
vi.mocked(runThemeCheck).mockResolvedValue({
offenses: [
{
severity: Severity.ERROR,
message: 'error message',
type: SourceCodeType.LiquidHtml,
check: 'check',
uri: 'file:///path/to/file.liquid',
start: {index: 0, line: 1, character: 1},
end: {index: 1, line: 1, character: 1},
},
],
theme: [],
})
// When/Then
await expect(push({...defaultFlags, strict: true}, adminSession)).rejects.toThrow(AbortError)
})
test('blocks push when both warnings and errors exist', async () => {
// Given
vi.mocked(runThemeCheck).mockResolvedValue({
offenses: [
{
severity: Severity.WARNING,
message: 'warning message',
type: SourceCodeType.LiquidHtml,
check: 'check',
uri: 'file:///path/to/file.liquid',
start: {index: 0, line: 1, character: 1},
end: {index: 1, line: 1, character: 1},
},
{
severity: Severity.ERROR,
message: 'error message',
type: SourceCodeType.LiquidHtml,
check: 'check',
uri: 'file:///path/to/file.liquid',
start: {index: 0, line: 1, character: 1},
end: {index: 1, line: 1, character: 1},
},
],
theme: [],
})
// When/Then
await expect(push({...defaultFlags, strict: true}, adminSession)).rejects.toThrow(AbortError)
})
test('continues push when no offenses exist', async () => {
// Given
vi.mocked(runThemeCheck).mockResolvedValue({
offenses: [],
theme: [],
})
// When/Then
await expect(push({...defaultFlags, strict: true}, adminSession)).resolves.not.toThrow()
})
test('continues push when only warnings exist', async () => {
// Given
vi.mocked(runThemeCheck).mockResolvedValue({
offenses: [
{
severity: Severity.WARNING,
message: 'warning message',
check: 'check',
uri: 'file:///path/to/file.liquid',
type: SourceCodeType.LiquidHtml,
start: {index: 0, line: 1, character: 1},
end: {index: 1, line: 1, character: 1},
},
],
theme: [],
})
// When/Then
await expect(push({...defaultFlags, strict: true}, adminSession)).resolves.not.toThrow()
})
test('passes the --json flag to theme check as output format', async () => {
// Given
vi.mocked(runThemeCheck).mockResolvedValue({
offenses: [
{
severity: Severity.WARNING,
message: 'warning message',
check: 'check',
uri: 'file:///path/to/file.liquid',
type: SourceCodeType.LiquidHtml,
start: {index: 0, line: 1, character: 1},
end: {index: 1, line: 1, character: 1},
},
],
theme: [],
})
// When/Then
await push({...defaultFlags, strict: true, json: true}, adminSession)
expect(runThemeCheck).toHaveBeenCalledWith(path, 'json')
})
})
test('passes listing flag to file system when provided', async () => {
// Given
const theme = buildTheme({id: 1, name: 'Theme', role: 'development'})!
vi.mocked(findOrSelectTheme).mockResolvedValue(theme)
// When
await push({...defaultFlags, listing: 'my-preset'})
// Then
expect(mountThemeFileSystem).toHaveBeenCalledWith(
path,
expect.objectContaining({
listing: 'my-preset',
}),
)
})
})
describe('createOrSelectTheme', async () => {
test('creates unpublished theme when unpublished flag is provided', async () => {
// Given
vi.mocked(themeCreate).mockResolvedValue(buildTheme({id: 2, name: 'Theme', role: UNPUBLISHED_THEME_ROLE}))
vi.mocked(fetchTheme).mockResolvedValue(undefined)
const flags: PushFlags = {unpublished: true}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme).toMatchObject({role: UNPUBLISHED_THEME_ROLE})
expect(setDevelopmentTheme).not.toHaveBeenCalled()
})
test('creates development theme when development flag is provided', async () => {
// Given
vi.mocked(themeCreate).mockResolvedValue(buildTheme({id: 1, name: 'Theme', role: DEVELOPMENT_THEME_ROLE}))
vi.mocked(fetchTheme).mockResolvedValue(undefined)
const flags: PushFlags = {development: true}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme).toMatchObject({role: DEVELOPMENT_THEME_ROLE})
expect(setDevelopmentTheme).toHaveBeenCalled()
})
test('creates development theme when development and unpublished flags are provided', async () => {
// Given
vi.mocked(themeCreate).mockResolvedValue(buildTheme({id: 1, name: 'Theme', role: DEVELOPMENT_THEME_ROLE}))
vi.mocked(fetchTheme).mockResolvedValue(undefined)
const flags: PushFlags = {development: true, unpublished: true}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme).toMatchObject({role: DEVELOPMENT_THEME_ROLE})
})
test('returns live theme when live flag is provided', async () => {
// Given
vi.mocked(findOrSelectTheme).mockResolvedValue(buildTheme({id: 3, name: 'Live Theme', role: LIVE_THEME_ROLE})!)
const flags: PushFlags = {live: true, allowLive: true}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme).toMatchObject({role: LIVE_THEME_ROLE})
})
test('renders confirmation prompt if allowLive flag is not provided and selected theme role is live', async () => {
// Given
vi.mocked(findOrSelectTheme).mockResolvedValue(buildTheme({id: 3, name: 'Live Theme', role: LIVE_THEME_ROLE})!)
vi.mocked(renderConfirmationPrompt).mockResolvedValue(true)
const flags: PushFlags = {live: true}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme?.role).toBe(LIVE_THEME_ROLE)
expect(renderConfirmationPrompt).toHaveBeenCalled()
})
test("renders confirmation prompt if 'allow-live' flag is not provided and live theme is specified via theme flag", async () => {
// Given
vi.mocked(findOrSelectTheme).mockResolvedValue(buildTheme({id: 3, name: 'Live Theme', role: LIVE_THEME_ROLE})!)
vi.mocked(renderConfirmationPrompt).mockResolvedValue(true)
const flags: PushFlags = {theme: '3'}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme?.role).toBe(LIVE_THEME_ROLE)
expect(renderConfirmationPrompt).toHaveBeenCalled()
})
test('returns undefined if live theme confirmation prompt is not confirmed', async () => {
// Given
vi.mocked(findOrSelectTheme).mockResolvedValue(buildTheme({id: 3, name: 'Live Theme', role: LIVE_THEME_ROLE})!)
vi.mocked(renderConfirmationPrompt).mockResolvedValue(false)
const flags: PushFlags = {live: true}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme).toBeUndefined()
})
test('returns undefined if confirmation prompt is rejected', async () => {
// Given
vi.mocked(findOrSelectTheme).mockResolvedValue(buildTheme({id: 3, name: 'Live Theme', role: LIVE_THEME_ROLE})!)
vi.mocked(renderConfirmationPrompt).mockResolvedValue(false)
const flags = {live: true}
// When
const theme = await createOrSelectTheme(adminSession, flags)
// Then
expect(theme).toBeUndefined()
})
test('renders text prompt if unpublished flag is provided and theme flag is not provided', async () => {
// Given
const flags = {unpublished: true}
// When
await createOrSelectTheme(adminSession, flags)
// Then
expect(promptThemeName).toHaveBeenCalledWith('Name of the new theme')
})
describe('when run during a multi environment command', () => {
test('displays error when live theme is selected without allow-live flag', async () => {
// Given
vi.mocked(findOrSelectTheme).mockResolvedValue(buildTheme({id: 3, name: 'Live Theme', role: LIVE_THEME_ROLE})!)
const flags: PushFlags = {live: true, environment: ['production']}
// When
const theme = await createOrSelectTheme(adminSession, flags, true)
// Then
expect(theme).toBeUndefined()
expect(renderError).toHaveBeenCalledWith({
headline: 'Environment: production',
body: [
`Can't push theme files to the live theme on ${adminSession.storeFqdn}`,
'Use the --allow-live flag to push to a live theme.',
],
})
})
})
})