From a574ebdb112b2aacb007e1e42a75bae1ef1f5a0d Mon Sep 17 00:00:00 2001 From: Kieran Osgood Date: Tue, 13 Jan 2026 16:53:45 +0000 Subject: [PATCH 1/3] feat: enable typescript-eslint --- package.json | 13 +++++++++++-- sample/.eslintignore | 4 ++-- 2 files changed, 13 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index f301a90b..022b626d 100644 --- a/package.json +++ b/package.json @@ -24,7 +24,8 @@ "compare-snapshot": "./scripts/compare_snapshot", "turbo": "turbo", "test": "jest", - "env-to-xcconfig": "./scripts/env_to_xcconfig" + "env-to-xcconfig": "./scripts/env_to_xcconfig", + "lint": "eslint ." }, "devDependencies": { "@babel/core": "^7.25.2", @@ -82,10 +83,18 @@ "eslintConfig": { "root": true, "extends": "@react-native", + "parser": "@typescript-eslint/parser", + "parserOptions": { + "project": "./tsconfig.json" + }, + "plugins": [ + "@typescript-eslint" + ], "rules": { "@typescript-eslint/no-shadow": "off", "@typescript-eslint/consistent-type-imports": "error", + "@typescript-eslint/require-await": "error", "no-console": "error" } } -} +} \ No newline at end of file diff --git a/sample/.eslintignore b/sample/.eslintignore index ba885ebe..31ab1c6d 100644 --- a/sample/.eslintignore +++ b/sample/.eslintignore @@ -1,2 +1,2 @@ -android/build -android/app/build +android/ +ios/ From 37b35fecff0f6c1540d6095128a5dc1cbd27b690 Mon Sep 17 00:00:00 2001 From: Kieran Osgood Date: Tue, 13 Jan 2026 16:53:56 +0000 Subject: [PATCH 2/3] fix: remove useless await/async --- .../src/ShopifyCheckoutEventProvider.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/modules/@shopify/checkout-sheet-kit/src/ShopifyCheckoutEventProvider.tsx b/modules/@shopify/checkout-sheet-kit/src/ShopifyCheckoutEventProvider.tsx index b46e5953..80c55930 100644 --- a/modules/@shopify/checkout-sheet-kit/src/ShopifyCheckoutEventProvider.tsx +++ b/modules/@shopify/checkout-sheet-kit/src/ShopifyCheckoutEventProvider.tsx @@ -17,13 +17,13 @@ LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ -import React, {createContext, useContext, useRef, useCallback} from 'react'; -import {UIManager, findNodeHandle} from 'react-native'; +import React, { createContext, useContext, useRef, useCallback } from 'react'; +import { UIManager, findNodeHandle } from 'react-native'; interface CheckoutEventContextType { registerWebView: (webViewRef: React.RefObject) => void; unregisterWebView: () => void; - respondToEvent: (eventId: string, response: any) => Promise; + respondToEvent: (eventId: string, response: any) => boolean; } const CheckoutEventContext = createContext( @@ -52,7 +52,7 @@ export const ShopifyCheckoutEventProvider = ({ }, []); const respondToEvent = useCallback( - async (eventId: string, response: any): Promise => { + (eventId: string, response: any): boolean => { if (!webViewRef.current?.current) { return false; } @@ -112,11 +112,11 @@ export function useShopifyEvent(eventId: string) { return { id: eventId, respondWith: useCallback( - async (response: any) => { + (response: any) => { if (!eventContext) { return false; } - return await eventContext.respondToEvent(eventId, response); + return eventContext.respondToEvent(eventId, response); }, [eventId, eventContext], ), From 69183af624fcde4a28a77e145bc6311183e8f5cd Mon Sep 17 00:00:00 2001 From: Kieran Osgood Date: Wed, 14 Jan 2026 15:09:48 +0000 Subject: [PATCH 3/3] fix: remove useless eslint script --- package.json | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package.json b/package.json index 022b626d..4a20a981 100644 --- a/package.json +++ b/package.json @@ -24,8 +24,7 @@ "compare-snapshot": "./scripts/compare_snapshot", "turbo": "turbo", "test": "jest", - "env-to-xcconfig": "./scripts/env_to_xcconfig", - "lint": "eslint ." + "env-to-xcconfig": "./scripts/env_to_xcconfig" }, "devDependencies": { "@babel/core": "^7.25.2",