Skip to content

Commit f60bd8b

Browse files
author
github-actions
committed
gh-pages build: i18n: update coverage to auto-detect browser languages (OverlayPlugin#946)
f285d76: `coverage.ts` detects language from the web browser. c0cf1de: fix Korean translation 8cbefb1: remove `languagesArr` parameter from `browserLanguagesToLang` function. ## Removing `languagesArr` parameter ### Current Situation The `browserLanguagesToLang` function has a comment saying it only takes `navigator.languages` as input. But it still receives this value as a parameter, which is unnecessary. ### Option 1: Remove the parameter If the function only handles `navigator.languages`, we can remove the parameter and use `navigator.languages` directly inside the function. ### Option 2: Generalize the function If we want to support other locale arrays beyond `navigator.languages`, we could keep the parameter and rename the function to `localesToLang`. This makes it clear that the function converts any locale array to a cactbot language. --- This PR implements Option 1. Let me know if Option 2 is preferred. e14eec1
0 parents  commit f60bd8b

226 files changed

Lines changed: 708909 additions & 0 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

resources/ffxiv/LICENSE.txt

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
Files in this folder are art reused from Final Fantasy XIV.
2+
3+
FINAL FANTASY is a registered trademark of Square Enix Holdings Co., Ltd.
4+
5+
Final Fantasy art and icons reused non-commercially under the
6+
[FINAL FANTASY® XIV Materials Usage License](https://support.na.square-enix.com/rule.php?id=5382).

resources/ffxiv/jobs/acn.png

1.68 KB

resources/ffxiv/jobs/alc.png

1.78 KB

resources/ffxiv/jobs/arc.png

1.82 KB

resources/ffxiv/jobs/arm.png

1.64 KB
11.9 KB

resources/ffxiv/jobs/ast-large.png

19.3 KB

resources/ffxiv/jobs/ast.png

1.09 KB
13.8 KB

resources/ffxiv/jobs/blm-large.png

37.4 KB

0 commit comments

Comments
 (0)