Getter for DTO : new collection instead of original collection, to forbid modification

Author: antoineatstariongroup

SysML2.NET.CodeGenerator/HandleBarHelpers/PropertyHelper.cs

@@ -644,7 +644,7 @@ private static string GetRedefinedPropertyGetterImplementationForDto(IProperty r
 
             if (redefinedProperty.QueryIsEnumerable() && redefinition.QueryIsEnumerable())
             {
-                return $"{redefinitionPropertyName};";
+                return $"[..{redefinitionPropertyName}];";
             }
 
             if (redefinedProperty.QueryIsEnumerable() && !redefinition.QueryIsEnumerable())

SysML2.NET/Core/AutoGenDto/AcceptActionUsage.cs

@@ -75,7 +75,7 @@ public partial class AcceptActionUsage : IAcceptActionUsage
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IActionUsage.ActionDefinition")]
         [Implements(implementation: "IStep.Behavior")]
-        List<Guid> Kernel.Behaviors.IStep.behavior => this.actionDefinition;
+        List<Guid> Kernel.Behaviors.IStep.behavior => [.. this.actionDefinition];
 
         /// <summary>
         /// The Feature that are chained together to determine the values of this Feature, derived from the
@@ -125,7 +125,7 @@ public partial class AcceptActionUsage : IAcceptActionUsage
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IOccurrenceUsage.OccurrenceDefinition")]
         [Implements(implementation: "IUsage.Definition")]
-        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => ((SysML2.NET.Core.DTO.Systems.Occurrences.IOccurrenceUsage)this).occurrenceDefinition;
+        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => [.. ((SysML2.NET.Core.DTO.Systems.Occurrences.IOccurrenceUsage)this).occurrenceDefinition];
 
         /// <summary>
         /// The interpretations of a Type with differencingTypes are asserted to be those of the first of those
@@ -147,7 +147,7 @@ public partial class AcceptActionUsage : IAcceptActionUsage
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IStep.Parameter")]
         [Implements(implementation: "IType.DirectedFeature")]
-        List<Guid> Core.Types.IType.directedFeature => this.parameter;
+        List<Guid> Core.Types.IType.directedFeature => [.. this.parameter];
 
         /// <summary>
         /// The usages of this Usage that are directedFeatures.
@@ -707,7 +707,7 @@ bool Core.Features.IFeature.IsVariable
         [RedefinedProperty(propertyName: "_19_0_2_12e503d9_1591477641252_179221_958")]
         [RedefinedByProperty("IActionUsage.ActionDefinition")]
         [Implements(implementation: "IOccurrenceUsage.OccurrenceDefinition")]
-        List<Guid> Systems.Occurrences.IOccurrenceUsage.occurrenceDefinition => this.actionDefinition;
+        List<Guid> Systems.Occurrences.IOccurrenceUsage.occurrenceDefinition => [.. this.actionDefinition];
 
         /// <summary>
         /// All features related to this Type by FeatureMemberships that have direction out or inout.
@@ -1086,7 +1086,7 @@ bool Core.Features.IFeature.IsVariable
         [Property(xmiId: "_18_5_3_12e503d9_1533160674969_376003_43216", aggregation: AggregationKind.None, lowerValue: 0, upperValue: int.MaxValue, isOrdered: true, isReadOnly: false, isDerived: true, isDerivedUnion: false, isUnique: true, defaultValue: null)]
         [RedefinedByProperty("IUsage.Definition")]
         [Implements(implementation: "IFeature.Type")]
-        List<Guid> Core.Features.IFeature.type => ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition;
+        List<Guid> Core.Features.IFeature.type => [.. ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition];
 
         /// <summary>
         /// The interpretations of a Type with unioningTypes are asserted to be the same as those of all the

SysML2.NET/Core/AutoGenDto/ActionDefinition.cs

@@ -101,7 +101,7 @@ public partial class ActionDefinition : IActionDefinition
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IBehavior.Parameter")]
         [Implements(implementation: "IType.DirectedFeature")]
-        List<Guid> Core.Types.IType.directedFeature => this.parameter;
+        List<Guid> Core.Types.IType.directedFeature => [.. this.parameter];
 
         /// <summary>
         /// The usages of this Definition that are directedFeatures.

SysML2.NET/Core/AutoGenDto/ActionUsage.cs

@@ -76,7 +76,7 @@ public partial class ActionUsage : IActionUsage
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IActionUsage.ActionDefinition")]
         [Implements(implementation: "IStep.Behavior")]
-        List<Guid> Kernel.Behaviors.IStep.behavior => this.actionDefinition;
+        List<Guid> Kernel.Behaviors.IStep.behavior => [.. this.actionDefinition];
 
         /// <summary>
         /// The Feature that are chained together to determine the values of this Feature, derived from the
@@ -126,7 +126,7 @@ public partial class ActionUsage : IActionUsage
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IOccurrenceUsage.OccurrenceDefinition")]
         [Implements(implementation: "IUsage.Definition")]
-        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => ((SysML2.NET.Core.DTO.Systems.Occurrences.IOccurrenceUsage)this).occurrenceDefinition;
+        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => [.. ((SysML2.NET.Core.DTO.Systems.Occurrences.IOccurrenceUsage)this).occurrenceDefinition];
 
         /// <summary>
         /// The interpretations of a Type with differencingTypes are asserted to be those of the first of those
@@ -148,7 +148,7 @@ public partial class ActionUsage : IActionUsage
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IStep.Parameter")]
         [Implements(implementation: "IType.DirectedFeature")]
-        List<Guid> Core.Types.IType.directedFeature => this.parameter;
+        List<Guid> Core.Types.IType.directedFeature => [.. this.parameter];
 
         /// <summary>
         /// The usages of this Usage that are directedFeatures.
@@ -708,7 +708,7 @@ bool Core.Features.IFeature.IsVariable
         [RedefinedProperty(propertyName: "_19_0_2_12e503d9_1591477641252_179221_958")]
         [RedefinedByProperty("IActionUsage.ActionDefinition")]
         [Implements(implementation: "IOccurrenceUsage.OccurrenceDefinition")]
-        List<Guid> Systems.Occurrences.IOccurrenceUsage.occurrenceDefinition => this.actionDefinition;
+        List<Guid> Systems.Occurrences.IOccurrenceUsage.occurrenceDefinition => [.. this.actionDefinition];
 
         /// <summary>
         /// All features related to this Type by FeatureMemberships that have direction out or inout.
@@ -1062,7 +1062,7 @@ bool Core.Features.IFeature.IsVariable
         [Property(xmiId: "_18_5_3_12e503d9_1533160674969_376003_43216", aggregation: AggregationKind.None, lowerValue: 0, upperValue: int.MaxValue, isOrdered: true, isReadOnly: false, isDerived: true, isDerivedUnion: false, isUnique: true, defaultValue: null)]
         [RedefinedByProperty("IUsage.Definition")]
         [Implements(implementation: "IFeature.Type")]
-        List<Guid> Core.Features.IFeature.type => ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition;
+        List<Guid> Core.Features.IFeature.type => [.. ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition];
 
         /// <summary>
         /// The interpretations of a Type with unioningTypes are asserted to be the same as those of all the

SysML2.NET/Core/AutoGenDto/AllocationDefinition.cs

@@ -74,7 +74,7 @@ public partial class AllocationDefinition : IAllocationDefinition
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1562476168385_824569_22106")]
         [RedefinedByProperty("IConnectionDefinition.ConnectionEnd")]
         [Implements(implementation: "IAssociation.AssociationEnd")]
-        List<Guid> Kernel.Associations.IAssociation.associationEnd => this.connectionEnd;
+        List<Guid> Kernel.Associations.IAssociation.associationEnd => [.. this.connectionEnd];
 
         /// <summary>
         /// The Usages that define the things related by the ConnectionDefinition.
@@ -155,7 +155,7 @@ public partial class AllocationDefinition : IAllocationDefinition
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IAssociation.AssociationEnd")]
         [Implements(implementation: "IType.EndFeature")]
-        List<Guid> Core.Types.IType.endFeature => ((SysML2.NET.Core.DTO.Kernel.Associations.IAssociation)this).associationEnd;
+        List<Guid> Core.Types.IType.endFeature => [.. ((SysML2.NET.Core.DTO.Kernel.Associations.IAssociation)this).associationEnd];
 
         /// <summary>
         /// The ownedMemberFeatures of the featureMemberships of this Type.
@@ -785,7 +785,7 @@ bool Core.Types.IType.IsSufficient
         [Property(xmiId: "_18_5_3_12e503d9_1533160674961_132339_43177", aggregation: AggregationKind.None, lowerValue: 0, upperValue: int.MaxValue, isOrdered: true, isReadOnly: false, isDerived: true, isDerivedUnion: false, isUnique: false, defaultValue: null)]
         [RedefinedByProperty("IAssociation.RelatedType")]
         [Implements(implementation: "IRelationship.RelatedElement")]
-        List<Guid> Root.Elements.IRelationship.relatedElement => this.relatedType;
+        List<Guid> Root.Elements.IRelationship.relatedElement => [.. this.relatedType];
 
         /// <summary>
         /// The types of the associationEnds of the Association, which are the relatedElements of the
@@ -837,7 +837,7 @@ List<Guid> Root.Elements.IRelationship.Source
         [Implements(implementation: "IRelationship.Target")]
         List<Guid> Root.Elements.IRelationship.Target
         {
-            get => this.targetType;
+            get => [.. this.targetType];
             set { }
         }
 

SysML2.NET/Core/AutoGenDto/AllocationUsage.cs

@@ -70,7 +70,7 @@ public partial class AllocationUsage : IAllocationUsage
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IConnectionUsage.ConnectionDefinition")]
         [Implements(implementation: "IConnector.Association")]
-        List<Guid> Kernel.Connectors.IConnector.association => ((SysML2.NET.Core.DTO.Systems.Connections.IConnectionUsage)this).connectionDefinition;
+        List<Guid> Kernel.Connectors.IConnector.association => [.. ((SysML2.NET.Core.DTO.Systems.Connections.IConnectionUsage)this).connectionDefinition];
 
         /// <summary>
         /// The Feature that are chained together to determine the values of this Feature, derived from the
@@ -94,7 +94,7 @@ public partial class AllocationUsage : IAllocationUsage
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1533160674983_471497_43284")]
         [RedefinedByProperty("IAllocationUsage.AllocationDefinition")]
         [Implements(implementation: "IConnectionUsage.ConnectionDefinition")]
-        List<Guid> Systems.Connections.IConnectionUsage.connectionDefinition => this.allocationDefinition;
+        List<Guid> Systems.Connections.IConnectionUsage.connectionDefinition => [.. this.allocationDefinition];
 
         /// <summary>
         /// The endFeatures of a Connector, which redefine the endFeatures of the associations of the Connector.
@@ -151,7 +151,7 @@ public partial class AllocationUsage : IAllocationUsage
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IOccurrenceUsage.OccurrenceDefinition")]
         [Implements(implementation: "IUsage.Definition")]
-        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => this.occurrenceDefinition;
+        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => [.. this.occurrenceDefinition];
 
         /// <summary>
         /// The interpretations of a Type with differencingTypes are asserted to be those of the first of those
@@ -215,7 +215,7 @@ public partial class AllocationUsage : IAllocationUsage
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IConnector.ConnectorEnd")]
         [Implements(implementation: "IType.EndFeature")]
-        List<Guid> Core.Types.IType.endFeature => this.connectorEnd;
+        List<Guid> Core.Types.IType.endFeature => [.. this.connectorEnd];
 
         /// <summary>
         /// The Type that is related to this Feature by an EndFeatureMembership in which the Feature is an
@@ -1098,7 +1098,7 @@ bool Core.Features.IFeature.IsVariable
         [Property(xmiId: "_18_5_3_12e503d9_1533160674961_132339_43177", aggregation: AggregationKind.None, lowerValue: 0, upperValue: int.MaxValue, isOrdered: true, isReadOnly: false, isDerived: true, isDerivedUnion: false, isUnique: false, defaultValue: null)]
         [RedefinedByProperty("IConnector.RelatedFeature")]
         [Implements(implementation: "IRelationship.RelatedElement")]
-        List<Guid> Root.Elements.IRelationship.relatedElement => this.relatedFeature;
+        List<Guid> Root.Elements.IRelationship.relatedElement => [.. this.relatedFeature];
 
         /// <summary>
         /// The Features that are related by this Connector considered as a Relationship and that restrict the
@@ -1150,7 +1150,7 @@ List<Guid> Root.Elements.IRelationship.Source
         [Implements(implementation: "IRelationship.Target")]
         List<Guid> Root.Elements.IRelationship.Target
         {
-            get => this.targetFeature;
+            get => [.. this.targetFeature];
             set { }
         }
 
@@ -1182,7 +1182,7 @@ List<Guid> Root.Elements.IRelationship.Target
         [Property(xmiId: "_18_5_3_12e503d9_1533160674969_376003_43216", aggregation: AggregationKind.None, lowerValue: 0, upperValue: int.MaxValue, isOrdered: true, isReadOnly: false, isDerived: true, isDerivedUnion: false, isUnique: true, defaultValue: null)]
         [RedefinedByProperty("IUsage.Definition")]
         [Implements(implementation: "IFeature.Type")]
-        List<Guid> Core.Features.IFeature.type => ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition;
+        List<Guid> Core.Features.IFeature.type => [.. ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition];
 
         /// <summary>
         /// The interpretations of a Type with unioningTypes are asserted to be the same as those of all the

SysML2.NET/Core/AutoGenDto/AnalysisCaseDefinition.cs

@@ -117,7 +117,7 @@ public partial class AnalysisCaseDefinition : IAnalysisCaseDefinition
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IBehavior.Parameter")]
         [Implements(implementation: "IType.DirectedFeature")]
-        List<Guid> Core.Types.IType.directedFeature => this.parameter;
+        List<Guid> Core.Types.IType.directedFeature => [.. this.parameter];
 
         /// <summary>
         /// The usages of this Definition that are directedFeatures.

SysML2.NET/Core/AutoGenDto/AnalysisCaseUsage.cs

@@ -161,7 +161,7 @@ public partial class AnalysisCaseUsage : IAnalysisCaseUsage
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IOccurrenceUsage.OccurrenceDefinition")]
         [Implements(implementation: "IUsage.Definition")]
-        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => ((SysML2.NET.Core.DTO.Systems.Occurrences.IOccurrenceUsage)this).occurrenceDefinition;
+        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => [.. ((SysML2.NET.Core.DTO.Systems.Occurrences.IOccurrenceUsage)this).occurrenceDefinition];
 
         /// <summary>
         /// The interpretations of a Type with differencingTypes are asserted to be those of the first of those
@@ -183,7 +183,7 @@ public partial class AnalysisCaseUsage : IAnalysisCaseUsage
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IStep.Parameter")]
         [Implements(implementation: "IType.DirectedFeature")]
-        List<Guid> Core.Types.IType.directedFeature => this.parameter;
+        List<Guid> Core.Types.IType.directedFeature => [.. this.parameter];
 
         /// <summary>
         /// The usages of this Usage that are directedFeatures.
@@ -768,7 +768,7 @@ bool Core.Features.IFeature.IsVariable
         [RedefinedProperty(propertyName: "_19_0_2_12e503d9_1591477641252_179221_958")]
         [RedefinedByProperty("IActionUsage.ActionDefinition")]
         [Implements(implementation: "IOccurrenceUsage.OccurrenceDefinition")]
-        List<Guid> Systems.Occurrences.IOccurrenceUsage.occurrenceDefinition => ((SysML2.NET.Core.DTO.Systems.Actions.IActionUsage)this).actionDefinition;
+        List<Guid> Systems.Occurrences.IOccurrenceUsage.occurrenceDefinition => [.. ((SysML2.NET.Core.DTO.Systems.Actions.IActionUsage)this).actionDefinition];
 
         /// <summary>
         /// All features related to this Type by FeatureMemberships that have direction out or inout.
@@ -1151,7 +1151,7 @@ bool Core.Features.IFeature.IsVariable
         [Property(xmiId: "_18_5_3_12e503d9_1533160674969_376003_43216", aggregation: AggregationKind.None, lowerValue: 0, upperValue: int.MaxValue, isOrdered: true, isReadOnly: false, isDerived: true, isDerivedUnion: false, isUnique: true, defaultValue: null)]
         [RedefinedByProperty("IUsage.Definition")]
         [Implements(implementation: "IFeature.Type")]
-        List<Guid> Core.Features.IFeature.type => ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition;
+        List<Guid> Core.Features.IFeature.type => [.. ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition];
 
         /// <summary>
         /// The interpretations of a Type with unioningTypes are asserted to be the same as those of all the

SysML2.NET/Core/AutoGenDto/AssertConstraintUsage.cs

@@ -132,7 +132,7 @@ public partial class AssertConstraintUsage : IAssertConstraintUsage
         [RedefinedProperty(propertyName: "_18_5_3_12e503d9_1533160674969_376003_43216")]
         [RedefinedByProperty("IOccurrenceUsage.OccurrenceDefinition")]
         [Implements(implementation: "IUsage.Definition")]
-        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => this.occurrenceDefinition;
+        List<Guid> Systems.DefinitionAndUsage.IUsage.definition => [.. this.occurrenceDefinition];
 
         /// <summary>
         /// The interpretations of a Type with differencingTypes are asserted to be those of the first of those
@@ -154,7 +154,7 @@ public partial class AssertConstraintUsage : IAssertConstraintUsage
         [SubsettedProperty(propertyName: "_18_5_3_12e503d9_1533160674959_326391_43166")]
         [RedefinedByProperty("IStep.Parameter")]
         [Implements(implementation: "IType.DirectedFeature")]
-        List<Guid> Core.Types.IType.directedFeature => this.parameter;
+        List<Guid> Core.Types.IType.directedFeature => [.. this.parameter];
 
         /// <summary>
         /// The usages of this Usage that are directedFeatures.
@@ -1111,7 +1111,7 @@ bool Core.Features.IFeature.IsVariable
         [Property(xmiId: "_18_5_3_12e503d9_1533160674969_376003_43216", aggregation: AggregationKind.None, lowerValue: 0, upperValue: int.MaxValue, isOrdered: true, isReadOnly: false, isDerived: true, isDerivedUnion: false, isUnique: true, defaultValue: null)]
         [RedefinedByProperty("IUsage.Definition")]
         [Implements(implementation: "IFeature.Type")]
-        List<Guid> Core.Features.IFeature.type => ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition;
+        List<Guid> Core.Features.IFeature.type => [.. ((SysML2.NET.Core.DTO.Systems.DefinitionAndUsage.IUsage)this).definition];
 
         /// <summary>
         /// The interpretations of a Type with unioningTypes are asserted to be the same as those of all the