fix(mssql-python): Constrain supported versions.

Author: douglaso-profusion

pyproject.toml

@@ -42,7 +42,7 @@ classifiers = [
 athena = ["PyAthena[Pandas]"]
 azuresql = ["pymssql"]
 azuresql-odbc = ["pyodbc>=5.0.0"]
-azuresql-mssql-python = ["mssql-python>=1.1.0"]
+azuresql-mssql-python = ["mssql-python>=1.1.0;python_version>=\"3.10\""]
 bigquery = [
     "google-cloud-bigquery[pandas]",
     "google-cloud-bigquery-storage"
@@ -85,7 +85,7 @@ dev = [
     "PyAthena[Pandas]",
     "PyGithub>=2.6.0",
     "pyodbc>=5.0.0",
-    "mssql-python>=1.1.0",
+    "mssql-python>=1.1.0;python_version>=\"3.10\"",
     "pyperf",
     "pyspark~=3.5.0",
     "pytest",
@@ -111,13 +111,13 @@ dbt = ["dbt-core<2"]
 dlt = ["dlt"]
 duckdb = []
 fabric = ["pyodbc>=5.0.0"]
-fabric-mssql-python = ["mssql-python>=1.1.0"]
+fabric-mssql-python = ["mssql-python>=1.1.0;python_version>=\"3.10\""]
 gcppostgres = ["cloud-sql-python-connector[pg8000]>=1.8.0"]
 github = ["PyGithub>=2.6.0"]
 motherduck = ["duckdb>=1.2.0"]
 mssql = ["pymssql"]
 mssql-odbc = ["pyodbc>=5.0.0"]
-mssql-python = ["mssql-python>=1.1.0"]
+mssql-python = ["mssql-python>=1.1.0;python_version>=\"3.10\""]
 mysql = ["pymysql"]
 mwaa = ["boto3"]
 postgres = ["psycopg2"]

sqlmesh/core/config/connection.py

@@ -10,6 +10,7 @@
 import typing as t
 from enum import Enum
 from functools import partial
+from sys import version_info
 
 import pydantic
 from packaging import version
@@ -60,6 +61,7 @@
 }
 MOTHERDUCK_TOKEN_REGEX = re.compile(r"(\?|\&)(motherduck_token=)(\S*)")
 PASSWORD_REGEX = re.compile(r"(password=)(\S+)")
+SUPPORTS_MSSQL_PYTHON_DRIVER = (version_info.major, version_info.minor) >= (3, 10)
 
 
 def _get_engine_import_validator(
@@ -1622,6 +1624,9 @@ def _connection_factory(self) -> t.Callable:
             # The `mssql-python` implementation is API-compatible with
             # with the `pyodbc` equivalent for documented parameters.
 
+            if not SUPPORTS_MSSQL_PYTHON_DRIVER:
+                raise ConfigError("The `mssql-python` driver requires Python 3.10 or higher.")
+
             def connect_mssql_python(**kwargs: t.Any) -> t.Callable:
                 # Extract parameters for connection string
                 host = kwargs.pop("host")

tests/core/test_connection_config.py

@@ -9,6 +9,7 @@
 
 from sqlmesh.core.config.connection import (
     INIT_DISPLAY_INFO_TO_TYPE,
+    SUPPORTS_MSSQL_PYTHON_DRIVER,
     AthenaConnectionConfig,
     BigQueryConnectionConfig,
     ClickhouseConnectionConfig,
@@ -1464,10 +1465,11 @@ def test_mssql_engine_import_validator():
             MSSQLConnectionConfig(host="localhost", driver="pyodbc")
 
     # Test PyODBC driver suggests mssql-python extra when import fails
-    with pytest.raises(ConfigError, match=r"pip install \"sqlmesh\[mssql-python\]\""):
-        with patch("importlib.import_module") as mock_import:
-            mock_import.side_effect = ImportError("No module named 'mssql_python'")
-            MSSQLConnectionConfig(host="localhost", driver="mssql-python")
+    if SUPPORTS_MSSQL_PYTHON_DRIVER:
+        with pytest.raises(ConfigError, match=r"pip install \"sqlmesh\[mssql-python\]\""):
+            with patch("importlib.import_module") as mock_import:
+                mock_import.side_effect = ImportError("No module named 'mssql_python'")
+                MSSQLConnectionConfig(host="localhost", driver="mssql-python")
 
     # Test PyMSSQL driver suggests mssql extra when import fails
     with pytest.raises(ConfigError, match=r"pip install \"sqlmesh\[mssql\]\""):
@@ -1501,9 +1503,12 @@ def test_mssql_connection_config_parameter_validation(make_config):
     assert config.driver == "pyodbc"
 
     # Test explicit mssql-python driver
-    config = make_config(type="mssql", host="localhost", driver="mssql-python", check_import=False)
-    assert isinstance(config, MSSQLConnectionConfig)
-    assert config.driver == "mssql-python"
+    if SUPPORTS_MSSQL_PYTHON_DRIVER:
+        config = make_config(
+            type="mssql", host="localhost", driver="mssql-python", check_import=False
+        )
+        assert isinstance(config, MSSQLConnectionConfig)
+        assert config.driver == "mssql-python"
 
     # Test explicit pymssql driver
     config = make_config(type="mssql", host="localhost", driver="pymssql", check_import=False)
@@ -1528,19 +1533,20 @@ def test_mssql_connection_config_parameter_validation(make_config):
     assert config.odbc_properties == {"Authentication": "ActiveDirectoryServicePrincipal"}
 
     # Test mssql-python specific parameters
-    config = make_config(
-        type="mssql",
-        host="localhost",
-        driver="mssql-python",
-        trust_server_certificate=True,
-        encrypt=False,
-        odbc_properties={"Authentication": "ActiveDirectoryServicePrincipal"},
-        check_import=False,
-    )
-    assert isinstance(config, MSSQLConnectionConfig)
-    assert config.trust_server_certificate is True
-    assert config.encrypt is False
-    assert config.odbc_properties == {"Authentication": "ActiveDirectoryServicePrincipal"}
+    if SUPPORTS_MSSQL_PYTHON_DRIVER:
+        config = make_config(
+            type="mssql",
+            host="localhost",
+            driver="mssql-python",
+            trust_server_certificate=True,
+            encrypt=False,
+            odbc_properties={"Authentication": "ActiveDirectoryServicePrincipal"},
+            check_import=False,
+        )
+        assert isinstance(config, MSSQLConnectionConfig)
+        assert config.trust_server_certificate is True
+        assert config.encrypt is False
+        assert config.odbc_properties == {"Authentication": "ActiveDirectoryServicePrincipal"}
 
     # Test pymssql specific parameters
     config = make_config(
@@ -1603,30 +1609,32 @@ def test_mssql_connection_kwargs_keys():
     assert "conn_properties" not in pyodbc_keys
 
     # Test mssql-python driver keys
-    config = MSSQLConnectionConfig(host="localhost", driver="mssql-python", check_import=False)
-    mssql_python_keys = config._connection_kwargs_keys
-    expected_mssql_python_keys = {
-        "password",
-        "user",
-        "database",
-        "host",
-        "timeout",
-        "login_timeout",
-        "charset",
-        "appname",
-        "port",
-        "autocommit",
-        "trust_server_certificate",
-        "encrypt",
-        "odbc_properties",
-    }
-    assert mssql_python_keys == expected_mssql_python_keys
-
-    # Verify mssql-python keys don't include pymssql-specific parameters
-    assert "tds_version" not in mssql_python_keys
-    assert "conn_properties" not in mssql_python_keys
-
-
+    if SUPPORTS_MSSQL_PYTHON_DRIVER:
+        config = MSSQLConnectionConfig(host="localhost", driver="mssql-python", check_import=False)
+        mssql_python_keys = config._connection_kwargs_keys
+        expected_mssql_python_keys = {
+            "password",
+            "user",
+            "database",
+            "host",
+            "timeout",
+            "login_timeout",
+            "charset",
+            "appname",
+            "port",
+            "autocommit",
+            "trust_server_certificate",
+            "encrypt",
+            "odbc_properties",
+        }
+        assert mssql_python_keys == expected_mssql_python_keys
+
+        # Verify mssql-python keys don't include pymssql-specific parameters
+        assert "tds_version" not in mssql_python_keys
+        assert "conn_properties" not in mssql_python_keys
+
+
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_pyodbc_connection_string_generation():
     """Test pyodbc.connect gets invoked with the correct ODBC connection string."""
     with patch("pyodbc.connect") as mock_pyodbc_connect:
@@ -1676,6 +1684,7 @@ def test_mssql_pyodbc_connection_string_generation():
         assert call_args[1]["autocommit"] is False
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_pyodbc_connection_string_with_odbc_properties():
     """Test pyodbc connection string includes custom ODBC properties."""
     with patch("pyodbc.connect") as mock_pyodbc_connect:
@@ -1714,6 +1723,7 @@ def test_mssql_pyodbc_connection_string_with_odbc_properties():
         assert conn_str.count("TrustServerCertificate") == 1
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_pyodbc_connection_string_minimal():
     """Test pyodbc connection string with minimal configuration."""
     with patch("pyodbc.connect") as mock_pyodbc_connect:
@@ -1740,6 +1750,7 @@ def test_mssql_pyodbc_connection_string_minimal():
         assert mock_pyodbc_connect.call_args[1]["autocommit"] is True
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_mssql_python_connection_string_generation():
     """Test mssql_python.connect gets invoked with the correct ODBC connection string."""
     with patch("mssql_python.connect") as mock_mssql_python_connect:
@@ -1788,6 +1799,7 @@ def test_mssql_mssql_python_connection_string_generation():
         assert call_args[1]["autocommit"] is False
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_mssql_python_connection_string_with_odbc_properties():
     """Test mssql-python connection string includes custom ODBC properties."""
     with patch("mssql_python.connect") as mock_mssql_python_connect:
@@ -1826,6 +1838,7 @@ def test_mssql_mssql_python_connection_string_with_odbc_properties():
         assert conn_str.count("TrustServerCertificate") == 1
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_mssql_python_connection_string_minimal():
     """Test mssql-python connection string with minimal configuration."""
     with patch("mssql_python.connect") as mock_mssql_python_connect:
@@ -2005,6 +2018,7 @@ def mock_add_output_converter(sql_type, converter_func):
         assert result.tzinfo == timezone(timedelta(hours=-8))
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_mssql_python_connection_datetimeoffset_handling():
     """Test that the MSSQL mssql-python connection properly handles DATETIMEOFFSET conversion."""
     import struct
@@ -2077,6 +2091,7 @@ def mock_add_output_converter(sql_type, converter_func):
         assert result.tzinfo == timezone(timedelta(hours=5, minutes=30))
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_mssql_mssql_python_connection_negative_timezone_offset():
     """Test DATETIMEOFFSET handling with negative timezone offset at connection level."""
     import struct
@@ -2176,6 +2191,7 @@ def test_fabric_pyodbc_connection_config_parameter_validation(make_config):
         make_config(type="fabric", host="localhost", driver="pymssql", check_import=False)
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_fabric_mssql_python_connection_config_parameter_validation(make_config):
     """Test Fabric mssql-python connection config parameter validation."""
     # Test that FabricConnectionConfig correctly handles mssql-python-specific parameters.
@@ -2248,6 +2264,7 @@ def test_fabric_pyodbc_connection_string_generation():
         assert call_args[1]["autocommit"] is True
 
 
+@pytest.mark.xfail(not SUPPORTS_MSSQL_PYTHON_DRIVER, reason="mssql-python driver not supported")
 def test_fabric_mssql_python_connection_string_generation():
     """Test that the Fabric mssql-python connection gets invoked with the correct connection string."""
     with patch("mssql_python.connect") as mock_mssql_python_connect: