From 80f79f413a804e780e0f18f3c7ea36c6ab44b520 Mon Sep 17 00:00:00 2001 From: Gangwar Date: Thu, 19 Feb 2026 19:43:50 -0500 Subject: [PATCH 1/4] add_global_id --- src/pcms/create_field.cpp | 4 ++-- src/pcms/create_field.h | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/pcms/create_field.cpp b/src/pcms/create_field.cpp index 95db5d8f..13beb7ea 100644 --- a/src/pcms/create_field.cpp +++ b/src/pcms/create_field.cpp @@ -9,7 +9,7 @@ namespace pcms std::unique_ptr CreateLagrangeLayout( Omega_h::Mesh& mesh, int order, int num_components, - CoordinateSystem coordinate_system) + CoordinateSystem coordinate_system, std::string global_id_name) { std::array nodes_per_dim; @@ -21,7 +21,7 @@ std::unique_ptr CreateLagrangeLayout( } return std::make_unique(mesh, nodes_per_dim, - num_components, coordinate_system); + num_components, coordinate_system, global_id_name); } } // namespace pcms diff --git a/src/pcms/create_field.h b/src/pcms/create_field.h index 8cf7ba35..00618c8c 100644 --- a/src/pcms/create_field.h +++ b/src/pcms/create_field.h @@ -13,7 +13,8 @@ namespace pcms { std::unique_ptr CreateLagrangeLayout( Omega_h::Mesh& mesh, int order, int num_components, - CoordinateSystem coordinate_system); + CoordinateSystem coordinate_system, + std::string global_id_name="global"); } // namespace pcms #endif // CREATE_FIELD_H_ From 599b671123f06c53d42ed00afc478e5c08e1e8d5 Mon Sep 17 00:00:00 2001 From: Gangwar Date: Fri, 6 Mar 2026 12:15:58 -0500 Subject: [PATCH 2/4] merged_develop --- src/pcms/create_field.cpp | 3 ++- src/pcms/create_field.h | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/pcms/create_field.cpp b/src/pcms/create_field.cpp index 98f924e6..ddfa441a 100644 --- a/src/pcms/create_field.cpp +++ b/src/pcms/create_field.cpp @@ -14,7 +14,8 @@ namespace pcms std::unique_ptr CreateLagrangeLayout( Omega_h::Mesh& mesh, int order, int num_components, - CoordinateSystem coordinate_system, std::string global_id_name) + CoordinateSystem coordinate_system, + std::string global_id_name) { std::array nodes_per_dim; diff --git a/src/pcms/create_field.h b/src/pcms/create_field.h index 250028fe..950cc73e 100644 --- a/src/pcms/create_field.h +++ b/src/pcms/create_field.h @@ -19,7 +19,7 @@ namespace pcms { std::unique_ptr CreateLagrangeLayout( Omega_h::Mesh& mesh, int order, int num_components, - CoordinateSystem coordinate_system); + CoordinateSystem coordinate_system,); /** * \brief Create a binary field on a uniform grid indicating inside/outside mesh From 211dc19888835f68c94a52f39608574ed6569409 Mon Sep 17 00:00:00 2001 From: Gangwar Date: Fri, 6 Mar 2026 12:19:31 -0500 Subject: [PATCH 3/4] merged_develop --- src/pcms/create_field.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/pcms/create_field.h b/src/pcms/create_field.h index 950cc73e..a5bbc88b 100644 --- a/src/pcms/create_field.h +++ b/src/pcms/create_field.h @@ -19,7 +19,8 @@ namespace pcms { std::unique_ptr CreateLagrangeLayout( Omega_h::Mesh& mesh, int order, int num_components, - CoordinateSystem coordinate_system,); + CoordinateSystem coordinate_system, + std::string global_id_name="global"); /** * \brief Create a binary field on a uniform grid indicating inside/outside mesh From 998bd660e8eaf9ebc96c22ff19c9ddf67987f077 Mon Sep 17 00:00:00 2001 From: Gangwar Date: Fri, 6 Mar 2026 12:33:24 -0500 Subject: [PATCH 4/4] format --- src/pcms/create_field.cpp | 7 +++---- src/pcms/create_field.h | 3 +-- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/pcms/create_field.cpp b/src/pcms/create_field.cpp index ddfa441a..b3b44b36 100644 --- a/src/pcms/create_field.cpp +++ b/src/pcms/create_field.cpp @@ -14,8 +14,7 @@ namespace pcms std::unique_ptr CreateLagrangeLayout( Omega_h::Mesh& mesh, int order, int num_components, - CoordinateSystem coordinate_system, - std::string global_id_name) + CoordinateSystem coordinate_system, std::string global_id_name) { std::array nodes_per_dim; @@ -26,8 +25,8 @@ std::unique_ptr CreateLagrangeLayout( default: throw std::runtime_error("Unimplemented order"); } - return std::make_unique(mesh, nodes_per_dim, - num_components, coordinate_system, global_id_name); + return std::make_unique( + mesh, nodes_per_dim, num_components, coordinate_system, global_id_name); } template <> diff --git a/src/pcms/create_field.h b/src/pcms/create_field.h index a5bbc88b..b0d1a9d6 100644 --- a/src/pcms/create_field.h +++ b/src/pcms/create_field.h @@ -19,8 +19,7 @@ namespace pcms { std::unique_ptr CreateLagrangeLayout( Omega_h::Mesh& mesh, int order, int num_components, - CoordinateSystem coordinate_system, - std::string global_id_name="global"); + CoordinateSystem coordinate_system, std::string global_id_name = "global"); /** * \brief Create a binary field on a uniform grid indicating inside/outside mesh