Refactor: Simplify config and types, remove unused tsconfig

Co-authored-by: ryanclementshax <ryanclementshax@gmail.com>

Author: cursoragent

lib/constants.ts

@@ -5,11 +5,8 @@ export const IS_PREVIEW = process.env.VERCEL_ENV === 'preview'
 
 const protocol = IS_DEV ? 'http://' : 'https://'
 
-const configuredHost = process.env.NEXT_PUBLIC_URL && process.env.NEXT_PUBLIC_URL.trim().length > 0
-  ? process.env.NEXT_PUBLIC_URL
-  : 'localhost:3000'
-
-export const SITE_URL: string = protocol + configuredHost
+export const SITE_URL: string =
+  protocol + (process.env.NEXT_PUBLIC_URL ?? 'localhost:3000')
 
 export const RSS_FEED_URL = `${SITE_URL}/rss/feed.xml`
 export const JSON_FEED_URL = `${SITE_URL}/rss/feed.json`

next.config.mjs

@@ -6,12 +6,7 @@ import withBundleAnalyzer from '@next/bundle-analyzer'
 const config = {
   eslint: {
     // https://nextjs.org/docs/basic-features/eslint#linting-custom-directories-and-files
-    // Limit linting to app source to avoid Storybook/tests type noise in Next build
-    dirs: ['app', 'components', 'lib', 'types']
-  },
-  typescript: {
-    tsconfigPath: 'tsconfig.next.json',
-    ignoreBuildErrors: true
+    dirs: ['.']
   },
   images: {
     remotePatterns: [

stories/storyUtils.ts

@@ -3,7 +3,6 @@ import { BaseAnnotations, StoryAnnotations } from '@storybook/types'
 import { Theme } from 'components/theme'
 import merge from 'just-merge'
 import clone from 'just-clone'
-import type { PlayFunction } from '@storybook/types'
 
 export interface StoryModifier<T> {
   (story: StoryFn<T>): StoryFn<T>
@@ -78,7 +77,7 @@ export const withArgs: <T>(args?: Args<T>) => StoryModifier<T> =
 
 export const withPlay: <T>(play?: StorybookPlay<T>) => StoryModifier<T> =
   play => story => {
-    story.play = play as unknown as PlayFunction
+    story.play = play
     return story
   }
 

tests/testSetup.tsx

@@ -3,9 +3,8 @@ import { toHaveNoViolations } from 'jest-axe'
 import { setProjectAnnotations } from '@storybook/react'
 import * as globalStorybookConfig from '../.storybook/preview'
 import { LinkProps } from 'next/link'
-import type { ProjectAnnotations } from '@storybook/types'
 
-setProjectAnnotations(globalStorybookConfig as unknown as ProjectAnnotations)
+setProjectAnnotations(globalStorybookConfig)
 
 expect.extend(toHaveNoViolations)
 

tsconfig.json

@@ -25,14 +25,7 @@
       }
     ]
   },
-  "exclude": [
-    "node_modules",
-    ".next",
-    "out",
-    "storybook-static",
-    "**/dist",
-    "stories/**"
-  ],
+  "exclude": ["node_modules", ".next", "out", "storybook-static", "**/dist"],
   "include": [
     "next-env.d.ts",
     "**/*.ts",