[BUG] TypeError: Cannot read properties of undefined (reading 'trim') at ChatTextArea.tsx

[truong51972]

Problem (one or two sentences)

Error Stack:

TypeError: Cannot read properties of undefined (reading 'trim')
    at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:262:21)
    at ti (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:172:118)
    at useMemo (../../../../node_modules/.pnpm/react@18.3.1/node_modules/react/cjs/react.production.min.js:26:47)
    at inputValue.trim (../../../../webview-ui/src/components/chat/ChatTextArea.tsx:261:26)
    at Nh (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:160:136)
    at Yi (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:192:56)
    at f,b.memoizedState=f,b.flags&256){e=Ji(Error(p(423)),b);b=lj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:293:274)
    at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:388)
    at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:319)
    at tj (../../../../node_modules/.pnpm/react-dom@18.3.1_react@18.3.1/node_modules/react-dom/cjs/react-dom.production.min.js:279:179)

Component Stack:

    at https://vscode-remote+wsl-002bubuntu.vscode-resource.vscode-cdn.net/home/truong51972/.vscode-server/extensions/rooveterinaryinc.roo-cline-3.53.0/webview-ui/build/assets/index.js:2966:207656
    at div
at nco (../../../../webview-ui/src/components/chat/ChatView.tsx:69:3)
at bvo (../../../../webview-ui/src/App.tsx:69:5)
at d (../../../../node_modules/.pnpm/@radix-ui+react-context@1.1.2_@types+react@18.3.23_react@18.3.1/node_modules/@radix-ui/react-context/dist/index.mjs:27:14)
at kLt (../../../../node_modules/.pnpm/@radix-ui+react-tooltip@1.2.6_@types+react-dom@18.3.7_@types+react@18.3.23__@types+reac_99504aa956c623e0884a4e3cb215669a/node_modules/@radix-ui/react-tooltip/dist/index.mjs:29:4)
at R3 (../../../../webview-ui/src/components/ui/tooltip.tsx:8:47704)
at mFt (../../../../node_modules/.pnpm/@tanstack+react-query@5.76.1_react@18.3.1/node_modules/@tanstack/react-query/build/modern/QueryClientProvider.js:20:2)
at tHt (../../../../webview-ui/src/i18n/TranslationContext.tsx:16:70)
at YVt (../../../../webview-ui/src/context/ExtensionStateContext.tsx:192:86)
at lvo (../../../../webview-ui/src/components/ErrorBoundary.tsx:18:2)
at i (../../../../node_modules/.pnpm/react-i18next@15.5.1_i18next@25.2.1_typescript@5.8.3__react-dom@18.3.1_react@18.3.1__react@18.3.1_typescript@5.8.3/node_modules/react-i18next/dist/es/withTranslation.js:6:4)
at kvo (../../../../webview-ui/src/App.tsx:319:25)

Context (who is affected and when)

Happens when I use Ollama with qwen3-coder-next:cloud

Reproduction steps

Expected result

Show full options

Actual result

The options are empty

Variations tried (optional)

No response

App Version

v3.53.0

API Provider (optional)

None

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote-v0]

I've analyzed this issue and here's my proposed implementation plan:

Root Cause: inputValue (typed as string) can be undefined at runtime, causing inputValue.trim() to throw a TypeError. The crash happens in the hasInputContent useMemo at ChatTextArea.tsx:262.

While inputValue is initialized as "" via useState("") in ChatView.tsx, there are paths where it could become undefined -- for example if inputValueRef.current is stale and passed to setInputValue(preservedInput) during certain race conditions with message handling.

Proposed Fix: Add defensive guards to all inputValue.trim() call sites:

1. ChatTextArea.tsx (2 locations):

   • Line 248: const trimmedInput = inputValue.trim() -> (inputValue ?? "").trim()
   • Line 262: inputValue.trim().length > 0 -> (inputValue ?? "").trim().length > 0

2. ChatView.tsx (4 locations):

   • Line 206: inputValue.trim().length > 0 -> (inputValue ?? "").trim().length > 0
   • Line 713: inputValue.trim() -> (inputValue ?? "").trim()
   • Line 1539: inputValue.trim() -> (inputValue ?? "").trim()
   • Line 1544: inputValue.trim() -> (inputValue ?? "").trim()

This is a minimal, safe change that prevents the crash without altering any behavior when inputValue is a valid string.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.

[truong51972]

I approve this implementation plan. The root cause analysis correctly identifies the undefined state during race conditions, and the defensive guard using nullish coalescing is a safe, non-breaking fix for the reported TypeError. Please proceed with the implementation. @roomote

[roomote-v0]

Thanks for the approval! I've seen your comment and will proceed with the implementation now. I'll open a draft PR shortly to share progress.

[roomote-v0]

Opened PR #12305 with my attempt at addressing this. The fix adds defensive nullish coalescing guards at all 6 inputValue.trim() call sites in ChatTextArea.tsx and ChatView.tsx. All existing tests and lint/type checks pass. Feedback welcome! #12305