Fix isVisible() initial value bug in NestedListStringFormatter

The array_reduce in isVisible() used `true` as its initial value with
an `||` reducer, meaning it always returned `true` when siblings existed
regardless of their actual visibility. This caused unnecessary nesting
in full messages by showing single-child wrapper nodes that should have
been collapsed.

Replace array_reduce with a foreach loop starting from `false`, which
also enables early return on the first visible sibling.

Author: alganet

src/Message/Formatter/NestedListStringFormatter.php

@@ -17,7 +17,6 @@
 use Respect\Validation\Result;
 
 use function array_filter;
-use function array_reduce;
 use function count;
 use function rtrim;
 use function sprintf;
@@ -89,13 +88,14 @@ private function isVisible(Result $result, Result ...$siblings): bool
         }
 
         // The visibility of a result then will depend on whether any of its siblings is visible
-        return array_reduce(
-            $siblings,
-            fn(bool $carry, Result $currentSibling) => $carry || $this->isVisible(
-                $currentSibling,
-                ...array_filter($siblings, static fn(Result $sibling) => $sibling !== $currentSibling),
-            ),
-            true,
-        );
+        foreach ($siblings as $key => $currentSibling) {
+            $otherSiblings = $siblings;
+            unset($otherSiblings[$key]);
+            if ($this->isVisible($currentSibling, ...$otherSiblings)) {
+                return true;
+            }
+        }
+
+        return false;
     }
 }

tests/feature/AssertWithPropertiesTest.php

@@ -43,9 +43,7 @@
         ]))),
     fn(string $fullMessage) => expect($fullMessage)->toBe(<<<'FULL_MESSAGE'
         - the given data must pass all the rules
-          - `.mysql` must pass the rules
-            - `.mysql.host` must be a string
-          - `.postgresql` must pass the rules
-            - `.postgresql.user` must be a string
+          - `.mysql.host` must be a string
+          - `.postgresql.user` must be a string
         FULL_MESSAGE),
 ));

tests/feature/Issues/Issue796Test.php

@@ -46,10 +46,8 @@
         ->and($message)->toBe('`.mysql.host` (<- the given data) must be a string')
         ->and($fullMessage)->toBe(<<<'FULL_MESSAGE'
             - the given data must pass all the rules
-              - `.mysql` must pass the rules
-                - `.mysql.host` must be a string
-              - `.postgresql` must pass the rules
-                - `.postgresql.user` must be a string
+              - `.mysql.host` must be a string
+              - `.postgresql.user` must be a string
             FULL_MESSAGE)
         ->and($messages)->toBe([
             '__root__' => 'the given data must pass all the rules',