Skip to content

Commit 8276f7e

Browse files
authored
Merge pull request #2765 from ReactionMechanismGenerator/py39/cantera26-arm
Add support for running ARM macs natively
2 parents 80bb62f + a101ec4 commit 8276f7e

4 files changed

Lines changed: 7 additions & 17 deletions

File tree

.github/workflows/CI.yml

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ jobs:
5858
os: [macos-13, macos-latest, ubuntu-latest]
5959
include-rms: ["", "with RMS"]
6060
exclude:
61-
- os: macos-latest # needs Cantera 3 b/c x86 emulation breaks with Julia
62-
include-rms: 'with RMS'
6361
- os: macos-13 # GitHub's runners just aren't up to the task of installing Julia
6462
include-rms: 'with RMS'
6563
runs-on: ${{ matrix.os }}
@@ -73,10 +71,6 @@ jobs:
7371
- name: Checkout RMG-Py
7472
uses: actions/checkout@v4
7573

76-
- name: Compel Arm-based Mac to use x86
77-
if: matrix.os == 'macos-latest'
78-
run: echo "CONDA_SUBDIR=osx-64" >> $GITHUB_ENV
79-
8074
- name: Setup Miniforge Python ${{ matrix.python-version }}
8175
uses: conda-incubator/setup-miniconda@v3
8276
with:
@@ -87,7 +81,6 @@ jobs:
8781
activate-environment: rmg_env
8882
auto-update-conda: true
8983
show-channel-urls: true
90-
channels: conda-forge,cantera,rmg
9184
conda-remove-defaults: "true"
9285

9386
# list the environment for debugging purposes
@@ -164,7 +157,6 @@ jobs:
164157
activate-environment: rmg_env
165158
auto-update-conda: true
166159
show-channel-urls: true
167-
channels: conda-forge,cantera,rmg
168160
conda-remove-defaults: "true"
169161

170162
# list the environment for debugging purposes

.github/workflows/docs.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ jobs:
3636
activate-environment: rmg_env
3737
use-mamba: true
3838
show-channel-urls: true
39-
channels: conda-forge,cantera,rmg
4039

4140
- name: Install sphinx
4241
run: mamba install -y sphinx

environment.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
name: rmg_env
2626
channels:
2727
- conda-forge
28-
- cantera
2928
- rmg
3029
dependencies:
3130
# System-level dependencies - we could install these at the OS level
@@ -46,7 +45,7 @@ dependencies:
4645

4746
# external software tools for chemistry
4847
- conda-forge::coolprop
49-
- cantera::cantera =2.6
48+
- conda-forge::cantera =2.6
5049
- conda-forge::mopac
5150
# see https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2639#issuecomment-2050292972
5251
- conda-forge::cclib >=1.6.3,<1.9
@@ -59,7 +58,7 @@ dependencies:
5958
- conda-forge::cython >=0.25.2
6059
- conda-forge::scikit-learn
6160
- conda-forge::scipy >=1.9
62-
- conda-forge::numpy >=1.10.0
61+
- conda-forge::numpy >=1.10.0,<2
6362
- conda-forge::pydot
6463
- conda-forge::jinja2
6564
- conda-forge::jupyter

test/rmgpy/solver/liquidTest.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -167,21 +167,21 @@ def test_compute_flux(self):
167167

168168
# Check that we're computing the species fluxes correctly
169169
for i in range(t.shape[0]):
170-
assert abs(reaction_rates[i, 0] - species_rates[i, 0]) < abs(
170+
assert abs(reaction_rates[i, 0] - species_rates[i, 0]) <= abs(
171171
1e-6 * reaction_rates[i, 0]
172172
)
173-
assert abs(reaction_rates[i, 0] - -species_rates[i, 1]) < abs(
173+
assert abs(reaction_rates[i, 0] - -species_rates[i, 1]) <= abs(
174174
1e-6 * reaction_rates[i, 0]
175175
)
176-
assert abs(reaction_rates[i, 0] - -species_rates[i, 2]) < abs(
176+
assert abs(reaction_rates[i, 0] - -species_rates[i, 2]) <= abs(
177177
1e-6 * reaction_rates[i, 0]
178178
)
179-
assert abs(reaction_rates[i, 0] - species_rates[i, 3]) < abs(
179+
assert abs(reaction_rates[i, 0] - species_rates[i, 3]) <= abs(
180180
1e-6 * reaction_rates[i, 0]
181181
)
182182

183183
# Check that we've reached equilibrium
184-
assert abs(reaction_rates[-1, 0] - 0.0) < 1e-2
184+
assert abs(reaction_rates[-1, 0] - 0.0) <= 1e-2
185185

186186
def test_jacobian(self):
187187
"""

0 commit comments

Comments
 (0)