Missing UNPROTECT in push_back_name__impl

kevinushey · kevinushey · commit 0b021c9419a2 · 2014-01-19T19:18:58.000-08:00
diff --git a/ChangeLog b/ChangeLog
@@ -1,7 +1,12 @@
+2014-01-19  Kevin Ushey  <kevinushey@gmail.com>
+
+	* inst/include/Rcpp/api/meat/Vector.h: Add missing UNPROTECT in
+	push_back_name__impl
+
 2014-01-18  Kevin Ushey  <kevinushey@gmail.com>
 
-  * inst/unitTests/runit.S4.R: Add a test for ctor from slot proxy
-  * inst/unitTests/cpp/S4.cpp: Add a test for ctor from slot proxy
+	* inst/unitTests/runit.S4.R: Add a test for ctor from slot proxy
+	* inst/unitTests/cpp/S4.cpp: Add a test for ctor from slot proxy
 	* inst/include/Rcpp/vector/Vector.h: Add missing r_cast to vector
 	ctor from proxy
 
diff --git a/inst/include/Rcpp/api/meat/Vector.h b/inst/include/Rcpp/api/meat/Vector.h
@@ -368,6 +368,7 @@ namespace Rcpp{
                 *target_it = *it ;
                 SET_STRING_ELT( newnames, i , dummy );
             }
+            UNPROTECT(1);
         } else {
             for( ; it < this_end; ++it, ++target_it, i++ ){
                 *target_it = *it ;

Original file line number	Diff line number	Diff line change
`@@ -368,6 +368,7 @@ namespace Rcpp{`
`368`	`368`	`target_it = it ;`
`369`	`369`	`SET_STRING_ELT( newnames, i , dummy );`
`370`	`370`	`}`
	`371`	`+ UNPROTECT(1);`
`371`	`372`	`} else {`
`372`	`373`	`for( ; it < this_end; ++it, ++target_it, i++ ){`
`373`	`374`	`target_it = it ;`