failing test

Author: abcampo-iry

cypress/e2e/spec-html.cy.js

@@ -13,8 +13,7 @@ const getIframeDocument = () => {
 };
 
 const getIframeBody = () => {
-  const iframeDocument = getIframeDocument();
-  return iframeDocument.its("body").should("not.be.null").then(cy.wrap);
+  return getIframeDocument().its("body").should("not.be.null");
 };
 
 const makeNewFile = (filename = "new.html") => {
@@ -183,6 +182,9 @@ it("allows internal links", () => {
 
   const internalLink = getIframeBody().find("a");
   internalLink.click();
-  const content = getIframeBody().find("p");
-  content.should("include.text", "hello world");
+  cy.get("editor-wc")
+    .shadow()
+    .find("iframe[class=htmlrunner-iframe]")
+    .its("0.contentDocument.body")
+    .should("contain.text", "hello world");
 });

src/components/Editor/Runners/HtmlRunner/HtmlRunner.jsx

@@ -59,6 +59,7 @@ function HtmlRunner() {
 
   const dispatch = useDispatch();
   const output = useRef(null);
+  const reloadAfterPreviewChange = useRef(false);
 
   const isMobile = useMediaQuery({ query: MOBILE_MEDIA_QUERY });
 
@@ -141,6 +142,7 @@ function HtmlRunner() {
         } else if (event.data?.msg === "Allowed external link") {
           handleAllowedExternalLink(event.data.payload.linkTo);
         } else {
+          reloadAfterPreviewChange.current = true;
           handleRegularExternalLink(event.data.payload.linkTo, setPreviewFile);
         }
       }
@@ -205,6 +207,13 @@ function HtmlRunner() {
     }
   }, [focussedFileIndex, openFiles]);
 
+  useEffect(() => {
+    if (reloadAfterPreviewChange.current) {
+      reloadAfterPreviewChange.current = false;
+      dispatch(triggerCodeRun());
+    }
+  }, [previewFile]);
+
   useEffect(() => {
     if (isEmbedded && browserPreview) {
       dispatch(setPage(runningFile));

src/utils/externalLinkHelper.js

@@ -22,7 +22,6 @@ const useExternalLinkState = (showModal) => {
   const handleRegularExternalLink = (linkTo, setPreviewFile) => {
     setExternalLink(null);
     setPreviewFile(`${linkTo}.html`);
-    dispatch(triggerCodeRun());
   };
 
   const handleExternalLinkError = () => {