Use exists? to check domain

Author: PetarSimonovic

app/models/school.rb

@@ -117,8 +117,8 @@ def import_in_progress?
                         .exists?(description: id)
   end
 
-  def email_domain_is_valid?(domain)
-    email_domains.include?(domain)
+  def valid_domain?(candidate_domain)
+    school_email_domains.exists?(domain: candidate_domain)
   end
 
   private
@@ -179,8 +179,4 @@ def do_salesforce_sync(is_create:)
     Salesforce::SchoolSyncJob.perform_later(school_id: id, is_create:)
     Salesforce::ContactSyncJob.perform_later(school_id: id)
   end
-
-  def email_domains
-    @email_domains ||= school_email_domains.pluck(:domain)
-  end
 end

spec/models/school_spec.rb

@@ -683,7 +683,7 @@
     end
   end
 
-  describe '#email_domain_is_valid?' do
+  describe '#valid_domain?' do
     let(:valid_domain) { 'valid.edu' }
     let(:invalid_domain) { 'invalid.edu' }
 
@@ -692,11 +692,11 @@
     end
 
     it 'returns true when school has registered the email domain' do
-      expect(school.email_domain_is_valid?(valid_domain)).to be(true)
+      expect(school.valid_domain?(valid_domain)).to be(true)
     end
 
     it 'returns false when school has not registered the email domain' do
-      expect(school.email_domain_is_valid?(invalid_domain)).to be(false)
+      expect(school.valid_domain?(invalid_domain)).to be(false)
     end
   end
 end