fix: strip disabledReasons when saving blocks to backpack (#2680)

* refactor: extract cleanFlyoutInfo method in workspace-backpack

Extract the key-stripping logic from blockToJsonString into a reusable
cleanFlyoutInfo method. Also fix a potential null dereference when
Blockly.serialization.blocks.save returns null.

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

* fix: Strip the 'disabledReasons' property when saving blocks to the backpack.

Disabled blocks that are saved to the backpack retain their 'disabledReasons' property, which makes them impossible to take. Add 'disabledReasons' to the list of stripped keys and apply the stripping to blocks added via the 'Backpackable' interface ('addBackpackables').

Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com

Author: B-head

plugins/workspace-backpack/src/backpack.ts

@@ -467,32 +467,54 @@ export class Backpack
    * @returns The JSON object as a string.
    */
   private blockToJsonString(block: Blockly.Block): string {
-    const json = Blockly.serialization.blocks.save(block);
+    const json = Blockly.serialization.blocks.save(
+      block,
+    ) as Blockly.utils.toolbox.FlyoutItemInfo | null;
 
-    // Add a 'kind' key so the flyout can recognize it as a block.
-    (json as Blockly.utils.toolbox.FlyoutItemInfo).kind = 'BLOCK';
+    if (json) {
+      // Add a 'kind' key so the flyout can recognize it as a block.
+      json.kind = 'BLOCK';
+      this.cleanFlyoutInfo(json);
+    }
+
+    return JSON.stringify(json);
+  }
 
+  /**
+   * Removes unnecessary keys from flyout info in place.
+   *
+   * @param dirtyInfo The flyout info object to clean.
+   */
+  private cleanFlyoutInfo(dirtyInfo: Blockly.utils.toolbox.FlyoutItemInfo) {
     // The keys to remove.
-    const keys = ['id', 'height', 'width', 'pinned', 'enabled'];
-
-    // Traverse the JSON recursively.
-    const traverseJson = function (json: StateWithIndex, keys: string[]) {
-      for (const key in json) {
-        if (key) {
-          if (keys.indexOf(key) !== -1) {
-            delete json[key];
-          }
-          if (json[key] && typeof json[key] === 'object') {
-            traverseJson(json[key] as StateWithIndex, keys);
-          }
+    const removeKeys = [
+      'id',
+      'height',
+      'width',
+      'pinned',
+      'enabled',
+      'disabledReasons',
+    ];
+
+    // Traverse the object recursively.
+    const traverseClean = function (
+      obj: {[key: string]: unknown},
+      keys: string[],
+    ) {
+      for (const key of Object.keys(obj)) {
+        if (keys.indexOf(key) !== -1) {
+          delete obj[key];
+          continue;
+        }
+
+        const item = obj[key];
+        if (item !== null && typeof item === 'object') {
+          traverseClean(item as {[key: string]: unknown}, keys);
         }
       }
     };
 
-    if (json) {
-      traverseJson(json as StateWithIndex, keys);
-    }
-    return JSON.stringify(json);
+    traverseClean(dirtyInfo as unknown as {[key: string]: unknown}, removeKeys);
   }
 
   /**
@@ -600,7 +622,10 @@ export class Backpack
       backpackables
         .map((b) => b.toFlyoutInfo())
         .reduce((acc, curr) => [...acc, ...curr])
-        .map((info) => JSON.stringify(info)),
+        .map((info) => {
+          this.cleanFlyoutInfo(info);
+          return JSON.stringify(info);
+        }),
     );
   }
 
@@ -1033,7 +1058,3 @@ class BackpackSerializer {
     backpack?.empty();
   }
 }
-
-interface StateWithIndex extends Blockly.serialization.blocks.State {
-  [key: string]: unknown;
-}