Skip to content

Commit 1e6f0da

Browse files
committed
lint checks addressed
1 parent f12300e commit 1e6f0da

5 files changed

Lines changed: 192 additions & 150 deletions

File tree

.github/workflows/linting.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,9 @@ name: Linting
33
on:
44
push:
55
branches:
6-
- develop
76
- main
87
pull_request:
98
branches:
10-
- develop
119
- main
1210

1311
jobs:

.wordlist.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -907,3 +907,7 @@ datacenter
907907
programmability
908908
uptime
909909
TPX
910+
daemon
911+
workaround
912+
VirtioFS
913+
paravirtualization

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ AMD Container Toolkit offers tools to streamline the use of AMD GPUs with contai
44
- ```amd-ctk``` - The AMD Container Toolkit CLI
55

66
# Requirements
7-
- Ubuntu 22.02 or 24.04, or RHEL/CentOS 9
7+
- Ubuntu 22.04 or 24.04, or RHEL/CentOS 9
88
- Docker version 25 or later
99
- All the 'amd-ctk runtime configure' commands should be run as root/sudo
1010

@@ -24,7 +24,7 @@ To install the AMD Container Toolkit on Ubuntu systems, follow these steps:
2424
wget https://repo.radeon.com/rocm/rocm.gpg.key -O - | gpg --dearmor | tee /etc/apt/keyrings/rocm.gpg > /dev/null
2525
```
2626

27-
3. Add the repository to your system. Replace `noble` with `jammy` if you are using Ubuntu 22.04:
27+
3. Add the repository to the system. Replace `noble` with `jammy` when using Ubuntu 22.04:
2828
```bash
2929
echo "deb [signed-by=/etc/apt/keyrings/rocm.gpg] https://repo.radeon.com/amd-container-toolkit/apt/ noble main" > /etc/apt/sources.list.d/amd-container-toolkit.list
3030
```
@@ -180,7 +180,7 @@ The AMD Container Toolkit supports GPU selection using unique identifiers (UUIDs
180180
181181
## Getting GPU UUIDs
182182
183-
You can obtain GPU UUIDs using different tools:
183+
GPU UUIDs can be obtained using different tools:
184184
185185
### Using ROCm SMI
186186
```bash
@@ -194,7 +194,7 @@ GPU[1] : Unique ID: 0x1234567890abcdef
194194
```
195195
196196
### Using AMD-SMI
197-
You can also use `amd-smi` to get the ASIC_SERIAL, which serves as the GPU UUID:
197+
The `amd-smi` tool can also be used to get the ASIC_SERIAL, which serves as the GPU UUID:
198198
199199
```bash
200200
amd-smi static -aB
@@ -223,7 +223,7 @@ GPU: 0
223223
MANUFACTURER_NAME: AMD
224224
```
225225
226-
Use the `ASIC_SERIAL` value (e.g., `0xD1CC3F11CFDD5112`) as the GPU UUID in your container configurations.
226+
Use the `ASIC_SERIAL` value (e.g., `0xD1CC3F11CFDD5112`) as the GPU UUID in container configurations.
227227
228228
## Using UUIDs with Environment Variables
229229

docs/container-runtime/docker-swarm.md

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
# Docker Swarm Integration
22

3-
### Purpose
3+
## Purpose
44

55
Docker Swarm integration allows orchestrated GPU workloads to be deployed across multiple nodes by leveraging **GPU UUIDs** and Docker’s resource framework.
66

7-
### Docker Daemon Configuration for Swarm
7+
## Docker Daemon Configuration for Swarm
88

99
Configure each swarm node's Docker daemon with GPU resources in `/etc/docker/daemon.json`:
1010

@@ -26,10 +26,12 @@ Configure each swarm node's Docker daemon with GPU resources in `/etc/docker/dae
2626
```
2727

2828
After updating the configuration, restart the Docker daemon:
29+
2930
```bash
3031
sudo systemctl restart docker
3132
```
32-
### Deploy GPU Enabled Services
33+
34+
## Deploy GPU Enabled Services
3335

3436
Deploy services with specific GPU requirements using docker-compose:
3537

@@ -68,6 +70,7 @@ services:
6870
```
6971
7072
Deploy the service:
73+
7174
```bash
7275
docker stack deploy -c docker-compose.yml rocm-stack
7376
```

0 commit comments

Comments
 (0)