Merge pull request #397 from Quickchive/fix/improve-exception-filter-logging

Fix/improve exception filter logging

Author: stae1102

src/common/exceptions/http-exception.filter.ts

@@ -3,7 +3,7 @@ import {
   Catch,
   ExceptionFilter,
   HttpException,
-  HttpStatus,
+  HttpStatus, InternalServerErrorException,
 } from '@nestjs/common';
 import { Request, Response } from 'express';
 import { logger } from '../logger';
@@ -34,7 +34,7 @@ class ErrorResponse {
 
 @Catch()
 export class HttpExceptionFilter implements ExceptionFilter {
-  catch(exception: HttpException, host: ArgumentsHost) {
+  catch(exception: HttpException | Error, host: ArgumentsHost) {
     const ctx = host.switchToHttp();
     const response = ctx.getResponse<Response>();
     const request = ctx.getRequest<Request>();
@@ -44,12 +44,16 @@ export class HttpExceptionFilter implements ExceptionFilter {
         : HttpStatus.INTERNAL_SERVER_ERROR;
     const { ip, method, url } = request;
     logger.error(
-      `${method} - ${url} - ${ip.split(':').at(-1)} - ${JSON.stringify(
+      `${method} - ${url} - ${ip?.split(':')?.at(-1)} - ${JSON.stringify(
         exception,
       )}`,
     );
 
-    const exceptionResponse = exception.getResponse() as {
+    if (!(exception instanceof HttpException)) {
+      exception = new InternalServerErrorException(exception.message);
+    }
+
+    const exceptionResponse = (exception as HttpException).getResponse() as {
       error: string;
       message?: string | string[];
       data?: any;