refactor: wrap room response processing in try-except block and fix test docstring

Author: allenporter

roborock/devices/traits/v1/rooms.py

@@ -95,7 +95,12 @@ async def refresh(self) -> None:
         """Refresh room mappings and backfill unknown room names from the web API."""
         response = await self.rpc_channel.send_command(self.command)
         if not isinstance(response, list):
-            raise ValueError(f"Unexpected RoomsTrait response format: {response!r}")
+            raise RoborockParsingException(
+                trait_name=type(self).__name__,
+                command=self.command,
+                payload=response,
+                inner_error="Unexpected RoomsTrait response format",
+            )
 
         segment_map = RoomsConverter.extract_segment_map(response)
         # Track all iot ids seen before. Refresh the room list when new ids are found.
@@ -106,7 +111,6 @@ async def refresh(self) -> None:
                 _LOGGER.debug("Updating rooms: %s", list(updated_rooms))
                 self._home_data.rooms = updated_rooms
             self._discovered_iot_ids.update(new_iot_ids)
-
         try:
             rooms = self.converter.convert(response)
         except (TypeError, ValueError) as err:
@@ -116,6 +120,7 @@ async def refresh(self) -> None:
                 payload=response,
                 inner_error=err,
             ) from err
+
         rooms = rooms.with_room_names(self._home_data.rooms_name_map)
         common.merge_trait_values(self, rooms)
 

roborock/exceptions.py

@@ -99,7 +99,7 @@ class RoborockUnsupportedFeature(RoborockException):
 class RoborockParsingException(RoborockException):
     """Class for Roborock exceptions when parsing device responses."""
 
-    def __init__(self, trait_name: str, command: Enum | str, payload: Any, inner_error: Exception) -> None:
+    def __init__(self, trait_name: str, command: Enum | str, payload: Any, inner_error: Exception | str) -> None:
         cmd_name = command.name if isinstance(command, Enum) else str(command)
         self.message = (
             f"Failed to parse {cmd_name} response for {trait_name}. Payload: {payload!r} Error: {inner_error!r}"

tests/devices/traits/v1/test_common.py

@@ -44,7 +44,7 @@ async def test_fake_trait_bad_payload() -> None:
 
 
 async def test_valid_payload() -> None:
-    """Test that parsing a bad payload throws a helpful parsing error."""
+    """Test that a valid payload parses successfully."""
     trait = FakeTrait()
     trait._rpc_channel.send_command.return_value = [{"fake_field": 123, "other_field": "abc"}]
     await trait.refresh()